[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.0' - 2 commits - extensions/source

[Libreoffice Gerrit user]

 extensions/source/ole/unoobjw.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit e5f241db76f4c02c8070fee9d66c2f355ce452ed
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Thu Mar 7 14:55:57 2019 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Mar 7 14:55:57 2019 +0200

    Add FIXME
    
    Change-Id: Id8a553ef880c79a1d71b6df9586f75a83f53746a

diff --git a/extensions/source/ole/unoobjw.cxx b/extensions/source/ole/unoobjw.cxx
index 9824b9ec4394..84bb3ed4b420 100644
--- a/extensions/source/ole/unoobjw.cxx
+++ b/extensions/source/ole/unoobjw.cxx
@@ -894,6 +894,7 @@ HRESULT STDMETHODCALLTYPE CXTypeInfo::GetDocumentation(MEMBERID memid,
         }
         else
         {
+            // FIXME: Shouldn't we be able to know the names of the members of UNO interfaces?
             *pBstrName = SysAllocString(o3tl::toW(OUString(OUString("UnknownNameOfMember#") + OUString::number(memid)).getStr()));
         }
     }
commit 29dab3f605c52e583d23b065499a3a3b72bd6490
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Thu Mar 7 14:41:55 2019 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Mar 7 14:54:56 2019 +0200

    Generate more specific names for unknown members than just "Unknown"
    
    Include the numeric member id in the name. Hopefully makes it a bit
    easier to interpret log files produced by LibreOffice or by the COLEAT
    tool.
    
    Change-Id: I7270b9538cf1a75db8972fb91eb57b931fe8e320

diff --git a/extensions/source/ole/unoobjw.cxx b/extensions/source/ole/unoobjw.cxx
index 798418f482d7..9824b9ec4394 100644
--- a/extensions/source/ole/unoobjw.cxx
+++ b/extensions/source/ole/unoobjw.cxx
@@ -894,7 +894,7 @@ HRESULT STDMETHODCALLTYPE CXTypeInfo::GetDocumentation(MEMBERID memid,
         }
         else
         {
-            *pBstrName = SysAllocString(L"Unknown");
+            *pBstrName = SysAllocString(o3tl::toW(OUString(OUString("UnknownNameOfMember#") + OUString::number(memid)).getStr()));
         }
     }
     if (pBstrDocString)