[Libreoffice-commits] core.git: 2 commits - qadevOOo/objdsc sc/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Mar 10 06:14:35 UTC 2019


 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv |    5 ---
 sc/qa/extras/scchartsobj.cxx                                |   17 +++++++++++-
 2 files changed, 16 insertions(+), 6 deletions(-)

New commits:
commit 197988d28c970c166a750d4b36e17287f083822f
Author:     Jens Carl <j.carl43 at gmx.de>
AuthorDate: Sun Mar 10 01:52:19 2019 +0000
Commit:     Jens Carl <j.carl43 at gmx.de>
CommitDate: Sun Mar 10 07:14:25 2019 +0100

    tdf#45904 Move XNameAccess Java tests to C++
    
    Move XNameAccess Java tests to C++ for ScChartsObj.
    
            modified:   sc/qa/extras/scchartsobj.cxx
    
    Change-Id: I0599bebf163b122ce315b843337adee08abf2ae3
    Reviewed-on: https://gerrit.libreoffice.org/68990
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.carl43 at gmx.de>

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv
index 6befc7f3318c..3efd1952c17a 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv
@@ -1,5 +1,2 @@
-"ScChartsObj";"com::sun::star::container::XNameAccess";"getByName()"
-"ScChartsObj";"com::sun::star::container::XNameAccess";"getElementNames()"
-"ScChartsObj";"com::sun::star::container::XNameAccess";"hasByName()"
 "ScChartsObj";"com::sun::star::table::XTableCharts";"addNewByName()"
 "ScChartsObj";"com::sun::star::table::XTableCharts";"removeByName()"
diff --git a/sc/qa/extras/scchartsobj.cxx b/sc/qa/extras/scchartsobj.cxx
index caeff557fe94..b0e25af70eee 100644
--- a/sc/qa/extras/scchartsobj.cxx
+++ b/sc/qa/extras/scchartsobj.cxx
@@ -11,6 +11,7 @@
 #include <test/container/xelementaccess.hxx>
 #include <test/container/xenumerationaccess.hxx>
 #include <test/container/xindexaccess.hxx>
+#include <test/container/xnameaccess.hxx>
 #include <cppu/unotype.hxx>
 
 #include <com/sun/star/awt/Rectangle.hpp>
@@ -38,7 +39,8 @@ namespace sc_apitest
 class ScChartsObj : public CalcUnoApiTest,
                     public apitest::XEnumerationAccess,
                     public apitest::XElementAccess,
-                    public apitest::XIndexAccess
+                    public apitest::XIndexAccess,
+                    public apitest::XNameAccess
 {
 public:
     ScChartsObj();
@@ -60,6 +62,11 @@ public:
     CPPUNIT_TEST(testGetByIndex);
     CPPUNIT_TEST(testGetCount);
 
+    // XNameAccess
+    CPPUNIT_TEST(testGetByName);
+    CPPUNIT_TEST(testGetElementNames);
+    CPPUNIT_TEST(testHasByName);
+
     CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -70,6 +77,7 @@ ScChartsObj::ScChartsObj()
     : CalcUnoApiTest("/sc/qa/extras/testdocuments")
     , XElementAccess(cppu::UnoType<table::XTableChart>::get())
     , XIndexAccess(1)
+    , XNameAccess("ScChartsObj")
 {
 }
 
commit ea27ea0fb708a502748a83b1196a3821e568ed9e
Author:     Jens Carl <j.carl43 at gmx.de>
AuthorDate: Sun Mar 10 01:42:22 2019 +0000
Commit:     Jens Carl <j.carl43 at gmx.de>
CommitDate: Sun Mar 10 07:14:13 2019 +0100

    tdf#45904 Move XIndexAccess Java tests to C++
    
    Move XIndexAccess Java tests to C++ for ScChartsObj.
    
    Change-Id: I1a6babb59e6feb2ed825f9ca698a8852f8bce6bb
    Reviewed-on: https://gerrit.libreoffice.org/68989
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.carl43 at gmx.de>

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv
index 149d92e110da..6befc7f3318c 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScChartsObj.csv
@@ -1,7 +1,5 @@
 "ScChartsObj";"com::sun::star::container::XNameAccess";"getByName()"
 "ScChartsObj";"com::sun::star::container::XNameAccess";"getElementNames()"
 "ScChartsObj";"com::sun::star::container::XNameAccess";"hasByName()"
-"ScChartsObj";"com::sun::star::container::XIndexAccess";"getCount()"
-"ScChartsObj";"com::sun::star::container::XIndexAccess";"getByIndex()"
 "ScChartsObj";"com::sun::star::table::XTableCharts";"addNewByName()"
 "ScChartsObj";"com::sun::star::table::XTableCharts";"removeByName()"
diff --git a/sc/qa/extras/scchartsobj.cxx b/sc/qa/extras/scchartsobj.cxx
index df40621aa6a2..caeff557fe94 100644
--- a/sc/qa/extras/scchartsobj.cxx
+++ b/sc/qa/extras/scchartsobj.cxx
@@ -10,6 +10,7 @@
 #include <test/calc_unoapi_test.hxx>
 #include <test/container/xelementaccess.hxx>
 #include <test/container/xenumerationaccess.hxx>
+#include <test/container/xindexaccess.hxx>
 #include <cppu/unotype.hxx>
 
 #include <com/sun/star/awt/Rectangle.hpp>
@@ -36,7 +37,8 @@ namespace sc_apitest
 {
 class ScChartsObj : public CalcUnoApiTest,
                     public apitest::XEnumerationAccess,
-                    public apitest::XElementAccess
+                    public apitest::XElementAccess,
+                    public apitest::XIndexAccess
 {
 public:
     ScChartsObj();
@@ -54,6 +56,10 @@ public:
     CPPUNIT_TEST(testGetElementType);
     CPPUNIT_TEST(testHasElements);
 
+    // XIndexAccess
+    CPPUNIT_TEST(testGetByIndex);
+    CPPUNIT_TEST(testGetCount);
+
     CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -63,6 +69,7 @@ private:
 ScChartsObj::ScChartsObj()
     : CalcUnoApiTest("/sc/qa/extras/testdocuments")
     , XElementAccess(cppu::UnoType<table::XTableChart>::get())
+    , XIndexAccess(1)
 {
 }
 


More information about the Libreoffice-commits mailing list