[Libreoffice-commits] core.git: dbaccess/source

[Libreoffice Gerrit user]

 dbaccess/source/ui/dlg/advancedsettings.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 04eec3200f5cc7e6db1e14cebcf629b74921bc38
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sun Mar 10 06:48:00 2019 +0100
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sun Mar 10 07:39:08 2019 +0100

    Initializing boost::optional with a value then resetting is odd
    
    Change-Id: Iebf28bebb009a46872dd6d4662a7434e3c66b7dc
    Reviewed-on: https://gerrit.libreoffice.org/68993
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/dbaccess/source/ui/dlg/advancedsettings.cxx b/dbaccess/source/ui/dlg/advancedsettings.cxx
index 0dbf6ab32afe..2837361ff32a 100644
--- a/dbaccess/source/ui/dlg/advancedsettings.cxx
+++ b/dbaccess/source/ui/dlg/advancedsettings.cxx
@@ -178,8 +178,7 @@ namespace dbaui
             if (!booleanSetting.xControl)
                 continue;
 
-            ::boost::optional< bool > aValue(false);
-            aValue.reset();
+            boost::optional<bool> aValue;
 
             const SfxPoolItem* pItem = _rSet.GetItem<SfxPoolItem>(booleanSetting.nItemId);
             if (const SfxBoolItem *pBoolItem = dynamic_cast<const SfxBoolItem*>( pItem) )