[Libreoffice-commits] core.git: svgio/CppunitTest_svgio_read.mk

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Mar 12 13:47:12 UTC 2019


 svgio/CppunitTest_svgio_read.mk |    4 ----
 1 file changed, 4 deletions(-)

New commits:
commit b636d57e8f6d98887b1cd11449dd9580beb7b604
Author:     Michael Stahl <Michael.Stahl at cib.de>
AuthorDate: Tue Mar 12 12:24:46 2019 +0100
Commit:     Michael Stahl <Michael.Stahl at cib.de>
CommitDate: Tue Mar 12 14:46:48 2019 +0100

    svgio: don't use_library_objects in CppunitTest_svgio_read
    
    ==26032==ERROR: AddressSanitizer: odr-violation (0x7f3b41f544a0):
      [1] size=96 'vtable for svgio::svgreader::SvgCharacterNode' master/svgio/source/svgreader/svgcharacternode.cxx
      [2] size=96 'vtable for svgio::svgreader::SvgCharacterNode' master/svgio/source/svgreader/svgcharacternode.cxx
    These globals were registered at these points:
      [1]:
        #0 0x43a090 in __asan_register_globals.part.13 (workdir/LinkTarget/Executable/cppunittester+0x43a090)
        #1 0x7f3b31e6e86d in asan.module_ctor (instdir/program/libsvgiolo.so+0x6186d)
    
      [2]:
        #0 0x43a090 in __asan_register_globals.part.13 (workdir/LinkTarget/Executable/cppunittester+0x43a090)
        #1 0x7f3b41da5bad in asan.module_ctor (workdir/LinkTarget/CppunitTest/libtest_svgio_read.so+0x82bad)
    
    Change-Id: Id2b32936d603ac2ed7df12d7e6f3ade094621578
    Reviewed-on: https://gerrit.libreoffice.org/69092
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>
    Tested-by: Jenkins

diff --git a/svgio/CppunitTest_svgio_read.mk b/svgio/CppunitTest_svgio_read.mk
index 20ebc0eee176..518243c939c0 100644
--- a/svgio/CppunitTest_svgio_read.mk
+++ b/svgio/CppunitTest_svgio_read.mk
@@ -23,10 +23,6 @@ $(eval $(call gb_CppunitTest_use_externals,svgio_read,\
     libxml2 \
 ))
 
-$(eval $(call gb_CppunitTest_use_library_objects,svgio_read,\
-    svgio \
-))
-
 $(eval $(call gb_CppunitTest_use_libraries,svgio_read, \
 	basegfx \
 	comphelper \


More information about the Libreoffice-commits mailing list