[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - chart2/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Mar 14 08:38:09 UTC 2019


 chart2/source/controller/dialogs/res_ErrorBar.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 6ca6ca12f96524c9f68dad94b2857d98ca12134a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Mar 13 16:24:07 2019 +0000
Commit:     Xisco Faulí <xiscofauli at libreoffice.org>
CommitDate: Thu Mar 14 09:37:47 2019 +0100

    Resolves: tdf#123694 we need the controller, not the tabpage parent
    
    Change-Id: Ib390abaec648a1e06fcc35f83cb170fc654cf021
    Reviewed-on: https://gerrit.libreoffice.org/69204
    Tested-by: Jenkins
    Reviewed-by: Xisco Faulí <xiscofauli at libreoffice.org>

diff --git a/chart2/source/controller/dialogs/res_ErrorBar.cxx b/chart2/source/controller/dialogs/res_ErrorBar.cxx
index c1ea174c43d3..5a2d750a632c 100644
--- a/chart2/source/controller/dialogs/res_ErrorBar.cxx
+++ b/chart2/source/controller/dialogs/res_ErrorBar.cxx
@@ -41,8 +41,9 @@ namespace
 {
 void lcl_enableRangeChoosing(bool bEnable, TabPageParent pParent)
 {
-    if (weld::Window* pWeldDialog = dynamic_cast<weld::Window*>(pParent.pPage))
+    if (weld::DialogController* pController = pParent.pController)
     {
+        weld::Window* pWeldDialog = pController->getDialog();
         pWeldDialog->set_modal(!bEnable);
         pWeldDialog->show(!bEnable);
     }


More information about the Libreoffice-commits mailing list