[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Mar 19 12:47:22 UTC 2019


 sc/source/core/tool/parclass.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e0baddc00570692e09834f165b4e1913575fc338
Author:     Eike Rathke <erack at redhat.com>
AuthorDate: Wed Feb 27 13:57:25 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Mar 19 13:46:58 2019 +0100

    Related: tdf#122301 TRANSPOSE() with ForceArrayReturn on caller
    
     This is a combination of 2 commits.
    
    Related: tdf#122301 TRANSPOSE() with ForceArrayReturn on caller
    
    As stated in
    
    ECMA-376-1:2016 OOXML 18.17.7.327 TRANSPOSE
    "The formula containing the call to TRANSPOSE shall be an array
    formula [...]"
    
    Similar to
    
        commit d0ded163d8e93dc5b10d7a7c9bdab1d0a6a50bac
        CommitDate: Wed Jan 16 11:17:14 2019 +0100
    
            Related: tdf#122301 FREQUENCY() with ForceArrayReturn on caller
    
    Reviewed-on: https://gerrit.libreoffice.org/68436
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Jenkins
    (cherry picked from commit 5413c8871dec08eff19f514f5f391b946a45c86c)
    
    ocMatTrans with ForceArray
    
    Now that OOXML reveiled that the formula expression containing a
    TRANSPOSE() call shall be in array mode, the old comment about
    Excel not forcing array on the argument (in BIFF token class)
    makes sense. Use ForceArray and remove now moot comment.
    
    Reviewed-on: https://gerrit.libreoffice.org/68509
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Jenkins
    (cherry picked from commit d2be2f1aebb883c74460d049a5e2b821ecd5947c)
    
    Change-Id: I617bfcc0b8ecb244df3441ab885ec926efd77e3f
    ab2bced788de3429aab2bb7c3ca7f24d5dbf0340
    Reviewed-on: https://gerrit.libreoffice.org/69275
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/core/tool/parclass.cxx b/sc/source/core/tool/parclass.cxx
index ce6c9094cc71..a5c55d1a49c0 100644
--- a/sc/source/core/tool/parclass.cxx
+++ b/sc/source/core/tool/parclass.cxx
@@ -173,7 +173,7 @@ const ScParameterClassification::RawData ScParameterClassification::pRawData[] =
     { ocMatDet,          {{ ForceArray                                           }, 0, Value }},
     { ocMatInv,          {{ ForceArray                                           }, 0, Value }},
     { ocMatMult,         {{ ForceArray, ForceArray                               }, 0, Value }},
-    { ocMatTrans,        {{ Array                                                }, 0, Value }}, // strange, but Xcl doesn't force MatTrans array
+    { ocMatTrans,        {{ ForceArray                                           }, 0, ForceArrayReturn }},
     { ocMatValue,        {{ Reference, Value, Value                              }, 0, Value }},
     { ocMatch,           {{ Value, ReferenceOrForceArray, Value                  }, 0, Value }},
     { ocMax,             {{ ReferenceOrRefArray                                  }, 1, Value }},


More information about the Libreoffice-commits mailing list