[Libreoffice-commits] core.git: compilerplugins/clang

[Stephan Bergmann (via logerrit)]

 compilerplugins/clang/typedefparam.cxx |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit b54f46a848bf54b2bcb9e1dfbb3b3685e67adfd8
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Mar 27 08:49:47 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Mar 27 10:59:35 2019 +0100

    Adpat loplugin:typedefparam to AttributedType
    
    ...as seen by clang-cl when there are function parameters of function pointer
    type involving SAL_CALL
    
    Change-Id: Ie35f00d4e15ca777b14dd5968cdbd97e43bca1a1
    Reviewed-on: https://gerrit.libreoffice.org/69789
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/compilerplugins/clang/typedefparam.cxx b/compilerplugins/clang/typedefparam.cxx
index fe6ebba78f0f..d5b3a76103c9 100644
--- a/compilerplugins/clang/typedefparam.cxx
+++ b/compilerplugins/clang/typedefparam.cxx
@@ -273,6 +273,13 @@ static bool areTypesEqual(QualType lhs, QualType rhs)
             return false;
         return areTypesEqual(lhsDecayed->getAdjustedType(), rhsDecayed->getAdjustedType());
     }
+    if (auto lhsAttr = dyn_cast<AttributedType>(lhsType))
+    {
+        auto rhsAttr = dyn_cast<AttributedType>(rhsType);
+        if (!rhsAttr)
+            return false;
+        return areTypesEqual(lhsAttr->getModifiedType(), rhsAttr->getModifiedType());
+    }
     return lhsType == rhsType;
 }