[Libreoffice-commits] dev-tools.git: esc-reporting/esc-analyze.py

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu May 2 08:15:35 UTC 2019


 esc-reporting/esc-analyze.py |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5a6566e50f9c0aa143a88c0d593a47ab767d0849
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Thu May 2 10:14:35 2019 +0200
Commit:     Xisco Fauli <xiscofauli at libreoffice.org>
CommitDate: Thu May 2 10:14:35 2019 +0200

    ESC: fix 'rowTmp' referenced before assignment

diff --git a/esc-reporting/esc-analyze.py b/esc-reporting/esc-analyze.py
index 927f513..48533b8 100755
--- a/esc-reporting/esc-analyze.py
+++ b/esc-reporting/esc-analyze.py
@@ -720,12 +720,12 @@ def analyze_reports():
         if cntReview == 0 and not statList['people'][ownerEmail]['isCommitter']:
             tmpListToReview.append({'id': entry['id'], 'fullid': entry['fullid'], 'patchset': patchset})
 
-    if gerritData['patch'][rowTmp['id']]['project'] == 'online':
+    for rowTmp in tmpListToReview:
+      if gerritData['patch'][rowTmp['id']]['project'] == 'online':
         defaultEmail = util_check_mail('', cfg['automate']['gerritReviewOnlineUserEmail'])
-    else:
+      else:
         defaultEmail = util_check_mail('', cfg['automate']['gerritReviewUserEmail'])
 
-    for rowTmp in tmpListToReview:
       reviewEmail = defaultEmail
       txt = gerritData['patch'][rowTmp['id']]['subject']
       if txt.startswith('tdf#'):


More information about the Libreoffice-commits mailing list