[Libreoffice-commits] core.git: compilerplugins/clang

[Noel Grandin (via logerrit)]

 compilerplugins/clang/badstatics.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 0e2cda8906f501bb8a90f1f44335c7ff2a5edb4f
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue May 7 15:53:16 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue May 7 15:54:22 2019 +0200

    loplugin:badstatics
    
    add some more false+
    
    which interestingly enough, only started showing up when I switched on
       --enable-pch=system
    
    Change-Id: I2d52644dc3665db19b28772eb818c138e063dae4

diff --git a/compilerplugins/clang/badstatics.cxx b/compilerplugins/clang/badstatics.cxx
index 814a120de8ef..87c31acd996e 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -209,6 +209,8 @@ public:
                 || name == "gStaticManager" // vcl/source/graphic/Manager.cxx - stores non-owning pointers
                 || name == "aThreadedInterpreterPool"    // ScInterpreterContext(Pool), not owning
                 || name == "aNonThreadedInterpreterPool" // ScInterpreterContext(Pool), not owning
+                || name == "lcl_parserContext" // getParserContext(), the chain from this to a VclPtr is not owning
+                || name == "aReaderWriter" // /home/noel/libo/sw/source/filter/basflt/fltini.cxx, non-owning
                ) // these variables appear unproblematic
             {
                 return true;