[Libreoffice-commits] core.git: Branch 'distro/cib/libreoffice-5-2' - sax/source

David Ostrovsky (via logerrit) logerrit at kemper.freedesktop.org
Wed May 8 10:00:50 UTC 2019


 sax/source/fastparser/fastparser.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7814e7a912aacd4022a5903d8cbf2955a12af5f1
Author:     David Ostrovsky <david at ostrovsky.org>
AuthorDate: Fri Feb 17 22:21:08 2017 +0000
Commit:     Michael Stahl <Michael.Stahl at cib.de>
CommitDate: Wed May 8 11:59:51 2019 +0200

    MSVC 14.0: Fix warning C4702: unreachable code
    
    Change-Id: I38db92984daae40981f2d3f60c4efa38684d5328
    Reviewed-on: https://gerrit.libreoffice.org/34382
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: David Ostrovsky <david at ostrovsky.org>
    (cherry picked from commit 996960f5a25c0833942c03b94356d2137c4d7557)

diff --git a/sax/source/fastparser/fastparser.cxx b/sax/source/fastparser/fastparser.cxx
index 88a193eb3732..7494d71aa83e 100644
--- a/sax/source/fastparser/fastparser.cxx
+++ b/sax/source/fastparser/fastparser.cxx
@@ -927,7 +927,7 @@ bool FastSaxParserImpl::consume(EventList *pEventList)
                 return false;
             case EXCEPTION:
                 rEntity.throwException( mxDocumentLocator, false );
-                return false;
+                SAL_FALLTHROUGH; // avoid unreachable code warning with some comilers
             default:
                 assert(false);
                 return false;


More information about the Libreoffice-commits mailing list