[Libreoffice-commits] core.git: solenv/sanitizers svx/uiconfig

Samuel Thibault (via logerrit) logerrit at kemper.freedesktop.org
Fri May 10 20:20:13 UTC 2019


 solenv/sanitizers/ui/svx.false          |    2 --
 svx/uiconfig/ui/classificationdialog.ui |    8 +++++++-
 2 files changed, 7 insertions(+), 3 deletions(-)

New commits:
commit d422a9d0cb914260192fbc68305db088af022204
Author:     Samuel Thibault <samuel.thibault at ens-lyon.org>
AuthorDate: Thu May 9 14:39:27 2019 +0200
Commit:     Katarina Behrens <Katarina.Behrens at cib.de>
CommitDate: Fri May 10 22:19:19 2019 +0200

    tdf#119931 Fix a11y warnings in classificationdialog.ui
    
    Make "Content" a label for the drawing area
    
    Change-Id: I2238ea42d33564d848376e3c33b9d9a46af094ae
    Reviewed-on: https://gerrit.libreoffice.org/72045
    Tested-by: Jenkins
    Reviewed-by: Katarina Behrens <Katarina.Behrens at cib.de>

diff --git a/solenv/sanitizers/ui/svx.false b/solenv/sanitizers/ui/svx.false
index e30560c59517..16af737bb931 100644
--- a/solenv/sanitizers/ui/svx.false
+++ b/solenv/sanitizers/ui/svx.false
@@ -1,6 +1,4 @@
 svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn3'] no-labelled-by
-svx/uiconfig/ui/classificationdialog.ui:GtkDialog[@id='AdvancedDocumentClassificationDialog']/GtkBox[@id='dialog-vbox1']/GtkGrid/GtkGrid/GtkLabel orphan-label
-svx/uiconfig/ui/classificationdialog.ui://GtkDrawingArea[@id='classificationEditWindow'] no-labelled-by
 svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn6'] no-labelled-by
 svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn4'] no-labelled-by
 
diff --git a/svx/uiconfig/ui/classificationdialog.ui b/svx/uiconfig/ui/classificationdialog.ui
index e4c9c0299ae6..29690610e250 100644
--- a/svx/uiconfig/ui/classificationdialog.ui
+++ b/svx/uiconfig/ui/classificationdialog.ui
@@ -274,12 +274,15 @@
                 <property name="vexpand">True</property>
                 <property name="row_spacing">3</property>
                 <child>
-                  <object class="GtkLabel">
+                  <object class="GtkLabel" id="classificationContentLabel">
                     <property name="visible">True</property>
                     <property name="can_focus">False</property>
                     <property name="label" translatable="yes" context="classificationdialog|label-Content">Content</property>
                     <property name="xalign">0</property>
                     <property name="yalign">0</property>
+                    <accessibility>
+                      <relation type="label-for" target="classificationEditWindow"/>
+                    </accessibility>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
@@ -341,6 +344,9 @@
                             <property name="can_focus">True</property>
                             <property name="events">GDK_BUTTON_MOTION_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK | GDK_KEY_PRESS_MASK | GDK_KEY_RELEASE_MASK | GDK_FOCUS_CHANGE_MASK | GDK_STRUCTURE_MASK</property>
                             <property name="hexpand">True</property>
+                            <accessibility>
+                              <relation type="labelled-by" target="classificationContentLabel"/>
+                            </accessibility>
                           </object>
                         </child>
                       </object>


More information about the Libreoffice-commits mailing list