[Libreoffice-commits] core.git: bin/gla11y solenv/sanitizers

Samuel Thibault (via logerrit) logerrit at kemper.freedesktop.org
Mon May 13 14:07:39 UTC 2019


 bin/gla11y                               |    4 ++--
 solenv/sanitizers/ui/cui.suppr           |    5 -----
 solenv/sanitizers/ui/filter.suppr        |    2 --
 solenv/sanitizers/ui/modules/scalc.suppr |    2 --
 solenv/sanitizers/ui/sfx.suppr           |    2 --
 solenv/sanitizers/ui/svx.false           |    4 ----
 solenv/sanitizers/ui/uui.suppr           |    1 -
 solenv/sanitizers/ui/xmlsec.suppr        |    1 -
 8 files changed, 2 insertions(+), 19 deletions(-)

New commits:
commit 7073d17fe5565589bdd3e6438cfa8b4d932acf8b
Author:     Samuel Thibault <samuel.thibault at ens-lyon.org>
AuthorDate: Fri May 10 23:19:08 2019 +0200
Commit:     Katarina Behrens <Katarina.Behrens at cib.de>
CommitDate: Mon May 13 16:06:50 2019 +0200

    gla11y: whitelist GtkTreeViewColumn as not needing labelling
    
    and remove corresponding suppressions.
    
    Change-Id: I0dd88082ee0af4c5ee82590e894305fa53574c6b
    Reviewed-on: https://gerrit.libreoffice.org/72133
    Tested-by: Jenkins
    Reviewed-by: Katarina Behrens <Katarina.Behrens at cib.de>

diff --git a/bin/gla11y b/bin/gla11y
index 3fed400de699..f93121484648 100755
--- a/bin/gla11y
+++ b/bin/gla11y
@@ -10,7 +10,7 @@
 # This file incorporates work covered by the following license notice:
 #
 #   Copyright (c) 2018 Martin Pieuchot
-#   Copyright (c) 2018 Samuel Thibault <sthibault at hypra.fr>
+#   Copyright (c) 2018-2019 Samuel Thibault <sthibault at hypra.fr>
 #
 #   Permission to use, copy, modify, and distribute this software for any
 #   purpose with or without fee is hereby granted, provided that the above
@@ -145,6 +145,7 @@ widgets_ignored = widgets_toplevel + [
     'GtkTreeSelection',
 
     'GtkListBoxRow',
+    'GtkTreeViewColumn',
 
     # Useless to label
     'GtkScrollbar',
@@ -216,7 +217,6 @@ widgets_labels = [
 
 # GtkCellView
 # GtkTreeView
-# GtkTreeViewColumn
 # GtkTextView
 # GtkIconView
 
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index 1fce68321a1c..4279ed553003 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -256,7 +256,6 @@ cui/uiconfig/ui/insertfloatingframe.ui://GtkLabel[@id='heightlabel'] orphan-labe
 cui/uiconfig/ui/insertfloatingframe.ui://GtkSpinButton[@id='width'] no-labelled-by
 cui/uiconfig/ui/insertfloatingframe.ui://GtkSpinButton[@id='height'] no-labelled-by
 cui/uiconfig/ui/insertoleobject.ui://GtkEntry[@id='urled'] no-labelled-by
-cui/uiconfig/ui/javastartparametersdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
 cui/uiconfig/ui/javastartparametersdialog.ui://GtkLabel[@id='label6'] orphan-label
 cui/uiconfig/ui/lineendstabpage.ui://GtkLabel[@id='FT_LINE_END_STYLE'] orphan-label
 cui/uiconfig/ui/lineendstabpage.ui://GtkComboBox[@id='LB_LINEENDS'] no-labelled-by
@@ -281,7 +280,6 @@ cui/uiconfig/ui/menuassignpage.ui://GtkLabel[@id='rightfunctionlabel'] orphan-la
 cui/uiconfig/ui/menuassignpage.ui://GtkLabel[@id='customizelabel'] orphan-label
 cui/uiconfig/ui/movemenu.ui://GtkLabel[@id='label1'] orphan-label
 cui/uiconfig/ui/movemenu.ui://GtkTreeView[@id='menulist'] no-labelled-by
-cui/uiconfig/ui/movemenu.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
 cui/uiconfig/ui/multipathdialog.ui://svtlo-SvSimpleTableContainer[@id='paths'] no-labelled-by
 cui/uiconfig/ui/multipathdialog.ui://GtkLabel[@id='pathlist'] orphan-label
 cui/uiconfig/ui/newlibdialog.ui://GtkEntry[@id='entry'] duplicate-mnemonic
@@ -464,10 +462,7 @@ cui/uiconfig/ui/tsaurldialog.ui://GtkLabel[@id='enteraurl'] orphan-label
 cui/uiconfig/ui/twolinespage.ui://GtkLabel[@id='label29'] orphan-label
 cui/uiconfig/ui/twolinespage.ui://GtkLabel[@id='label30'] orphan-label
 cui/uiconfig/ui/twolinespage.ui://GtkTreeView[@id='startbracket'] no-labelled-by
-cui/uiconfig/ui/twolinespage.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
 cui/uiconfig/ui/twolinespage.ui://GtkTreeView[@id='endbracket'] no-labelled-by
-cui/uiconfig/ui/twolinespage.ui://GtkTreeViewColumn[@id='treeviewcolumn2'] no-labelled-by
 cui/uiconfig/ui/wordcompletionpage.ui://GtkTreeView[@id='entries'] no-labelled-by
 cui/uiconfig/ui/wordcompletionpage.ui://GtkSpinButton[@id='maxentries'] duplicate-mnemonic
 cui/uiconfig/ui/wordcompletionpage.ui://GtkSpinButton[@id='minwordlen'] no-labelled-by
-cui/uiconfig/ui/wordcompletionpage.ui://GtkTreeViewColumn[@id='treeviewcolumn2'] no-labelled-by
diff --git a/solenv/sanitizers/ui/filter.suppr b/solenv/sanitizers/ui/filter.suppr
index de80972e87e5..c0199933cfb6 100644
--- a/solenv/sanitizers/ui/filter.suppr
+++ b/solenv/sanitizers/ui/filter.suppr
@@ -23,5 +23,3 @@ filter/uiconfig/ui/testxmlfilter.ui://GtkLabel[@id='importxslttemplate'] orphan-
 filter/uiconfig/ui/testxmlfilter.ui://GtkLabel[@id='recentfilename'] orphan-label
 filter/uiconfig/ui/warnpdfdialog.ui://GtkLabel[@id='message'] orphan-label
 filter/uiconfig/ui/warnpdfdialog.ui://GtkTreeView[@id='errors'] no-labelled-by
-filter/uiconfig/ui/warnpdfdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
-filter/uiconfig/ui/warnpdfdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn2'] no-labelled-by
diff --git a/solenv/sanitizers/ui/modules/scalc.suppr b/solenv/sanitizers/ui/modules/scalc.suppr
index 348404d08b1b..2e695948d53d 100644
--- a/solenv/sanitizers/ui/modules/scalc.suppr
+++ b/solenv/sanitizers/ui/modules/scalc.suppr
@@ -71,7 +71,6 @@ sc/uiconfig/scalc/ui/deletecolumnentry.ui:GtkGrid[@id='grid']/GtkBox/GtkGrid[@id
 sc/uiconfig/scalc/ui/deletecolumnentry.ui://GtkEntry[@id='ed_columns'] no-labelled-by
 sc/uiconfig/scalc/ui/doubledialog.ui://GtkEntry[@id='value'] no-labelled-by
 sc/uiconfig/scalc/ui/externaldata.ui://GtkTreeView[@id='ranges'] no-labelled-by
-sc/uiconfig/scalc/ui/externaldata.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
 sc/uiconfig/scalc/ui/externaldata.ui://GtkLabel[@id='secondsft'] orphan-label
 sc/uiconfig/scalc/ui/fourieranalysisdialog.ui://GtkLabel[@id='error-message'] orphan-label
 sc/uiconfig/scalc/ui/functionpanel.ui://GtkComboBoxText[@id='category'] no-labelled-by
@@ -94,7 +93,6 @@ sc/uiconfig/scalc/ui/imoptdialog.ui://GtkLabel[@id='charsetft'] orphan-label
 sc/uiconfig/scalc/ui/imoptdialog.ui://svxlo-SvxTextEncodingBox[@id='charsetdropdown'] no-labelled-by
 sc/uiconfig/scalc/ui/imoptdialog.ui://svxlo-SvxTextEncodingBox[@id='charsetlist:border'] no-labelled-by
 sc/uiconfig/scalc/ui/insertsheet.ui://GtkLabel[@id='path'] orphan-label
-sc/uiconfig/scalc/ui/insertsheet.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
 sc/uiconfig/scalc/ui/integerdialog.ui://GtkSpinButton[@id='value'] no-labelled-by
 sc/uiconfig/scalc/ui/namerangesdialog.ui://GtkEntry[@id='edassign'] no-labelled-by
 sc/uiconfig/scalc/ui/notebookbar_groups.ui://GtkLabel[@id='filegrouplabel'] orphan-label
diff --git a/solenv/sanitizers/ui/sfx.suppr b/solenv/sanitizers/ui/sfx.suppr
index 0ce4dae64801..30a4bd775f29 100644
--- a/solenv/sanitizers/ui/sfx.suppr
+++ b/solenv/sanitizers/ui/sfx.suppr
@@ -70,8 +70,6 @@ sfx2/uiconfig/ui/startcenter.ui://GtkLabel[@id='create_label'] orphan-label
 sfx2/uiconfig/ui/startcenter.ui://GtkImage[@id='motif'] no-labelled-by
 sfx2/uiconfig/ui/startcenter.ui://GtkLabel[@id='althelplabel'] orphan-label
 sfx2/uiconfig/ui/templatedlg.ui://GtkLabel[@id='label1'] orphan-label
-sfx2/uiconfig/ui/saveastemplatedlg.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
-sfx2/uiconfig/ui/templatecategorydlg.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
 sfx2/uiconfig/ui/versionsofdialog.ui://GtkLabel[@id='datetime'] orphan-label
 sfx2/uiconfig/ui/versionsofdialog.ui://GtkLabel[@id='savedby'] orphan-label
 sfx2/uiconfig/ui/versionsofdialog.ui://GtkLabel[@id='comments'] orphan-label
diff --git a/solenv/sanitizers/ui/svx.false b/solenv/sanitizers/ui/svx.false
index 16af737bb931..e69de29bb2d1 100644
--- a/solenv/sanitizers/ui/svx.false
+++ b/solenv/sanitizers/ui/svx.false
@@ -1,4 +0,0 @@
-svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn3'] no-labelled-by
-svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn6'] no-labelled-by
-svx/uiconfig/ui/classificationdialog.ui://GtkTreeViewColumn[@id='treeviewcolumn4'] no-labelled-by
-
diff --git a/solenv/sanitizers/ui/uui.suppr b/solenv/sanitizers/ui/uui.suppr
index ba36e3b88c30..2f94c0ba23f6 100644
--- a/solenv/sanitizers/ui/uui.suppr
+++ b/solenv/sanitizers/ui/uui.suppr
@@ -1,6 +1,5 @@
 uui/uiconfig/ui/filterselect.ui://GtkLabel[@id='url'] orphan-label
 uui/uiconfig/ui/filterselect.ui://GtkTreeView[@id='filters'] no-labelled-by
-uui/uiconfig/ui/filterselect.ui://GtkTreeViewColumn[@id='treeviewcolumn1'] no-labelled-by
 uui/uiconfig/ui/authfallback.ui://GtkLabel[@id='google_prefix_label'] orphan-label
 uui/uiconfig/ui/authfallback.ui://GtkEntry[@id='google_code'] no-labelled-by
 uui/uiconfig/ui/authfallback.ui://GtkLabel[@id='label1'] orphan-label
diff --git a/solenv/sanitizers/ui/xmlsec.suppr b/solenv/sanitizers/ui/xmlsec.suppr
index d56969de2044..e5722d379c73 100644
--- a/solenv/sanitizers/ui/xmlsec.suppr
+++ b/solenv/sanitizers/ui/xmlsec.suppr
@@ -2,7 +2,6 @@ xmlsecurity/uiconfig/ui/certpage.ui://GtkLabel[@id='certok'] orphan-label
 xmlsecurity/uiconfig/ui/certpage.ui://GtkLabel[@id='certnotok'] orphan-label
 xmlsecurity/uiconfig/ui/certpage.ui://GtkImage[@id='imgok'] no-labelled-by
 xmlsecurity/uiconfig/ui/certpage.ui://GtkImage[@id='imgnotok'] no-labelled-by
-xmlsecurity/uiconfig/ui/certpage.ui://GtkTreeViewColumn[@id='treeviewcolumn3'] no-labelled-by
 xmlsecurity/uiconfig/ui/certgeneral.ui://GtkImage[@id='certimage'] no-labelled-by
 xmlsecurity/uiconfig/ui/certgeneral.ui://GtkLabel[@id='label1'] orphan-label
 xmlsecurity/uiconfig/ui/certgeneral.ui://GtkLabel[@id='hintnotrust'] orphan-label


More information about the Libreoffice-commits mailing list