[Libreoffice-commits] core.git: sc/source

[Eike Rathke (via logerrit)]

 sc/source/ui/Accessibility/AccessibleDocument.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 459a611c9933c3b94c421b3f6036cd2e926279aa
Author:     Eike Rathke <erack at redhat.com>
AuthorDate: Mon May 20 16:25:26 2019 +0200
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Mon May 20 20:20:26 2019 +0200

    Fix a11y crash with drag&drop shape anchored to page
    
    Dereferencing an empty boost::optional is dereferencing a this
    nullptr, simply copy it instead.
    
    Regression from
    
    commit 0a18c1dc437642dd7ec3631367a9aab9982c55de
    CommitDate: Fri Dec 21 18:52:31 2018 +0100
    
        pass ScAddress around using boost::optional
    
    Change-Id: Id676b2d84d324b989259688069d4860de5559ebc
    Reviewed-on: https://gerrit.libreoffice.org/72605
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/ui/Accessibility/AccessibleDocument.cxx b/sc/source/ui/Accessibility/AccessibleDocument.cxx
index 9ad7aa3a98f0..565de0e65fec 100644
--- a/sc/source/ui/Accessibility/AccessibleDocument.cxx
+++ b/sc/source/ui/Accessibility/AccessibleDocument.cxx
@@ -1140,7 +1140,7 @@ void ScChildrenShapes::SetAnchor(const uno::Reference<drawing::XShape>& xShape,
         if ((xAddress && pData->xRelationCell && (*xAddress != *(pData->xRelationCell))) ||
             (!xAddress && pData->xRelationCell) || (xAddress && !pData->xRelationCell))
         {
-            pData->xRelationCell = *xAddress;
+            pData->xRelationCell = xAddress;
             if (pData->pAccShape.is())
                 pData->pAccShape->SetRelationSet(GetRelationSet(pData));
         }