[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/ui/dbgui/filtdlg.cxx |   14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

New commits:
commit 698500c0ab4125900ee3dd3c78ce232d9485a17c
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue May 21 09:53:36 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue May 21 13:12:34 2019 +0200

    freeze/thaw around big inserts
    
    Change-Id: Idde70a3566f694c6dbfbe8faad923dfb088f52f7
    Reviewed-on: https://gerrit.libreoffice.org/72669
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/dbgui/filtdlg.cxx b/sc/source/ui/dbgui/filtdlg.cxx
index 2a8126987877..c58c1f9d814d 100644
--- a/sc/source/ui/dbgui/filtdlg.cxx
+++ b/sc/source/ui/dbgui/filtdlg.cxx
@@ -384,6 +384,11 @@ void ScFilterDlg::SetActive()
 
 void ScFilterDlg::FillFieldLists()
 {
+    m_xLbField1->freeze();
+    m_xLbField2->freeze();
+    m_xLbField3->freeze();
+    m_xLbField4->freeze();
+
     m_xLbField1->clear();
     m_xLbField2->clear();
     m_xLbField3->clear();
@@ -415,6 +420,11 @@ void ScFilterDlg::FillFieldLists()
             m_xLbField4->append_text( aFieldName );
         }
     }
+
+    m_xLbField4->thaw();
+    m_xLbField3->thaw();
+    m_xLbField2->thaw();
+    m_xLbField1->thaw();
 }
 
 void ScFilterDlg::UpdateValueList( size_t nList )
@@ -491,12 +501,14 @@ void ScFilterDlg::UpdateValueList( size_t nList )
             else
                 pList = m_EntryLists[nColumn].get();
 
-            OSL_ASSERT(pList);
+            assert(pList);
 
+            pValList->freeze();
             for (const auto& rEntry : pList->maFilterEntries)
             {
                 pValList->append_text(rEntry.GetString());
             }
+            pValList->thaw();
         }
         pValList->set_entry_text(aCurValue);
     }