[Libreoffice-commits] dev-tools.git: gerrit/auto-submit

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed May 22 07:30:48 UTC 2019


 gerrit/auto-submit/git-breview |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 75a5ff65f676c8d6f4b60d7f99529ff0fb8b367e
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Wed May 22 09:29:17 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Wed May 22 09:30:27 2019 +0200

    git-breview: dont auto-rebase, handle custom port
    
    core.git .gitreview recently removed the logerrit alias, so make sure we
    ssh to the gerrit java sshd, not to the underlying host.
    
    Also disable auto-rebase, that would mean once a change is pushed to
    gerrit, it's not easy to add follow-up commits without modifying already
    pushed commits.
    
    Change-Id: Iefedf2e9b25311b323ee92399f5315f36d1f13fc

diff --git a/gerrit/auto-submit/git-breview b/gerrit/auto-submit/git-breview
index 00d815c..967584a 100755
--- a/gerrit/auto-submit/git-breview
+++ b/gerrit/auto-submit/git-breview
@@ -5,10 +5,11 @@
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 #
 
-if git-review; then
+if git-review -R; then
     rev=$(git rev-parse HEAD)
     host=$(git config -f .gitreview gerrit.host)
-    ssh $host gerrit review --code-review=2 $rev
+    port=$(git config -f .gitreview gerrit.port)
+    ssh -p $port $host gerrit review --code-review=2 $rev
 fi
 
 # vim:set shiftwidth=4 softtabstop=4 expandtab:


More information about the Libreoffice-commits mailing list