[Libreoffice-commits] core.git: forms/qa

[Stephan Bergmann (via logerrit)]

 forms/qa/unoapi/forms_2.sce |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8ae150d80cc28227c9f6527cc591b081a16d05fd
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu May 23 16:53:08 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu May 23 21:43:27 2019 +0200

    Re-enable JunitTest_forms_unoapi_2 forms.ODateModel
    
    f9905401d8cf2d73576231ebd84cfa5f4f73bcac "tdf#125170 Deliver mouse events also
    when clicking into document content" had disabled it because its
    gerrit_linux_clang_dbgutil Jenkins build had failed it successively like
    
    > LOG> Execute: Date
    > LOG> try to set:
    > LOG> old = com.sun.star.util.Date at 271053e1{1, 1, 1800}
    > LOG> new = com.sun.star.util.Date at 589838eb{2, 0, 0}
    > warn:tools.datetime:303:1063:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar.
    > LOG> Property Date is void
    > LOG> Value for 'Date' hasn't changed as expected
    > LOG> result = com.sun.star.util.Date at 42dafa95{1, 1, 1800}
    > Method Date finished with state FAILED
    > LOG> Date: COMPLETED.FAILED
    
    (<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/32715/>).
    
    But it is unclear how that commit would have affected that test, and at least a
    recent local build of mine succeeds with
    
    > LOG> Execute: Date
    > LOG> try to set:
    > LOG> old = com.sun.star.util.Date at dc24521{0, 0, 0}
    > LOG> new = com.sun.star.util.Date at 10bdf5e5{1, 0, 0}
    > warn:tools.datetime:10048:10220:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar.
    > LOG> Property Date is void
    > LOG> Property 'Date' OK
    > LOG> result = com.sun.star.util.Date at 6e1ec318{1, 0, 0}
    > Method Date finished with state OK
    > LOG> Date: COMPLETED.OK
    
    (note the difference of initial date, {1, 1, 1800} vs. {0, 0, 0}, whether or not
    that is relevant), so lets re-enable the test for now and see...
    
    Change-Id: I53b462954650e32de85c795c94f9b8038dc01918
    Reviewed-on: https://gerrit.libreoffice.org/72863
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/forms/qa/unoapi/forms_2.sce b/forms/qa/unoapi/forms_2.sce
index c12d87f9977a..30f4b2401875 100644
--- a/forms/qa/unoapi/forms_2.sce
+++ b/forms/qa/unoapi/forms_2.sce
@@ -15,7 +15,7 @@
 #   except in compliance with the License. You may obtain a copy of
 #   the License at http://www.apache.org/licenses/LICENSE-2.0 .
 #
-# Flaky since tdf#125170 -o forms.ODateModel
+-o forms.ODateModel
 -o forms.OEditControl
 -o forms.OEditModel
 #i109939 -o forms.OFileControlModel