[Libreoffice-commits] core.git: sc/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Tue May 28 15:06:22 UTC 2019


 sc/source/ui/sidebar/NumberFormatControl.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b9139c1a41acca28e48efdbc664d384734f81ce9
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue May 28 10:56:46 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue May 28 17:05:29 2019 +0200

    ScNumberFormatControl uses an SfxUInt16Item
    
    ...not an SfxInt16Item.  Probably a typo introduced when adding the class with
    bf3f3a6bfb08c2d1a2c95f1c1cf62117e0002235 "notebookbar: working number format
    listbox".  (Found with -fsanitize=vptr when switching Calc to "View - User
    Interface - Tabbed Compact".)
    
    Change-Id: I6142b20750872037767e1857edeae83b1b2fa849
    Reviewed-on: https://gerrit.libreoffice.org/73089
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sc/source/ui/sidebar/NumberFormatControl.cxx b/sc/source/ui/sidebar/NumberFormatControl.cxx
index ef951c4eab75..9e05fcc5a545 100644
--- a/sc/source/ui/sidebar/NumberFormatControl.cxx
+++ b/sc/source/ui/sidebar/NumberFormatControl.cxx
@@ -55,7 +55,7 @@ void ScNumberFormatControl::StateChanged(sal_uInt16, SfxItemState eState,
     {
         case SfxItemState::DEFAULT:
         {
-            const SfxInt16Item* pItem = static_cast<const SfxInt16Item*>(pState);
+            const SfxUInt16Item* pItem = static_cast<const SfxUInt16Item*>(pState);
             sal_uInt16 nVal = pItem->GetValue();
             pComboBox->SelectEntryPos(nVal);
             break;


More information about the Libreoffice-commits mailing list