[Libreoffice-commits] online.git: wsd/DocumentBroker.cpp

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu May 30 06:44:34 UTC 2019


 wsd/DocumentBroker.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 2827d50ee7e6e9fb35bc32fdeddd193d20e54158
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Thu May 30 08:43:39 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Thu May 30 08:43:45 2019 +0200

    wsd: avoid unnecessary copy initialization in DocumentBroker
    
    'filename' was copy-constructed from a const reference, no need to make a
    copy.
    
    Change-Id: I2ad86a1a524359c3bd50975484d7742558e88dfd

diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 51ca64927..fefe15ccd 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -902,7 +902,7 @@ bool DocumentBroker::saveToStorageInternal(const std::string& sessionId,
         else if (isRename)
         {
             // encode the name
-            const std::string filename = storageSaveResult.getSaveAsName();
+            const std::string& filename = storageSaveResult.getSaveAsName();
             const std::string url = Poco::URI(storageSaveResult.getSaveAsUrl()).toString();
             std::string encodedName;
             Poco::URI::encode(filename, "", encodedName);


More information about the Libreoffice-commits mailing list