[Libreoffice-commits] core.git: vcl/osx

[Tor Lillqvist (via logerrit)]

 vcl/osx/salinst.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 4a98ceceae4bbe06b99d75ffd7c714ffdfe77e39
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Fri Nov 1 10:20:53 2019 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Fri Nov 1 10:34:28 2019 +0100

    Workaround for crash on macOS Catalina at least when built with Xcode 11
    
    For some unclear reason, for me at least, when I have built with Xcode
    11.1 or 11.2 and run on macOS Cataline, I run into a crash caused by
    boundless recursion related to the progress bar in the recovery
    dialog. Not setting mbProgressNeedsErase to true for the "NWF" seems
    to help.
    
    Whether this has some unintended visually bad side effect I don't
    know, but hey, it's just a progress bar, who cares if it in some
    circumstances doesn't look perfect?
    
    Change-Id: I6c990adde7689633b2c4b5aa42a4a07966565af2
    Reviewed-on: https://gerrit.libreoffice.org/81874
    Tested-by: Jenkins
    Reviewed-by: Tor Lillqvist <tml at collabora.com>
    Tested-by: Tor Lillqvist <tml at collabora.com>

diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx
index 4a23166a0fdc..45f9ba3546f3 100644
--- a/vcl/osx/salinst.cxx
+++ b/vcl/osx/salinst.cxx
@@ -324,7 +324,6 @@ VCLPLUG_OSX_PUBLIC SalInstance* create_SalInstance()
     ImplGetSVData()->maNWFData.mbNoFocusRects = true;
     ImplGetSVData()->maNWFData.mbNoActiveTabTextRaise = true;
     ImplGetSVData()->maNWFData.mbCenteredTabs = true;
-    ImplGetSVData()->maNWFData.mbProgressNeedsErase = true;
     ImplGetSVData()->maNWFData.mnStatusBarLowerRightOffset = 10;
 
     return pInst;