[Libreoffice-commits] core.git: sd/inc

Fri Nov 1 10:27:59 UTC 2019

sd/inc/CustomAnimationEffect.hxx |    2 +-
 sd/inc/anminfo.hxx               |    2 +-
 sd/inc/drawdoc.hxx               |    4 +---
 sd/inc/pglink.hxx                |    2 +-
 sd/inc/sdcgmfilter.hxx           |    2 +-
 sd/inc/sdgrffilter.hxx           |    2 +-
 sd/inc/sdhtmlfilter.hxx          |    3 +--
 sd/inc/sdpdffilter.hxx           |    2 +-
 sd/inc/sdpptwrp.hxx              |    2 +-
 sd/inc/sdxmlwrp.hxx              |    2 +-
 sd/inc/shapelist.hxx             |    2 +-
 sd/inc/stlfamily.hxx             |    2 +-
 sd/inc/textapi.hxx               |    2 +-
 sd/inc/undo/undofactory.hxx      |    2 +-
 sd/inc/undo/undomanager.hxx      |    2 +-
 sd/inc/undo/undoobjects.hxx      |    8 ++++----
 sd/inc/undoanim.hxx              |    6 +++---
 17 files changed, 22 insertions(+), 25 deletions(-)

New commits:
commit faff2437d83b437766d1c59dc473cc8b6ad9a548
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Fri Nov 1 11:28:02 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Nov 1 11:27:20 2019 +0100

    loplugin:finalclasses in sd/inc
    
    Change-Id: I29c7656d532fc0c8bcf1379a2f54d052aa4253e8
    Reviewed-on: https://gerrit.libreoffice.org/81877
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx
index f60e350ba3cf..cf2cfe7cb7a4 100644
--- a/sd/inc/CustomAnimationEffect.hxx
+++ b/sd/inc/CustomAnimationEffect.hxx
@@ -345,7 +345,7 @@ protected:
 
 class MainSequence;
 
-class InteractiveSequence : public EffectSequenceHelper
+class InteractiveSequence final : public EffectSequenceHelper
 {
 friend class MainSequence;
 friend class MainSequenceChangeGuard;
diff --git a/sd/inc/anminfo.hxx b/sd/inc/anminfo.hxx
index dbd13720ec29..08224994a2ce 100644
--- a/sd/inc/anminfo.hxx
+++ b/sd/inc/anminfo.hxx
@@ -28,7 +28,7 @@
 #include <tools/color.hxx>
 #include "sddllapi.h"
 
-class SD_DLLPUBLIC SdAnimationInfo : public SdrObjUserData
+class SD_DLLPUBLIC SdAnimationInfo final : public SdrObjUserData
 {
 public:
     PresObjKind             mePresObjKind;
diff --git a/sd/inc/drawdoc.hxx b/sd/inc/drawdoc.hxx
index 304d4e282c78..b5b6e574ca0c 100644
--- a/sd/inc/drawdoc.hxx
+++ b/sd/inc/drawdoc.hxx
@@ -128,7 +128,7 @@ namespace sd
 }
 
 // SdDrawDocument
-class SD_DLLPUBLIC SdDrawDocument : public FmFormModel
+class SD_DLLPUBLIC SdDrawDocument final : public FmFormModel
 {
 public:
     SAL_DLLPRIVATE void setDocAccTitle( const OUString& rTitle ) { msDocAccTitle = rTitle; }
@@ -200,8 +200,6 @@ private:
     bool mbEmbedFontScriptAsian : 1;
     bool mbEmbedFontScriptComplex : 1;
 
-protected:
-
     SAL_DLLPRIVATE virtual css::uno::Reference< css::uno::XInterface > createUnoModel() override;
 
 public:
diff --git a/sd/inc/pglink.hxx b/sd/inc/pglink.hxx
index a6344ca3ef7c..c36b2afcda3a 100644
--- a/sd/inc/pglink.hxx
+++ b/sd/inc/pglink.hxx
@@ -24,7 +24,7 @@
 
 class SdPage;
 
-class SdPageLink : public ::sfx2::SvBaseLink
+class SdPageLink final : public ::sfx2::SvBaseLink
 {
     SdPage* pPage;
 
diff --git a/sd/inc/sdcgmfilter.hxx b/sd/inc/sdcgmfilter.hxx
index 44ba359aab17..000a50bde63d 100644
--- a/sd/inc/sdcgmfilter.hxx
+++ b/sd/inc/sdcgmfilter.hxx
@@ -23,7 +23,7 @@
 #include "sdfilter.hxx"
 
 // SdCGMFilter
-class SdCGMFilter : public SdFilter
+class SdCGMFilter final : public SdFilter
 {
 public:
     SdCGMFilter (
diff --git a/sd/inc/sdgrffilter.hxx b/sd/inc/sdgrffilter.hxx
index 2b34ecf93e52..2ec180a52bf3 100644
--- a/sd/inc/sdgrffilter.hxx
+++ b/sd/inc/sdgrffilter.hxx
@@ -24,7 +24,7 @@
 class ErrCode;
 
 // SdCGMFilter
-class SdGRFFilter : public SdFilter
+class SdGRFFilter final : public SdFilter
 {
 public:
     SdGRFFilter ( SfxMedium& rMedium, ::sd::DrawDocShell& rDocShell );
diff --git a/sd/inc/sdhtmlfilter.hxx b/sd/inc/sdhtmlfilter.hxx
index 86a7eb157fe8..c55d24150b71 100644
--- a/sd/inc/sdhtmlfilter.hxx
+++ b/sd/inc/sdhtmlfilter.hxx
@@ -23,8 +23,7 @@
 #include "sdfilter.hxx"
 
 // SdHTMLFilter
-class SdHTMLFilter
-    : public SdFilter
+class SdHTMLFilter final : public SdFilter
 {
 public:
     SdHTMLFilter (
diff --git a/sd/inc/sdpdffilter.hxx b/sd/inc/sdpdffilter.hxx
index ce085a7036b3..44cae287d19f 100644
--- a/sd/inc/sdpdffilter.hxx
+++ b/sd/inc/sdpdffilter.hxx
@@ -28,7 +28,7 @@ namespace sd
 class DrawDocShell;
 }
 
-class SdPdfFilter : public SdFilter
+class SdPdfFilter final : public SdFilter
 {
 public:
     SdPdfFilter(SfxMedium& rMedium, ::sd::DrawDocShell& rDocShell);
diff --git a/sd/inc/sdpptwrp.hxx b/sd/inc/sdpptwrp.hxx
index 6414226d4596..9126f814d585 100644
--- a/sd/inc/sdpptwrp.hxx
+++ b/sd/inc/sdpptwrp.hxx
@@ -25,7 +25,7 @@
 #include <tools/stream.hxx>
 
 // SdPPTFilter
-class SdPPTFilter : public SdFilter
+class SdPPTFilter final : public SdFilter
 {
 public:
     SdPPTFilter (
diff --git a/sd/inc/sdxmlwrp.hxx b/sd/inc/sdxmlwrp.hxx
index a73ce57d22f7..9fe46506b9a0 100644
--- a/sd/inc/sdxmlwrp.hxx
+++ b/sd/inc/sdxmlwrp.hxx
@@ -32,7 +32,7 @@ enum SdXMLFilterMode
     SDXMLMODE_Organizer ///< only for import, only the styles are loaded
 };
 
-class SdXMLFilter : public SdFilter
+class SdXMLFilter final : public SdFilter
 {
 public:
     SdXMLFilter(
diff --git a/sd/inc/shapelist.hxx b/sd/inc/shapelist.hxx
index beef8211c9bb..c151fa6d2fcd 100644
--- a/sd/inc/shapelist.hxx
+++ b/sd/inc/shapelist.hxx
@@ -27,7 +27,7 @@
 
 namespace sd
 {
-    class ShapeList : public sdr::ObjectUser
+    class ShapeList final : public sdr::ObjectUser
     {
     public:
         ShapeList();
diff --git a/sd/inc/stlfamily.hxx b/sd/inc/stlfamily.hxx
index fbaa825505cc..aff19d1f1739 100644
--- a/sd/inc/stlfamily.hxx
+++ b/sd/inc/stlfamily.hxx
@@ -40,7 +40,7 @@ class SdStyleSheet;
 class SdPage;
 struct SdStyleFamilyImpl;
 
-class SdStyleFamily : public ::cppu::WeakImplHelper< css::container::XNameContainer, css::container::XNamed, css::container::XIndexAccess, css::lang::XSingleServiceFactory,  css::lang::XServiceInfo, css::lang::XComponent, css::beans::XPropertySet >
+class SdStyleFamily final : public ::cppu::WeakImplHelper< css::container::XNameContainer, css::container::XNamed, css::container::XIndexAccess, css::lang::XSingleServiceFactory,  css::lang::XServiceInfo, css::lang::XComponent, css::beans::XPropertySet >
 {
 public:
     /// creates the style family for the given SfxStyleFamily
diff --git a/sd/inc/textapi.hxx b/sd/inc/textapi.hxx
index 2141c3bfc6ff..40449c2f0cc2 100644
--- a/sd/inc/textapi.hxx
+++ b/sd/inc/textapi.hxx
@@ -30,7 +30,7 @@ namespace sd {
 
 class TextAPIEditSource;
 
-class TextApiObject : public SvxUnoText
+class TextApiObject final : public SvxUnoText
 {
 public:
     static rtl::Reference< TextApiObject > create( SdDrawDocument* pDoc );
diff --git a/sd/inc/undo/undofactory.hxx b/sd/inc/undo/undofactory.hxx
index 379349e37312..6341b006a568 100644
--- a/sd/inc/undo/undofactory.hxx
+++ b/sd/inc/undo/undofactory.hxx
@@ -25,7 +25,7 @@
 namespace sd
 {
 
-class UndoFactory : public SdrUndoFactory
+class UndoFactory final : public SdrUndoFactory
 {
 public:
     virtual std::unique_ptr<SdrUndoAction> CreateUndoRemoveObject(SdrObject& rObject) override;
diff --git a/sd/inc/undo/undomanager.hxx b/sd/inc/undo/undomanager.hxx
index 84a0e5394a4a..bed4f0f798f0 100644
--- a/sd/inc/undo/undomanager.hxx
+++ b/sd/inc/undo/undomanager.hxx
@@ -26,7 +26,7 @@
 namespace sd
 {
 
-class SD_DLLPUBLIC UndoManager : public SdrUndoManager
+class SD_DLLPUBLIC UndoManager final : public SdrUndoManager
 {
 public:
     UndoManager();
diff --git a/sd/inc/undo/undoobjects.hxx b/sd/inc/undo/undoobjects.hxx
index 61edc1bbf4c5..53b81b61d911 100644
--- a/sd/inc/undo/undoobjects.hxx
+++ b/sd/inc/undo/undoobjects.hxx
@@ -46,7 +46,7 @@ private:
     std::unique_ptr<SfxUndoAction>  mpUndoPresObj;
 };
 
-class UndoRemoveObject : public SdrUndoRemoveObj, public UndoRemovePresObjectImpl
+class UndoRemoveObject final : public SdrUndoRemoveObj, public UndoRemovePresObjectImpl
 {
 public:
     UndoRemoveObject(SdrObject& rObject);
@@ -58,7 +58,7 @@ private:
     ::tools::WeakReference<SdrObject> mxSdrObject;
 };
 
-class UndoDeleteObject : public SdrUndoDelObj, public UndoRemovePresObjectImpl
+class UndoDeleteObject final : public SdrUndoDelObj, public UndoRemovePresObjectImpl
 {
 public:
     UndoDeleteObject( SdrObject& rObject, bool bOrdNumDirect );
@@ -70,7 +70,7 @@ private:
     ::tools::WeakReference<SdrObject> mxSdrObject;
 };
 
-class UndoReplaceObject : public SdrUndoReplaceObj, public UndoRemovePresObjectImpl
+class UndoReplaceObject final : public SdrUndoReplaceObj, public UndoRemovePresObjectImpl
 {
 public:
     UndoReplaceObject( SdrObject& rOldObject, SdrObject& rNewObject );
@@ -82,7 +82,7 @@ private:
     ::tools::WeakReference<SdrObject> mxSdrObject;
 };
 
-class UndoObjectSetText : public SdrUndoObjSetText
+class UndoObjectSetText final : public SdrUndoObjSetText
 {
 public:
     UndoObjectSetText( SdrObject& rNewObj, sal_Int32 nText );
diff --git a/sd/inc/undoanim.hxx b/sd/inc/undoanim.hxx
index 6270ad97c385..68169b686a5c 100644
--- a/sd/inc/undoanim.hxx
+++ b/sd/inc/undoanim.hxx
@@ -33,7 +33,7 @@ namespace sd
 
 struct UndoAnimationImpl;
 
-class UndoAnimation : public SdrUndoAction
+class UndoAnimation final : public SdrUndoAction
 {
 public:
     UndoAnimation( SdDrawDocument* pDoc, SdPage* pThePage );
@@ -49,7 +49,7 @@ private:
 };
 
 struct UndoAnimationPathImpl;
-class UndoAnimationPath : public SdrUndoAction
+class UndoAnimationPath final : public SdrUndoAction
 {
 public:
     UndoAnimationPath( SdDrawDocument* pDoc, SdPage* pThePage, const css::uno::Reference< css::animations::XAnimationNode >& xNode );
@@ -66,7 +66,7 @@ private:
 
 struct UndoTransitionImpl;
 
-class UndoTransition : public SdUndoAction
+class UndoTransition final : public SdUndoAction
 {
 public:
     UndoTransition( SdDrawDocument* pDoc, SdPage* pThePage );
