[Libreoffice-commits] core.git: vcl/source

Luke Deller (via logerrit) logerrit at kemper.freedesktop.org
Fri Nov 1 17:25:59 UTC 2019


 vcl/source/gdi/impgraph.cxx |    3 +++
 1 file changed, 3 insertions(+)

New commits:
commit c01e9df2da2e2ab139482563b8a801d0410357c2
Author:     Luke Deller <luke at deller.id.au>
AuthorDate: Fri Nov 1 23:21:24 2019 +1100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Nov 1 18:25:07 2019 +0100

    Fix use of uninitialised variable
    
    Ensure ImpGraphic::maSwapInfo.mbIsTransparent/mbIsAlpha are initialised
    in the case where image type detection fails.
    
    Change-Id: I103d77760326aa3833dd3730ec65fd53d360271b
    Reviewed-on: https://gerrit.libreoffice.org/81882
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/vcl/source/gdi/impgraph.cxx b/vcl/source/gdi/impgraph.cxx
index 17c371e6d77f..2fbd6795394c 100644
--- a/vcl/source/gdi/impgraph.cxx
+++ b/vcl/source/gdi/impgraph.cxx
@@ -570,6 +570,9 @@ void ImpGraphic::ImplSetPrepared(bool bAnimated, const Size* pSizeHint)
         maSwapInfo.maSizePixel = aDescriptor.GetSizePixel();
         maSwapInfo.mbIsTransparent = aDescriptor.IsTransparent();
         maSwapInfo.mbIsAlpha = aDescriptor.IsAlpha();
+    } else {
+        maSwapInfo.mbIsTransparent = false;
+        maSwapInfo.mbIsAlpha = false;
     }
 
     maSwapInfo.mnAnimationLoopCount = 0;


More information about the Libreoffice-commits mailing list