[Libreoffice-commits] online.git: loleaflet/src

Henry Castro (via logerrit) logerrit at kemper.freedesktop.org
Mon Nov 4 21:28:12 UTC 2019


 loleaflet/src/layer/tile/ImpressTileLayer.js |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 06b0bfe3e07a25a45bc4cf30126fadf13463a697
Author:     Henry Castro <hcastro at collabora.com>
AuthorDate: Mon Nov 4 16:55:29 2019 -0400
Commit:     Henry Castro <hcastro at collabora.com>
CommitDate: Mon Nov 4 22:27:54 2019 +0100

    loleaflet: fix "Uncaught TypeError: Cannot set property 'invalid' of
    
    undefined".
    
    ImpressTileLayer.js:686 Uncaught TypeError: Cannot set property
    'invalid' of undefined
        at NewClass._onInvalidateTilesMsg (ImpressTileLayer.js:686)
        at NewClass._onMessage (TileLayer.js:553)
        at NewClass._onMessage (ImpressTileLayer.js:604)
        at NewClass._onMessage (Socket.js:806)
    
    Change-Id: Iea1272d8239a56731685597d022f63eb663bd6ea
    Reviewed-on: https://gerrit.libreoffice.org/82044
    Reviewed-by: Henry Castro <hcastro at collabora.com>
    Tested-by: Henry Castro <hcastro at collabora.com>

diff --git a/loleaflet/src/layer/tile/ImpressTileLayer.js b/loleaflet/src/layer/tile/ImpressTileLayer.js
index fd2ee785b..f47695176 100644
--- a/loleaflet/src/layer/tile/ImpressTileLayer.js
+++ b/loleaflet/src/layer/tile/ImpressTileLayer.js
@@ -685,7 +685,10 @@ L.ImpressTileLayer = L.TileLayer.extend({
 			this._map.fire('updatepart', {part: command.part, docType: this._docType});
 		}
 
-		this._map._docPreviews[command.part].invalid = true;
+		var preview = this._map._docPreviews[command.part];
+		if (preview) {
+			preview.invalid = true;
+		}
 		this._previewInvalidations.push(invalidBounds);
 		// 1s after the last invalidation, update the preview
 		clearTimeout(this._previewInvalidator);


More information about the Libreoffice-commits mailing list