[Libreoffice-commits] core.git: include/svx

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Tue Nov 5 17:59:36 UTC 2019


 include/svx/svdobj.hxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7eb26eceb52bea93b9ccd90f18cf5ec11dcbb365
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Nov 5 18:08:37 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Nov 5 18:58:26 2019 +0100

    Looks like UBSan still needs SdrObjGeoData's RTTI for some reason
    
    After c02c4df9414ed2bef96565522238ca05013d3ac3 "make some classes
    module-private", CppunitTest_services failed in my Linux ASan+UBSan build with
    
    > .../postprocess/qa/services.cxx:318:(anonymous namespace)::Test::test
    > forced failure
    > - instantiating "com.sun.star.comp.oox.xls.ExcelFilter" via "com.sun.star.comp.oox.xls.ExcelFilter"  caused com.sun.star.loader.CannotActivateFactoryException "loading component library <file:///.../instdir/program/libscfiltlo.so> failed"
    
    due to
    
    > info:sal.osl:1711464:1711464:sal/osl/unx/module.cxx:162: dlopen(.../instdir/program/libscfiltlo.so, 257): .../instdir/program/libscfiltlo.so: undefined symbol: _ZTI13SdrObjGeoData
    
    Change-Id: I2838b01df9886d4d2093d79cad94a21ad76bab96
    Reviewed-on: https://gerrit.libreoffice.org/82083
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/include/svx/svdobj.hxx b/include/svx/svdobj.hxx
index 24dd38a9044e..361062554a87 100644
--- a/include/svx/svdobj.hxx
+++ b/include/svx/svdobj.hxx
@@ -223,7 +223,7 @@ public:
 /**
  * All geometrical data of an arbitrary object for use in undo/redo
  */
-class SdrObjGeoData
+class SAL_DLLPUBLIC_RTTI SdrObjGeoData
 {
 public:
     tools::Rectangle                   aBoundRect;


More information about the Libreoffice-commits mailing list