[Libreoffice-commits] core.git: compilerplugins/clang fpicker/source vcl/unx

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Thu Nov 7 07:07:02 UTC 2019


 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   72 ++++-----
 compilerplugins/clang/unusedfields.readonly.results                 |   26 +--
 compilerplugins/clang/unusedfields.untouched.results                |   38 ++---
 compilerplugins/clang/unusedfields.writeonly.results                |   74 +++++-----
 fpicker/source/office/PlacesListBox.cxx                             |    2 
 fpicker/source/office/PlacesListBox.hxx                             |    1 
 fpicker/source/office/RemoteFilesDialog.cxx                         |    4 
 fpicker/source/office/RemoteFilesDialog.hxx                         |    2 
 fpicker/source/office/autocmpledit.cxx                              |    2 
 fpicker/source/office/autocmpledit.hxx                              |    1 
 vcl/unx/gtk3/gtk3gtkinst.cxx                                        |    2 
 11 files changed, 107 insertions(+), 117 deletions(-)

New commits:
commit ef77870b1c5ed4df88d4585064c968379f3955a7
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Nov 7 08:23:08 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Nov 7 08:06:27 2019 +0100

    loplugin:unusedfields
    
    Change-Id: Ic1c0a2144f39373f93384bccbfc74356cac65ba0
    Reviewed-on: https://gerrit.libreoffice.org/82185
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index 7216d60220cd..1d828b56cedf 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -22,7 +22,7 @@ binaryurp/source/unmarshal.hxx:87
     binaryurp::Unmarshal buffer_ com::sun::star::uno::Sequence<sal_Int8>
 binaryurp/source/writer.hxx:148
     binaryurp::Writer state_ struct binaryurp::WriterState
-canvas/source/vcl/impltools.hxx:117
+canvas/source/vcl/impltools.hxx:115
     vclcanvas::tools::LocalGuard aSolarGuard class SolarMutexGuard
 canvas/workben/canvasdemo.cxx:83
     DemoRenderer maColorWhite uno::Sequence<double>
@@ -76,9 +76,9 @@ connectivity/source/inc/flat/EResultSet.hxx:42
     connectivity::flat::OFlatResultSet m_bBookmarkable _Bool
 connectivity/source/inc/java/lang/Object.hxx:45
     connectivity::SDBThreadAttach m_aGuard jvmaccess::class VirtualMachine::AttachGuard
-cppcanvas/source/mtfrenderer/textaction.cxx:811
+cppcanvas/source/mtfrenderer/textaction.cxx:810
     cppcanvas::internal::(anonymous namespace)::EffectTextAction maTextLineInfo const tools::TextLineInfo
-cppcanvas/source/mtfrenderer/textaction.cxx:1644
+cppcanvas/source/mtfrenderer/textaction.cxx:1643
     cppcanvas::internal::(anonymous namespace)::OutlineAction maTextLineInfo const tools::TextLineInfo
 cppu/source/threadpool/threadpool.cxx:354
     _uno_ThreadPool dummy sal_Int32
@@ -172,10 +172,6 @@ drawinglayer/source/tools/emfphelperdata.hxx:153
     emfplushelper::EmfPlusHelperData mnFrameRight sal_Int32
 drawinglayer/source/tools/emfphelperdata.hxx:154
     emfplushelper::EmfPlusHelperData mnFrameBottom sal_Int32
-editeng/source/accessibility/AccessibleHyperlink.hxx:46
-    accessibility::AccessibleHyperlink nPara sal_Int32
-editeng/source/accessibility/AccessibleHyperlink.hxx:47
-    accessibility::AccessibleHyperlink nRealIdx sal_uInt16
 editeng/source/editeng/impedit.hxx:465
     ImpEditEngine aSelFuncSet class EditSelFunctionSet
 filter/source/flash/swfwriter.hxx:391
@@ -200,11 +196,11 @@ include/drawinglayer/texture/texture3d.hxx:62
     drawinglayer::texture::GeoTexSvxBitmapEx maBitmap class Bitmap
 include/drawinglayer/texture/texture3d.hxx:64
     drawinglayer::texture::GeoTexSvxBitmapEx maTransparence class Bitmap
-include/filter/msfilter/svdfppt.hxx:880
+include/filter/msfilter/svdfppt.hxx:879
     ImplPPTParaPropSet nDontKnow1 sal_uInt32
-include/filter/msfilter/svdfppt.hxx:881
+include/filter/msfilter/svdfppt.hxx:880
     ImplPPTParaPropSet nDontKnow2 sal_uInt32
-include/filter/msfilter/svdfppt.hxx:882
+include/filter/msfilter/svdfppt.hxx:881
     ImplPPTParaPropSet nDontKnow2bit06 sal_uInt16
 include/LibreOfficeKit/LibreOfficeKitGtk.h:33
     _LOKDocView aDrawingArea GtkDrawingArea
@@ -344,7 +340,7 @@ include/svl/ondemand.hxx:55
     OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale
 include/svx/ClassificationDialog.hxx:31
     svx::ClassificationDialog m_bPerParagraph const _Bool
-include/svx/imapdlg.hxx:94
+include/svx/imapdlg.hxx:91
     SvxIMapDlg aIMapItem class SvxIMapDlgItem
 include/svx/itemwin.hxx:33
     SvxLineBox aDelayTimer class Timer
@@ -364,8 +360,6 @@ include/vcl/NotebookBarAddonsMerger.hxx:45
     AddonsParams sControlType class rtl::OUString
 include/vcl/NotebookBarAddonsMerger.hxx:46
     AddonsParams nWidth sal_uInt16
-include/vcl/svimpbox.hxx:127
-    SvImpLBox m_aFctSet class ImpLBSelEng
 include/xmloff/shapeimport.hxx:140
     SdXML3DLightContext mbSpecular _Bool
 libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:35
@@ -458,17 +452,17 @@ sal/qa/osl/condition/osl_Condition.cxx:198
     osl_Condition::wait bRes2 _Bool
 sal/qa/osl/condition/osl_Condition.cxx:269
     osl_Condition::check bRes2 _Bool
-sal/qa/osl/file/osl_File.cxx:1584
-    osl_FileStatus::getFileType m_aFifoItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1584
+sal/qa/osl/file/osl_File.cxx:1586
     osl_FileStatus::getFileType m_aVolumeItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1585
+sal/qa/osl/file/osl_File.cxx:1586
+    osl_FileStatus::getFileType m_aFifoItem class osl::DirectoryItem
+sal/qa/osl/file/osl_File.cxx:1587
     osl_FileStatus::getFileType m_aLinkItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1585
+sal/qa/osl/file/osl_File.cxx:1587
     osl_FileStatus::getFileType m_aSocketItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1585
+sal/qa/osl/file/osl_File.cxx:1587
     osl_FileStatus::getFileType m_aSpecialItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:3417
+sal/qa/osl/file/osl_File.cxx:3419
     osl_File::setAttributes rItem_hidden class osl::DirectoryItem
 sal/qa/osl/module/osl_Module.cxx:67
     osl_Module::ctors bRes1 _Bool
@@ -508,19 +502,19 @@ sal/textenc/textenc.cxx:406
     (anonymous namespace)::FullTextEncodingData module_ osl::Module
 sc/inc/column.hxx:126
     ScColumn maCellsEvent const sc::CellStoreEvent
-sc/inc/compiler.hxx:256
+sc/inc/compiler.hxx:258
     ScCompiler::AddInMap pODFF const char *
-sc/inc/compiler.hxx:257
-    ScCompiler::AddInMap pEnglish const char *
 sc/inc/compiler.hxx:259
+    ScCompiler::AddInMap pEnglish const char *
+sc/inc/compiler.hxx:261
     ScCompiler::AddInMap pUpper const char *
 sc/inc/token.hxx:400
     SingleDoubleRefModifier aDub struct ScComplexRefData
 sc/qa/unit/ucalc_column.cxx:104
     aInputs aName const char *
-sc/source/core/data/document.cxx:1239
+sc/source/core/data/document.cxx:1237
     (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch const sc::AutoCalcSwitch
-sc/source/core/data/document.cxx:1240
+sc/source/core/data/document.cxx:1238
     (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk const class ScBulkBroadcast
 sc/source/filter/html/htmlpars.cxx:3004
     (anonymous namespace)::CSSHandler::MemStr mp const char *
@@ -530,9 +524,9 @@ sc/source/filter/inc/htmlpars.hxx:614
     ScHTMLQueryParser mnUnusedId ScHTMLTableId
 sc/source/filter/inc/sheetdatacontext.hxx:62
     oox::xls::SheetDataContext aReleaser const class SolarMutexReleaser
-sc/source/filter/inc/xetable.hxx:1005
-    XclExpCellTable maArrayBfr class XclExpArrayBuffer
 sc/source/filter/inc/xetable.hxx:1006
+    XclExpCellTable maArrayBfr class XclExpArrayBuffer
+sc/source/filter/inc/xetable.hxx:1007
     XclExpCellTable maShrfmlaBfr class XclExpShrfmlaBuffer
 sc/source/filter/inc/xiescher.hxx:1206
     XclImpDffPropSet maDummyStrm class SvMemoryStream
@@ -582,7 +576,7 @@ sccomp/source/solver/DifferentialEvolution.hxx:35
     DifferentialEvolutionAlgorithm maRandomDevice std::random_device
 sccomp/source/solver/ParticelSwarmOptimization.hxx:56
     ParticleSwarmOptimizationAlgorithm maRandomDevice std::random_device
-scripting/source/stringresource/stringresource.cxx:1298
+scripting/source/stringresource/stringresource.cxx:1294
     stringresource::BinaryInput m_aData const Sequence<sal_Int8>
 sd/inc/anminfo.hxx:52
     SdAnimationInfo maSecondSoundFile const class rtl::OUString
@@ -742,9 +736,9 @@ sw/inc/unosett.hxx:145
     SwXNumberingRules m_pImpl ::sw::UnoImplPtr<Impl>
 sw/qa/core/test_ToxTextGenerator.cxx:139
     ToxTextGeneratorWithMockedChapterField mChapterFieldType class SwChapterFieldType
-sw/qa/extras/uiwriter/uiwriter2.cxx:66
+sw/qa/extras/uiwriter/uiwriter2.cxx:67
       class SwUiWriterTest2 *
-sw/qa/extras/uiwriter/uiwriter.cxx:4065
+sw/qa/extras/uiwriter/uiwriter.cxx:4069
     IdleTask maIdle class Idle
 sw/source/core/crsr/crbm.cxx:64
     (anonymous namespace)::CursorStateHelper m_aSaveState const class SwCursorSaveState
@@ -806,6 +800,8 @@ vcl/inc/salmenu.hxx:43
     SalMenuButtonItem maImage class Image
 vcl/inc/salmenu.hxx:44
     SalMenuButtonItem maToolTipText class rtl::OUString
+vcl/inc/svimpbox.hxx:127
+    SvImpLBox m_aFctSet class ImpLBSelEng
 vcl/inc/unx/i18n_ic.hxx:40
     SalI18N_InputContext maPreeditStartCallback XIMCallback
 vcl/inc/unx/i18n_ic.hxx:41
@@ -830,9 +826,9 @@ vcl/inc/WidgetThemeLibrary.hxx:90
     vcl::ControlDrawParameters eState enum ControlState
 vcl/inc/WidgetThemeLibrary.hxx:106
     vcl::WidgetThemeLibrary_t nSize uint32_t
-vcl/source/app/salvtables.cxx:3049
+vcl/source/app/salvtables.cxx:3116
     SalInstanceEntry m_aTextFilter class (anonymous namespace)::WeldTextFilter
-vcl/source/app/salvtables.cxx:5536
+vcl/source/app/salvtables.cxx:5838
     SalInstanceComboBoxWithEdit m_aTextFilter class (anonymous namespace)::WeldTextFilter
 vcl/source/gdi/jobset.cxx:35
     ImplOldJobSetupData cDeviceName char [32]
@@ -850,13 +846,17 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:75
     AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
 vcl/unx/gtk3/a11y/gtk3atkhypertext.cxx:29
     HyperLink atk_hyper_link const AtkHyperlink
-vcl/unx/gtk3/gtk3gloactiongroup.cxx:28
+vcl/unx/gtk3/gtk3gloactiongroup.cxx:26
     GLOAction parent_instance GObject
-vcl/unx/gtk3/gtk3glomenu.cxx:17
+vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
-vcl/unx/gtk3/gtk3gtkinst.cxx:4705
+vcl/unx/gtk3/gtk3gtkinst.cxx:4716
     CrippledViewport viewport GtkViewport
-writerfilter/source/dmapper/PropertyMap.hxx:198
+vcl/unx/gtk3/gtk3gtkinst.cxx:9776
+    GtkInstanceIconView m_aViewColToModelCol std::vector<int>
+vcl/unx/gtk3/gtk3gtkinst.cxx:9777
+    GtkInstanceIconView m_aModelColToViewCol std::vector<int>
+writerfilter/source/dmapper/PropertyMap.hxx:204
     writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
 xmloff/source/text/XMLTextListBlockContext.hxx:35
     XMLTextListBlockContext msListStyleName class rtl::OUString
diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results
index 5a4856263b5c..787ffe25c19e 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -98,7 +98,7 @@ connectivity/source/inc/TConnection.hxx:56
     connectivity::OMetaConnection m_aResources class connectivity::SharedResources
 connectivity/source/inc/writer/WTable.hxx:65
     connectivity::writer::OWriterTable m_nStartCol sal_Int32
-cppcanvas/source/mtfrenderer/textaction.cxx:1652
+cppcanvas/source/mtfrenderer/textaction.cxx:1651
     cppcanvas::internal::(anonymous namespace)::OutlineAction maTextFillColor const ::Color
 cppu/source/helper/purpenv/helper_purpenv_Mapping.cxx:34
     Mapping m_from uno::Environment
@@ -172,7 +172,7 @@ dbaccess/source/core/inc/ContentHelper.hxx:109
     dbaccess::OContentHelper m_aErrorHelper const ::connectivity::SQLError
 dbaccess/source/filter/hsqldb/parseschema.hxx:36
     dbahsql::SchemaParser m_PrimaryKeys std::map<OUString, std::vector<OUString> >
-dbaccess/source/ui/control/tabletree.cxx:234
+dbaccess/source/ui/control/tabletree.cxx:233
     dbaui::(anonymous namespace)::OViewSetter m_aEqualFunctor ::comphelper::UStringMixEqual
 dbaccess/source/ui/inc/charsetlistbox.hxx:44
     dbaui::CharSetListBox m_aCharSets class dbaui::OCharsetDisplay
@@ -278,13 +278,13 @@ include/drawinglayer/processor3d/defaultprocessor3d.hxx:90
     drawinglayer::processor3d::DefaultProcessor3D maDrawinglayerOpt const class SvtOptionsDrawinglayer
 include/editeng/brushitem.hxx:51
     SvxBrushItem maSecOptions class SvtSecurityOptions
-include/filter/msfilter/svdfppt.hxx:709
+include/filter/msfilter/svdfppt.hxx:708
     PPTExtParaSheet aExtParaLevel struct PPTExtParaLevel [5]
-include/filter/msfilter/svdfppt.hxx:880
+include/filter/msfilter/svdfppt.hxx:879
     ImplPPTParaPropSet nDontKnow1 sal_uInt32
-include/filter/msfilter/svdfppt.hxx:881
+include/filter/msfilter/svdfppt.hxx:880
     ImplPPTParaPropSet nDontKnow2 sal_uInt32
-include/filter/msfilter/svdfppt.hxx:882
+include/filter/msfilter/svdfppt.hxx:881
     ImplPPTParaPropSet nDontKnow2bit06 sal_uInt16
 include/oox/core/contexthandler2.hxx:217
     oox::core::ContextHandler2Helper mnRootStackSize const size_t
@@ -370,7 +370,7 @@ include/unoidl/unoidl.hxx:453
     unoidl::ConstantValue::(anonymous) doubleValue double
 include/unotest/bootstrapfixturebase.hxx:52
     test::BootstrapFixtureBase m_directories class test::Directories
-include/vcl/headbar.hxx:231
+include/vcl/headbar.hxx:229
     HeaderBar maDragHdl Link<class HeaderBar *, void>
 include/vcl/opengl/OpenGLContext.hxx:48
     OpenGLCapabilitySwitch mbLimitedShaderRegisters _Bool
@@ -604,11 +604,11 @@ sw/source/core/access/accmap.cxx:631
     SwAccessibleEventMap_Impl maMap std::map<key_type, mapped_type, key_compare>
 sw/source/core/access/accmap.cxx:671
     SwAccessibleSelectedParas_Impl maMap std::map<key_type, mapped_type, key_compare>
-sw/source/core/doc/swstylemanager.cxx:58
+sw/source/core/doc/swstylemanager.cxx:54
     SwStyleManager aAutoCharPool class StylePool
-sw/source/core/doc/swstylemanager.cxx:59
+sw/source/core/doc/swstylemanager.cxx:55
     SwStyleManager aAutoParaPool class StylePool
-sw/source/core/doc/tblrwcl.cxx:84
+sw/source/core/doc/tblrwcl.cxx:78
     CpyTabFrame::(anonymous) nSize SwTwips
 sw/source/core/inc/swblocks.hxx:69
     SwImpBlocks m_bInPutMuchBlocks _Bool
@@ -626,7 +626,7 @@ sw/source/uibase/dbui/mmconfigitem.cxx:113
     SwMailMergeConfigItem_Impl m_aNeutralGreetingLines std::vector<OUString>
 sw/source/uibase/inc/fldmgr.hxx:79
     SwInsertField_Data m_aDBDataSource const css::uno::Any
-toolkit/source/awt/vclxtoolkit.cxx:430
+toolkit/source/awt/vclxtoolkit.cxx:432
     (anonymous namespace)::VCLXToolkit mxSelection css::uno::Reference<css::datatransfer::clipboard::XClipboard>
 ucb/source/ucp/gio/gio_mount.hxx:74
     OOoMountOperationClass parent_class GMountOperationClass
@@ -950,9 +950,9 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:47
     AtkObjectWrapper aParent const AtkObject
 vcl/unx/gtk3/a11y/atkwrapper.hxx:75
     AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
-vcl/unx/gtk3/gtk3gloactiongroup.cxx:28
+vcl/unx/gtk3/gtk3gloactiongroup.cxx:26
     GLOAction parent_instance GObject
-vcl/unx/gtk3/gtk3glomenu.cxx:17
+vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
 vcl/unx/gtk3/gtk3gtkinst.cxx:1596
      out gpointer *
diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index 7daabcd8d7a9..45910c70238a 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -16,9 +16,9 @@ basic/qa/cppunit/basictest.hxx:27
     MacroSnippet maDll class BasicDLL
 basic/source/runtime/dllmgr.hxx:48
     SbiDllMgr impl_ std::unique_ptr<Impl>
-canvas/source/vcl/canvasbitmap.hxx:117
+canvas/source/vcl/canvasbitmap.hxx:114
     vclcanvas::CanvasBitmap mxDevice css::uno::Reference<css::rendering::XGraphicDevice>
-canvas/source/vcl/impltools.hxx:117
+canvas/source/vcl/impltools.hxx:115
     vclcanvas::tools::LocalGuard aSolarGuard class SolarMutexGuard
 canvas/workben/canvasdemo.cxx:83
     DemoRenderer maColorWhite uno::Sequence<double>
@@ -119,13 +119,13 @@ include/sfx2/msg.hxx:138
 include/sfx2/msg.hxx:138
     SfxType7 pType const std::type_info *
 include/sfx2/msg.hxx:139
+    SfxType8 aAttrib struct SfxTypeAttrib [8]
+include/sfx2/msg.hxx:139
     SfxType8 pType const std::type_info *
 include/sfx2/msg.hxx:139
     SfxType8 nAttribs sal_uInt16
 include/sfx2/msg.hxx:139
     SfxType8 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
-include/sfx2/msg.hxx:139
-    SfxType8 aAttrib struct SfxTypeAttrib [8]
 include/sfx2/msg.hxx:140
     SfxType10 pType const std::type_info *
 include/sfx2/msg.hxx:140
@@ -186,7 +186,7 @@ include/svtools/genericunodialog.hxx:156
     svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard
 include/svtools/unoevent.hxx:163
     SvEventDescriptor xParentRef css::uno::Reference<css::uno::XInterface>
-include/svx/imapdlg.hxx:94
+include/svx/imapdlg.hxx:91
     SvxIMapDlg aIMapItem class SvxIMapDlgItem
 include/vcl/commandevent.hxx:310
     CommandGestureData mfX const double
@@ -208,7 +208,7 @@ include/vcl/NotebookBarAddonsMerger.hxx:46
     AddonsParams nWidth sal_uInt16
 include/vcl/uitest/uiobject.hxx:272
     TabPageUIObject mxTabPage VclPtr<class TabPage>
-include/xmloff/formlayerexport.hxx:173
+include/xmloff/formlayerexport.hxx:172
     xmloff::OOfficeFormsExport m_pImpl std::unique_ptr<OFormsRootExport>
 libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:35
     GtvApplicationWindowPrivate lokDialog GtkWidget *
@@ -268,17 +268,17 @@ sal/qa/osl/condition/osl_Condition.cxx:198
     osl_Condition::wait bRes2 _Bool
 sal/qa/osl/condition/osl_Condition.cxx:269
     osl_Condition::check bRes2 _Bool
-sal/qa/osl/file/osl_File.cxx:1584
+sal/qa/osl/file/osl_File.cxx:1586
     osl_FileStatus::getFileType m_aFifoItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1584
+sal/qa/osl/file/osl_File.cxx:1586
     osl_FileStatus::getFileType m_aVolumeItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1585
+sal/qa/osl/file/osl_File.cxx:1587
     osl_FileStatus::getFileType m_aLinkItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1585
+sal/qa/osl/file/osl_File.cxx:1587
     osl_FileStatus::getFileType m_aSocketItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1585
+sal/qa/osl/file/osl_File.cxx:1587
     osl_FileStatus::getFileType m_aSpecialItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:3417
+sal/qa/osl/file/osl_File.cxx:3419
     osl_File::setAttributes rItem_hidden class osl::DirectoryItem
 sal/qa/osl/module/osl_Module.cxx:67
     osl_Module::ctors bRes1 _Bool
@@ -314,9 +314,9 @@ sal/qa/osl/security/osl_Security.cxx:188
     osl_Security::getConfigDir bRes1 _Bool
 sc/qa/unit/ucalc_column.cxx:104
     aInputs aName const char *
-sc/source/core/data/document.cxx:1239
+sc/source/core/data/document.cxx:1237
     (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch const sc::AutoCalcSwitch
-sc/source/core/data/document.cxx:1240
+sc/source/core/data/document.cxx:1238
     (anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk const class ScBulkBroadcast
 sc/source/filter/html/htmlpars.cxx:3004
     (anonymous namespace)::CSSHandler::MemStr mp const char *
@@ -384,11 +384,11 @@ svx/source/dialog/contimp.hxx:75
     SvxSuperContourDlg aContourItem class SvxContourDlgItem
 svx/source/dialog/weldeditview.cxx:300
     WeldEditSource m_rEditAcc class WeldEditAccessible &
-sw/qa/extras/uiwriter/uiwriter2.cxx:66
+sw/qa/extras/uiwriter/uiwriter2.cxx:67
       class SwUiWriterTest2 *
 sw/source/core/crsr/crbm.cxx:64
     (anonymous namespace)::CursorStateHelper m_aSaveState const class SwCursorSaveState
-sw/source/core/frmedt/fetab.cxx:78
+sw/source/core/frmedt/fetab.cxx:79
     TableWait m_pWait const std::unique_ptr<SwWait>
 sw/source/core/layout/dbg_lay.cxx:172
     SwImplEnterLeave nAction const enum DbgAction
@@ -450,7 +450,11 @@ vcl/source/uitest/uno/uitest_uno.cxx:35
     UITestUnoObj mpUITest std::unique_ptr<UITest>
 vcl/unx/gtk3/a11y/gtk3atkhypertext.cxx:29
     HyperLink atk_hyper_link const AtkHyperlink
-vcl/unx/gtk3/gtk3gtkinst.cxx:4705
+vcl/unx/gtk3/gtk3gtkinst.cxx:4716
     CrippledViewport viewport GtkViewport
+vcl/unx/gtk3/gtk3gtkinst.cxx:9776
+    GtkInstanceIconView m_aViewColToModelCol std::vector<int>
+vcl/unx/gtk3/gtk3gtkinst.cxx:9777
+    GtkInstanceIconView m_aModelColToViewCol std::vector<int>
 writerfilter/source/ooxml/OOXMLStreamImpl.hxx:43
     writerfilter::ooxml::OOXMLStreamImpl mxFastParser css::uno::Reference<css::xml::sax::XFastParser>
diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results
index 43f6da9b7c8e..6f912b840abf 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -58,11 +58,11 @@ bridges/source/jni_uno/jni_java2uno.cxx:151
     jni_uno::largest p void *
 bridges/source/jni_uno/jni_java2uno.cxx:152
     jni_uno::largest a uno_Any
-canvas/source/cairo/cairo_canvasbitmap.hxx:122
+canvas/source/cairo/cairo_canvasbitmap.hxx:120
     cairocanvas::CanvasBitmap mpBufferCairo ::cairo::CairoSharedPtr
-canvas/source/cairo/cairo_spritedevicehelper.hxx:76
+canvas/source/cairo/cairo_spritedevicehelper.hxx:74
     cairocanvas::SpriteDeviceHelper mbFullScreen _Bool
-canvas/source/cairo/cairo_spritehelper.hxx:103
+canvas/source/cairo/cairo_spritehelper.hxx:99
     cairocanvas::SpriteHelper mbTextureDirty _Bool
 chart2/inc/ChartModel.hxx:143
     chart::ChartModel m_aGraphicObjectVector std::vector<GraphicObject>
@@ -152,7 +152,7 @@ connectivity/source/inc/OTypeInfo.hxx:38
     connectivity::OTypeInfo nType sal_Int16
 connectivity/source/inc/writer/WConnection.hxx:66
     connectivity::writer::OWriterConnection::CloseVetoButTerminateListener m_pCloseListener std::unique_ptr<utl::CloseVeto>
-cppcanvas/source/inc/implrenderer.hxx:215
+cppcanvas/source/inc/implrenderer.hxx:211
     cppcanvas::internal::ImplRenderer aBaseTransform struct cppcanvas::internal::XForm
 cppu/source/typelib/typelib.cxx:897
     (anonymous namespace)::BaseList set (anonymous namespace)::BaseList::Set
@@ -268,10 +268,6 @@ drawinglayer/source/attribute/sdrsceneattribute3d.cxx:32
     drawinglayer::attribute::ImpSdrSceneAttribute mfDistance double
 drawinglayer/source/tools/emfpcustomlinecap.hxx:34
     emfplushelper::EMFPCustomLineCap mbIsFilled _Bool
-editeng/source/accessibility/AccessibleHyperlink.hxx:46
-    accessibility::AccessibleHyperlink nPara sal_Int32
-editeng/source/accessibility/AccessibleHyperlink.hxx:47
-    accessibility::AccessibleHyperlink nRealIdx sal_uInt16
 embeddedobj/source/inc/oleembobj.hxx:132
     OleEmbeddedObject m_nTargetState sal_Int32
 embeddedobj/source/inc/oleembobj.hxx:144
@@ -296,6 +292,14 @@ extensions/source/propctrlr/genericpropertyhandler.hxx:63
     pcr::GenericPropertyHandler m_xComponentIntrospectionAccess css::uno::Reference<css::beans::XIntrospectionAccess>
 extensions/source/scanner/scanner.hxx:48
     ScannerManager mpData void *
+fpicker/source/office/autocmpledit.hxx:24
+    AutocompleteEdit m_nCurrent std::vector<class OUString>::size_type
+fpicker/source/office/PlacesListBox.hxx:36
+    PlacesListBox mbSelectionChanged _Bool
+fpicker/source/office/RemoteFilesDialog.hxx:113
+    RemoteFilesDialog m_nWidth int
+fpicker/source/office/RemoteFilesDialog.hxx:114
+    RemoteFilesDialog m_nHeight int
 framework/inc/services/layoutmanager.hxx:259
     framework::LayoutManager m_bGlobalSettings _Bool
 framework/inc/services/layoutmanager.hxx:273
@@ -396,23 +400,19 @@ include/svtools/brwbox.hxx:249
     BrowseBox::CursorMoveAttempt m_bScrolledToReachCell const _Bool
 include/svtools/ctrltool.hxx:150
     FontList mpDev2 VclPtr<class OutputDevice>
-include/svx/bmpmask.hxx:127
+include/svx/bmpmask.hxx:125
     SvxBmpMask aSelItem class SvxBmpMaskSelectItem
 include/svx/float3d.hxx:171
     Svx3DWin pControllerItem std::unique_ptr<Svx3DCtrlItem>
 include/svx/fmtools.hxx:134
     FmXDisposeListener m_pAdapter rtl::Reference<FmXDisposeMultiplexer>
-include/svx/gridctrl.hxx:255
+include/svx/gridctrl.hxx:254
     DbGridControl m_pCursorDisposeListener std::unique_ptr<DisposeListenerGridBridge>
-include/svx/langbox.hxx:71
-    SvxLanguageBoxBase m_aNotCheckedImage class Image
-include/svx/langbox.hxx:72
-    SvxLanguageBoxBase m_aCheckedImage class Image
 include/svx/ofaitem.hxx:44
     OfaRefItem mxRef rtl::Reference<reference_type>
-include/svx/srchdlg.hxx:162
-    SvxSearchDialog pSearchController std::unique_ptr<SvxSearchController>
 include/svx/srchdlg.hxx:163
+    SvxSearchDialog pSearchController std::unique_ptr<SvxSearchController>
+include/svx/srchdlg.hxx:164
     SvxSearchDialog pOptionsController std::unique_ptr<SvxSearchController>
 include/svx/viewpt3d.hxx:62
     Viewport3D::(anonymous) H double
@@ -438,11 +438,11 @@ include/vcl/opengl/OpenGLContext.hxx:32
     GLWindow bMultiSampleSupported _Bool
 include/vcl/pdfextoutdevdata.hxx:83
     vcl::PDFExtOutDevData mbSinglePageSheets _Bool
-include/vcl/salnativewidgets.hxx:469
+include/vcl/salnativewidgets.hxx:467
     ToolbarValue mbIsTopDockingArea _Bool
-include/vcl/salnativewidgets.hxx:534
+include/vcl/salnativewidgets.hxx:532
     PushButtonValue mbBevelButton _Bool
-include/vcl/salnativewidgets.hxx:535
+include/vcl/salnativewidgets.hxx:533
     PushButtonValue mbSingleLine _Bool
 include/vcl/sysdata.hxx:69
     SystemEnvData pSalFrame void *
@@ -490,11 +490,11 @@ registry/source/reflread.cxx:466
     ConstantPool::readDoubleConstant(sal_uInt16)::(anonymous union)::(anonymous) b2 sal_uInt32
 reportdesign/inc/RptObject.hxx:72
     rptui::OObjectBase m_xKeepShapeAlive css::uno::Reference<css::uno::XInterface>
-sal/qa/osl/file/osl_File.cxx:4154
+sal/qa/osl/file/osl_File.cxx:4156
     osl_Directory::isOpen nError1 osl::class FileBase::RC
-sal/qa/osl/file/osl_File.cxx:4154
+sal/qa/osl/file/osl_File.cxx:4156
     osl_Directory::isOpen nError2 osl::class FileBase::RC
-sal/qa/osl/file/osl_File.cxx:4212
+sal/qa/osl/file/osl_File.cxx:4214
     osl_Directory::close nError2 osl::class FileBase::RC
 sal/rtl/alloc_arena.hxx:35
     rtl_arena_stat_type m_mem_total sal_Size
@@ -518,11 +518,11 @@ sal/textenc/tcvtutf7.cxx:416
     ImplUTF7FromUCContextData mnBitBuffer sal_uInt32
 sal/textenc/tcvtutf7.cxx:417
     ImplUTF7FromUCContextData mnBufferBits sal_uInt32
-sc/inc/compiler.hxx:256
+sc/inc/compiler.hxx:258
     ScCompiler::AddInMap pODFF const char *
-sc/inc/compiler.hxx:257
-    ScCompiler::AddInMap pEnglish const char *
 sc/inc/compiler.hxx:259
+    ScCompiler::AddInMap pEnglish const char *
+sc/inc/compiler.hxx:261
     ScCompiler::AddInMap pUpper const char *
 sc/inc/document.hxx:2592
     ScMutationDisable mpDocument class ScDocument *
@@ -538,9 +538,9 @@ sc/inc/tabopparams.hxx:38
     ScInterpreterTableOpParams bValid _Bool
 sc/source/core/data/column4.cxx:1308
     (anonymous namespace)::StartListeningFormulaCellsHandler mnStartRow SCROW
-sc/source/core/data/column.cxx:1397
-    (anonymous namespace)::CopyByCloneHandler meListenType sc::StartListeningType
 sc/source/core/data/column.cxx:1398
+    (anonymous namespace)::CopyByCloneHandler meListenType sc::StartListeningType
+sc/source/core/data/column.cxx:1399
     (anonymous namespace)::CopyByCloneHandler mnFormulaCellCloneFlags const enum ScCloneFlags
 sc/source/core/data/table2.cxx:3664
     (anonymous namespace)::OutlineArrayFinder mpArray class ScOutlineArray *
@@ -652,7 +652,7 @@ sd/source/ui/remotecontrol/Receiver.hxx:35
     sd::Receiver pTransmitter class sd::Transmitter *
 sd/source/ui/sidebar/MasterPageContainerProviders.hxx:136
     sd::sidebar::TemplatePreviewProvider msURL const class rtl::OUString
-sd/source/ui/sidebar/SlideBackground.hxx:93
+sd/source/ui/sidebar/SlideBackground.hxx:94
     sd::sidebar::SlideBackground m_pContainer VclPtr<class VclVBox>
 sd/source/ui/slideshow/slideshowimpl.hxx:333
     sd::SlideshowImpl mpPaneHider ::std::unique_ptr<PaneHider>
@@ -666,7 +666,7 @@ sd/source/ui/view/ToolBarManager.cxx:315
     sd::ToolBarManager::Implementation mpAsynchronousLayouterLock ::std::unique_ptr<LayouterLock>
 sdext/source/presenter/PresenterTimer.cxx:106
     sdext::presenter::(anonymous namespace)::TimerScheduler mpLateDestroy std::shared_ptr<TimerScheduler>
-sfx2/source/appl/fileobj.hxx:37
+sfx2/source/appl/fileobj.hxx:38
     SvFileObject mxDelMed tools::SvRef<SfxMedium>
 sfx2/source/doc/sfxbasemodel.cxx:449
     SfxSaveGuard m_pFramesLock std::unique_ptr<SfxOwnFramesLocker>
@@ -780,7 +780,7 @@ svx/source/svdraw/svdibrow.cxx:95
     ImpItemListRow pType const std::type_info *
 svx/source/svdraw/svdpdf.hxx:196
     ImpSdrPdfImport mdPageWidthPts double
-svx/source/tbxctrls/tbcontrl.cxx:197
+svx/source/tbxctrls/tbcontrl.cxx:199
     SvxFontNameBox_Impl m_aOwnFontList ::std::unique_ptr<FontList>
 sw/inc/accmap.hxx:96
     SwAccessibleMap mvShapes SwShapeList_Impl
@@ -842,7 +842,7 @@ ucb/source/ucp/gio/gio_mount.hxx:79
     OOoMountOperationClass _gtk_reserved3 void (*)(void)
 ucb/source/ucp/gio/gio_mount.hxx:80
     OOoMountOperationClass _gtk_reserved4 void (*)(void)
-ucb/source/ucp/webdav-neon/NeonSession.cxx:160
+ucb/source/ucp/webdav-neon/NeonSession.cxx:157
     NeonRequestContext pResource struct webdav_ucp::DAVResource *
 unoidl/source/legacyprovider.cxx:86
     unoidl::detail::(anonymous namespace)::Cursor manager_ rtl::Reference<Manager>
@@ -1016,21 +1016,21 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:47
     AtkObjectWrapper aParent const AtkObject
 vcl/unx/gtk3/a11y/atkwrapper.hxx:75
     AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
-vcl/unx/gtk3/a11y/gtk3atkutil.cxx:142
+vcl/unx/gtk3/a11y/gtk3atkutil.cxx:138
     DocumentFocusListener m_aRefList std::set<uno::Reference<uno::XInterface> >
-vcl/unx/gtk3/gtk3gloactiongroup.cxx:28
+vcl/unx/gtk3/gtk3gloactiongroup.cxx:26
     GLOAction parent_instance GObject
-vcl/unx/gtk3/gtk3glomenu.cxx:17
+vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
 vcl/unx/gtk3/gtk3gtkinst.cxx:1596
      in char *
-vcl/unx/gtk3/gtk3hudawareness.cxx:17
+vcl/unx/gtk3/gtk3hudawareness.cxx:16
     HudAwarenessHandle connection GDBusConnection *
-vcl/unx/gtk3/gtk3hudawareness.cxx:20
+vcl/unx/gtk3/gtk3hudawareness.cxx:19
     HudAwarenessHandle notify GDestroyNotify
 vcl/workben/vcldemo.cxx:1744
     DemoWin mxThread rtl::Reference<RenderThread>
-writerfilter/source/dmapper/PropertyMap.hxx:198
+writerfilter/source/dmapper/PropertyMap.hxx:204
     writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
 writerfilter/source/dmapper/SettingsTable.cxx:253
     writerfilter::dmapper::SettingsTable_Impl m_sRedlineProtectionKey class rtl::OUString
diff --git a/fpicker/source/office/PlacesListBox.cxx b/fpicker/source/office/PlacesListBox.cxx
index da03c0f704fb..da3e304dce3e 100644
--- a/fpicker/source/office/PlacesListBox.cxx
+++ b/fpicker/source/office/PlacesListBox.cxx
@@ -24,7 +24,6 @@ PlacesListBox::PlacesListBox(std::unique_ptr<weld::TreeView> xControl,
     , mxDelBtn(std::move(xDel))
     , mnNbEditables(0)
     , mbUpdated( false )
-    , mbSelectionChanged( false )
 {
     Size aSize(mxImpl->get_approximate_digit_width() * 18,
                mxImpl->get_height_rows(9));
@@ -103,7 +102,6 @@ IMPL_LINK_NOARG( PlacesListBox, Selection, weld::TreeView&, void )
     sal_uInt32 nSelected = mxImpl->get_cursor_index();
     PlacePtr pPlace = maPlaces[nSelected];
 
-    mbSelectionChanged = true;
     if (pPlace->IsEditable())
         mpDlg->RemovablePlaceSelected();
     else
diff --git a/fpicker/source/office/PlacesListBox.hxx b/fpicker/source/office/PlacesListBox.hxx
index 151a0d1d4a01..70484cc495c4 100644
--- a/fpicker/source/office/PlacesListBox.hxx
+++ b/fpicker/source/office/PlacesListBox.hxx
@@ -33,7 +33,6 @@ private:
     std::unique_ptr<weld::Button> mxDelBtn;
     sal_Int32            mnNbEditables;
     bool                 mbUpdated;
-    bool                 mbSelectionChanged;
 
 public:
     PlacesListBox(std::unique_ptr<weld::TreeView> xTreeView,
diff --git a/fpicker/source/office/RemoteFilesDialog.cxx b/fpicker/source/office/RemoteFilesDialog.cxx
index 02a3ef2bec2b..b0739b49e95c 100644
--- a/fpicker/source/office/RemoteFilesDialog.cxx
+++ b/fpicker/source/office/RemoteFilesDialog.cxx
@@ -30,8 +30,6 @@ RemoteFilesDialog::RemoteFilesDialog( weld::Window* pParent, PickerFlags nBits )
     : SvtFileDialog_Base( pParent, "fps/ui/remotefilesdialog.ui", "RemoteFilesDialog" )
     , m_xContext( comphelper::getProcessComponentContext() )
     , m_xMasterPasswd( PasswordContainer::create( m_xContext ) )
-    , m_nWidth( 0 )
-    , m_nHeight( 0 )
     , m_bIsInExecute( false )
     , m_xCancel_btn(m_xBuilder->weld_button("cancel"))
     , m_xAddService_bar(m_xBuilder->weld_toolbar("add_service_bar"))
@@ -245,8 +243,6 @@ void RemoteFilesDialog::InitSize()
             sal_Int32 nPos2{ sCfgStr.indexOf('|', nPos1+1 ) };
             if (nPos2<0)
                 return;
-            m_nWidth = sCfgStr.copy(0, nPos1++).toInt32();
-            m_nHeight = sCfgStr.copy(nPos1, nPos2-nPos1).toInt32();
             m_xFileView->SetConfigString( sCfgStr.copy(nPos2+1) );
         }
     }
diff --git a/fpicker/source/office/RemoteFilesDialog.hxx b/fpicker/source/office/RemoteFilesDialog.hxx
index b22fb1fd55ac..9972c69d1afd 100644
--- a/fpicker/source/office/RemoteFilesDialog.hxx
+++ b/fpicker/source/office/RemoteFilesDialog.hxx
@@ -110,8 +110,6 @@ private:
     bool m_bServiceChanged;
 
     OUString m_sIniKey;
-    int m_nWidth;
-    int m_nHeight;
 
     bool m_bIsInExecute;
 
diff --git a/fpicker/source/office/autocmpledit.cxx b/fpicker/source/office/autocmpledit.cxx
index 57da4f4e5444..ab7887fff612 100644
--- a/fpicker/source/office/autocmpledit.cxx
+++ b/fpicker/source/office/autocmpledit.cxx
@@ -13,7 +13,6 @@
 
 AutocompleteEdit::AutocompleteEdit(std::unique_ptr<weld::Entry> xEntry)
     : m_xEntry(std::move(xEntry))
-    , m_nCurrent(0)
 {
     m_xEntry->connect_changed(LINK(this, AutocompleteEdit, ChangedHdl));
 
@@ -56,7 +55,6 @@ IMPL_LINK_NOARG(AutocompleteEdit, TryAutoComplete, Timer *, void)
     {
         if( Match( aCurText ) )
         {
-            m_nCurrent = 0;
             m_xEntry->set_text(m_aMatching[0]);
             auto nNewLen = m_aMatching[0].getLength();
             m_xEntry->select_region(nLen, nNewLen);
diff --git a/fpicker/source/office/autocmpledit.hxx b/fpicker/source/office/autocmpledit.hxx
index 03e05bf559a2..fc1108e383c2 100644
--- a/fpicker/source/office/autocmpledit.hxx
+++ b/fpicker/source/office/autocmpledit.hxx
@@ -21,7 +21,6 @@ private:
 
     std::vector< OUString > m_aEntries;
     std::vector< OUString > m_aMatching;
-    std::vector< OUString >::size_type m_nCurrent;
     Idle m_aChangedIdle;
     Link<weld::Entry&, void> m_aChangeHdl;
 
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index d67eb85a4d5e..0c27f803ca2a 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -9778,8 +9778,6 @@ class GtkInstanceIconView : public GtkInstanceContainer, public virtual weld::Ic
 private:
     GtkIconView* m_pIconView;
     GtkTreeStore* m_pTreeStore;
-    std::vector<int> m_aViewColToModelCol;
-    std::vector<int> m_aModelColToViewCol;
     gint m_nTextCol;
     gint m_nImageCol;
     gint m_nIdCol;


More information about the Libreoffice-commits mailing list