[Libreoffice-commits] core.git: compilerplugins/clang include/vcl vcl/source vcl/unx

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Thu Nov 7 12:10:40 UTC 2019


 compilerplugins/clang/unusedmethods.results |    2 --
 include/vcl/weld.hxx                        |    1 -
 vcl/source/app/salvtables.cxx               |    7 -------
 vcl/unx/gtk3/gtk3gtkinst.cxx                |   25 -------------------------
 4 files changed, 35 deletions(-)

New commits:
commit 2b635e6de85a9364ec9159a0d827de40bff4a0b9
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Nov 7 09:37:03 2019 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Nov 7 13:09:57 2019 +0100

    drop unused TreeView::set_top_entry
    
    Change-Id: I70171b95baf29486c253e7d388ba59385da1d929
    Reviewed-on: https://gerrit.libreoffice.org/82196
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results
index 0968a260a960..43e1c9acf25d 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -866,8 +866,6 @@ include/vcl/weld.hxx:748
     void weld::TreeView::append(const class weld::TreeIter *,const class rtl::OUString &,const class rtl::OUString &,const class rtl::OUString &)
 include/vcl/weld.hxx:757
     void weld::TreeView::append(const class rtl::OUString &,const class rtl::OUString &,class VirtualDevice &)
-include/vcl/weld.hxx:803
-    void weld::TreeView::set_top_entry(int)
 include/vcl/weld.hxx:941
     void weld::TreeView::select_all()
 include/vcl/weld.hxx:985
diff --git a/include/vcl/weld.hxx b/include/vcl/weld.hxx
index ac926469c60e..a6f38da05ec7 100644
--- a/include/vcl/weld.hxx
+++ b/include/vcl/weld.hxx
@@ -800,7 +800,6 @@ public:
         = 0;
     virtual void set_text_emphasis(int row, bool bOn, int col) = 0;
     virtual bool get_text_emphasis(int row, int col) const = 0;
-    virtual void set_top_entry(int pos) = 0;
     virtual void swap(int pos1, int pos2) = 0;
     virtual std::vector<int> get_selected_rows() const = 0;
     virtual void set_font_color(int pos, const Color& rColor) const = 0;
diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index bd367355eb62..327853bba1d1 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -3637,13 +3637,6 @@ public:
         return -1;
     }
 
-    virtual void set_top_entry(int pos) override
-    {
-        SvTreeList* pModel = m_xTreeView->GetModel();
-        SvTreeListEntry* pEntry = pModel->GetEntry(nullptr, pos);
-        pModel->Move(pEntry, nullptr, 0);
-    }
-
     virtual void swap(int pos1, int pos2) override
     {
         SvTreeList* pModel = m_xTreeView->GetModel();
diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 0c27f803ca2a..e813b9cb7d89 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -8524,31 +8524,6 @@ public:
         thaw();
     }
 
-    void move_before(int pos, int before)
-    {
-        if (pos == before)
-            return;
-
-        GtkTreeModel *pModel = GTK_TREE_MODEL(m_pTreeStore);
-
-        disable_notify_events();
-        GtkTreeIter iter;
-        gtk_tree_model_iter_nth_child(pModel, &iter, nullptr, pos);
-
-        GtkTreeIter position;
-        gtk_tree_model_iter_nth_child(pModel, &position, nullptr, before);
-
-        gtk_tree_store_move_before(m_pTreeStore, &iter, &position);
-        enable_notify_events();
-    }
-
-    virtual void set_top_entry(int pos) override
-    {
-        disable_notify_events();
-        move_before(pos, 0);
-        enable_notify_events();
-    }
-
     virtual void swap(int pos1, int pos2) override
     {
         disable_notify_events();


More information about the Libreoffice-commits mailing list