[Libreoffice-commits] core.git: Branch 'feature/cib_contract3756' - basctl/source

[Samuel Mehrbrodt (via logerrit)]

 basctl/source/basicide/baside2.cxx |   14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

New commits:
commit f80a9b61d4acaefa27bc5994b8250b5895a960c5
Author:     Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
AuthorDate: Thu Nov 7 16:01:32 2019 +0100
Commit:     Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
CommitDate: Fri Nov 8 09:03:43 2019 +0100

    Always check whether macro execution is allowed
    
    No only when this executing from a document.
    
    Setting 'DisableMacrosExecution' had no effect on the macro editor,
    macros could still be executed there.
    
    Change-Id: I400ed25050173d2ce1fb612aebd2dbcb73720a73
    Reviewed-on: https://gerrit.libreoffice.org/82229
    Tested-by: Jenkins
    Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
    (cherry picked from commit 8d69ca60f3c8f53699986f924291a2acda5694a1)
    Reviewed-on: https://gerrit.libreoffice.org/82238
    Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>

diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index 7e0dc2b0288d..e8bac4aa19af 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -303,15 +303,13 @@ void ModulWindow::BasicExecute()
 {
     // #116444# check security settings before macro execution
     ScriptDocument aDocument( GetDocument() );
-    if ( aDocument.isDocument() )
+    if (!aDocument.allowMacros())
     {
-        if ( !aDocument.allowMacros() )
-        {
-            std::unique_ptr<weld::MessageDialog> xBox(Application::CreateMessageDialog(GetFrameWeld(),
-                                                      VclMessageType::Warning, VclButtonsType::Ok, IDEResId(RID_STR_CANNOTRUNMACRO)));
-            xBox->run();
-            return;
-        }
+        std::unique_ptr<weld::MessageDialog> xBox(
+            Application::CreateMessageDialog(GetFrameWeld(), VclMessageType::Warning,
+                                             VclButtonsType::Ok, IDEResId(RID_STR_CANNOTRUNMACRO)));
+        xBox->run();
+        return;
     }
 
     CheckCompileBasic();