[Libreoffice-commits] core.git: chart2/source

Muhammet Kara (via logerrit) logerrit at kemper.freedesktop.org
Sat Nov 9 12:03:35 UTC 2019


 chart2/source/view/main/ShapeFactory.cxx |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit cb413b1de64dfaddf38f347b2f53d28f3c8246c6
Author:     Muhammet Kara <muhammet.kara at collabora.com>
AuthorDate: Sat Nov 9 13:11:03 2019 +0300
Commit:     Muhammet Kara <muhammet.kara at collabora.com>
CommitDate: Sat Nov 9 13:02:34 2019 +0100

    Don't call setPropertyValue with empty value
    
    Change-Id: I3dd2525e5649cf71b47c2733db4d121625b33342
    Reviewed-on: https://gerrit.libreoffice.org/82348
    Tested-by: Jenkins
    Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>

diff --git a/chart2/source/view/main/ShapeFactory.cxx b/chart2/source/view/main/ShapeFactory.cxx
index 3bcd72ff2904..f6219c650151 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -2154,7 +2154,11 @@ uno::Reference< drawing::XShape >
         //the matrix needs to be set at the end behind autogrow and such position influencing properties
         try
         {
-            xProp->setPropertyValue( "Transformation", rATransformation );
+            if (rATransformation.hasValue())
+                xProp->setPropertyValue( "Transformation", rATransformation );
+            else
+                SAL_INFO("chart2", "No rATransformation value is given to ShapeFactory::createText()");
+
         }
         catch( const uno::Exception& )
         {


More information about the Libreoffice-commits mailing list