[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-6.2' - chart2/source

Muhammet Kara (via logerrit) logerrit at kemper.freedesktop.org
Sat Nov 9 12:03:35 UTC 2019


 chart2/source/view/main/ShapeFactory.cxx |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit 24f8537bf8af516e5cb143126e1d3a089041d60a
Author:     Muhammet Kara <muhammet.kara at collabora.com>
AuthorDate: Sat Nov 9 13:11:03 2019 +0300
Commit:     Muhammet Kara <muhammet.kara at collabora.com>
CommitDate: Sat Nov 9 13:02:22 2019 +0100

    Don't call setPropertyValue with empty value
    
    Change-Id: I3dd2525e5649cf71b47c2733db4d121625b33342
    Reviewed-on: https://gerrit.libreoffice.org/82347
    Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice at gmail.com>
    Reviewed-by: Muhammet Kara <muhammet.kara at collabora.com>

diff --git a/chart2/source/view/main/ShapeFactory.cxx b/chart2/source/view/main/ShapeFactory.cxx
index 28f981635529..bc358243e2b0 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -2163,11 +2163,15 @@ uno::Reference< drawing::XShape >
         //the matrix needs to be set at the end behind autogrow and such position influencing properties
         try
         {
-            xProp->setPropertyValue( "Transformation", rATransformation );
+            if (rATransformation.hasValue())
+                xProp->setPropertyValue( "Transformation", rATransformation );
+            else
+                SAL_INFO("chart2", "No rATransformation value is given to ShapeFactory::createText()");
+
         }
         catch( const uno::Exception& e )
         {
-            SAL_WARN("chart2", "Exception caught. " << e );
+            SAL_WARN("chart2", "Exception caught. " << e.Message );
         }
     }
     return xShape;


More information about the Libreoffice-commits mailing list