[Libreoffice-commits] core.git: uui/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Tue Nov 12 13:51:37 UTC 2019


 uui/source/interactionhandler.cxx |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

New commits:
commit e2a081871aea244ec42d31ac9dc5d132e3b96483
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Nov 12 13:49:18 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Nov 12 14:50:25 2019 +0100

    Better throw RuntimeException than assert here
    
    (in case this functionality is ever discovered and called by external code)
    
    Change-Id: If127460f58e1d074a32f231385e2c54303e4f98c
    Reviewed-on: https://gerrit.libreoffice.org/82508
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/uui/source/interactionhandler.cxx b/uui/source/interactionhandler.cxx
index f90763e1e22e..cc5579fd1ed1 100644
--- a/uui/source/interactionhandler.cxx
+++ b/uui/source/interactionhandler.cxx
@@ -27,6 +27,7 @@
 #include <com/sun/star/lang/XInitialization.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 #include <com/sun/star/task/XInteractionHandler2.hpp>
+#include <com/sun/star/uno/RuntimeException.hpp>
 
 #include "iahndl.hxx"
 #include <comphelper/namedvaluecollection.hxx>
@@ -75,25 +76,29 @@ public:
     virtual void SAL_CALL
         addPropertyChangeListener( const OUString& /*aPropertyName*/, const css::uno::Reference< css::beans::XPropertyChangeListener >& /*xListener*/ ) override
     {
-        assert(false);
+        throw css::uno::RuntimeException(
+            "UUIInteractionHandler addPropertyChangeListener is not supported");
     }
 
     virtual void SAL_CALL
         removePropertyChangeListener( const OUString& /*aPropertyName*/, const css::uno::Reference< css::beans::XPropertyChangeListener >& /*xListener*/ ) override
     {
-        assert(false);
+        throw css::uno::RuntimeException(
+            "UUIInteractionHandler removePropertyChangeListener is not supported");
     }
 
     virtual void SAL_CALL
         addVetoableChangeListener( const OUString& /*aPropertyName*/, const css::uno::Reference< css::beans::XVetoableChangeListener >& /*xListener*/ ) override
     {
-        assert(false);
+        throw css::uno::RuntimeException(
+            "UUIInteractionHandler addVetoableChangeListener is not supported");
     }
 
     virtual void SAL_CALL
         removeVetoableChangeListener( const OUString& /*aPropertyName*/, const css::uno::Reference< css::beans::XVetoableChangeListener >& /*xListener*/ ) override
     {
-        assert(false);
+        throw css::uno::RuntimeException(
+            "UUIInteractionHandler removeVetoableChangeListener is not supported");
     }
 
     virtual css::uno::Reference< css::beans::XPropertySetInfo > SAL_CALL


More information about the Libreoffice-commits mailing list