[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Nov 14 12:30:08 UTC 2019


 compilerplugins/clang/sharedvisitor/generator.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 281d493fd901c828ba7b41cccf4f624b0633943a
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Nov 14 10:41:51 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Nov 14 13:29:05 2019 +0100

    Improve error message
    
    (When temporarily taking a plugin out of the shared plugin by modifying its
    leading
    
    > #ifndef LO_CLANG_SHARED_PLUGINS
    
    line I often forget about a trailing
    
    > #endif // LO_CLANG_SHARED_PLUGINS
    
    line, which then caused a hard to understand
    
    > [GEN] compilerplugins/clang/sharedvisitor/sharedvisitor.cxx
    > Incorrect version ''
    
    failure.  This way, at least somehow mention the name of the problematic plugin
    to give a bit of a clue.)
    
    Change-Id: I9a9178ba0d7a32f448e91076376989f088ea70f8
    Reviewed-on: https://gerrit.libreoffice.org/82657
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/compilerplugins/clang/sharedvisitor/generator.cxx b/compilerplugins/clang/sharedvisitor/generator.cxx
index bf8cfb601264..38e6527a7bb3 100644
--- a/compilerplugins/clang/sharedvisitor/generator.cxx
+++ b/compilerplugins/clang/sharedvisitor/generator.cxx
@@ -335,7 +335,7 @@ static bool readFile( const string& fileName )
     string version = getValue( line, "InfoVersion" );
     if( version != "1" )
     {
-        cerr << "Incorrect version '" << version << "'" << endl;
+        cerr << "Incorrect version '" << version << "' in " << fileName << endl;
         return false;
     }
     getline( file, line );


More information about the Libreoffice-commits mailing list