[Libreoffice-commits] core.git: sw/source

[Szymon Kłos (via logerrit)]

 sw/source/uibase/shells/drwtxtex.cxx |   19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

New commits:
commit 77cc0e929ee331af6b97b65e9b6ec5400ef05cd4
Author:     Szymon Kłos <szymon.klos at collabora.com>
AuthorDate: Thu Nov 14 11:16:04 2019 +0100
Commit:     Szymon Kłos <szymon.klos at collabora.com>
CommitDate: Thu Nov 14 21:36:05 2019 +0100

    jsdialogs: fix CID 1455691 & CID 1455690
    
    Change-Id: Idbb3e70c1a09be7dd7c43747250f3a6368251cd9
    Reviewed-on: https://gerrit.libreoffice.org/82662
    Tested-by: Jenkins
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>

diff --git a/sw/source/uibase/shells/drwtxtex.cxx b/sw/source/uibase/shells/drwtxtex.cxx
index 05f9125c6ec1..ae7af539ad73 100644
--- a/sw/source/uibase/shells/drwtxtex.cxx
+++ b/sw/source/uibase/shells/drwtxtex.cxx
@@ -653,16 +653,19 @@ void SwDrawTextShell::Execute( SfxRequest &rReq )
             return;
     }
 
-    std::unique_ptr<SfxItemSet> pNewArgs = pNewAttrs->Clone();
-    lcl_convertStringArguments(nSlot, pNewArgs);
-
-    if(nEEWhich && pNewAttrs)
+    std::unique_ptr<SfxItemSet> pNewArgs = pNewAttrs ? pNewAttrs->Clone() : nullptr;
+    if (pNewArgs)
     {
-        std::unique_ptr<SfxPoolItem> pNewItem(pNewArgs->Get(nWhich).CloneSetWhich(nEEWhich));
-        pNewArgs->Put(*pNewItem);
-    }
+        lcl_convertStringArguments(nSlot, pNewArgs);
+
+        if (nEEWhich)
+        {
+            std::unique_ptr<SfxPoolItem> pNewItem(pNewArgs->Get(nWhich).CloneSetWhich(nEEWhich));
+            pNewArgs->Put(*pNewItem);
+        }
 
-    SetAttrToMarked(*pNewArgs);
+        SetAttrToMarked(*pNewArgs);
+    }
 
     GetView().GetViewFrame()->GetBindings().InvalidateAll(false);