[Libreoffice-commits] core.git: svx/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Mon Nov 18 09:56:57 UTC 2019


 svx/source/xml/xmlxtimp.cxx |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

New commits:
commit ba637bbbd65d71a3956d56f04ce2703b51479700
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Nov 18 10:53:09 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Nov 18 10:55:55 2019 +0100

    use FasterParser for SvxXMLXTableImport::load
    
    the SvXMLImport superclass of XMLVersionListImport already constructs a
    parser, so we can just use that one
    
    Change-Id: I28402467f63e166a2c5ffc3bf0c851de81ba2108
    Reviewed-on: https://gerrit.libreoffice.org/83061
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svx/source/xml/xmlxtimp.cxx b/svx/source/xml/xmlxtimp.cxx
index 4fbed121ddc5..bb2c67e39475 100644
--- a/svx/source/xml/xmlxtimp.cxx
+++ b/svx/source/xml/xmlxtimp.cxx
@@ -22,7 +22,6 @@
 #include <com/sun/star/embed/ElementModes.hpp>
 #include <com/sun/star/io/XActiveDataControl.hpp>
 #include <com/sun/star/io/XActiveDataSource.hpp>
-#include <com/sun/star/xml/sax/Parser.hpp>
 #include <com/sun/star/container/XNameContainer.hpp>
 #include <com/sun/star/xml/sax/XDocumentHandler.hpp>
 #include <com/sun/star/drawing/PolyPolygonBezierCoords.hpp>
@@ -347,8 +346,6 @@ bool SvxXMLXTableImport::load( const OUString &rPath, const OUString &rReferer,
     {
         uno::Reference<uno::XComponentContext> xContext( ::comphelper::getProcessComponentContext() );
 
-        uno::Reference< xml::sax::XParser > xParser = xml::sax::Parser::create( xContext );
-
         xml::sax::InputSource aParserInput;
         comphelper::LifecycleProxy aNasty;
 
@@ -403,9 +400,8 @@ bool SvxXMLXTableImport::load( const OUString &rPath, const OUString &rReferer,
         {
         }
 
-        uno::Reference<XDocumentHandler> xHandler(new SvxXMLXTableImport(xContext, xTable, xGraphicStorageHandler));
-        xParser->setDocumentHandler( xHandler );
-        xParser->parseStream( aParserInput );
+        rtl::Reference<SvxXMLXTableImport> xImport(new SvxXMLXTableImport(xContext, xTable, xGraphicStorageHandler));
+        xImport->parseStream( aParserInput );
 
         if( xGraphicHelper )
             xGraphicHelper->dispose();


More information about the Libreoffice-commits mailing list