[Libreoffice-commits] core.git: embedserv/source
Stephan Bergmann (via logerrit)
logerrit at kemper.freedesktop.org
Tue Nov 19 17:30:08 UTC 2019
embedserv/source/embed/syswinwrapper.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 5413dcbc6ce27467b81e84a523aaa25fae4db686
Author: Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Nov 19 15:21:44 2019 +0100
Commit: Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Nov 19 18:28:55 2019 +0100
loplugin:fakebool (clang-cl)
"conversion from 'ATOM' (aka 'unsigned short') to 'BOOL' (aka 'int')"; if the
BOOL return value of winwrap::HatchWindowRegister hasn't been used in bad ways
in the past, this should have been safe in the past, converting from smaller
ATOM to larger BOOL
Change-Id: I836aee56384a01ef0d959ecc5dbebc923acb642b
Reviewed-on: https://gerrit.libreoffice.org/83209
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
diff --git a/embedserv/source/embed/syswinwrapper.cxx b/embedserv/source/embed/syswinwrapper.cxx
index 4c86532be5e8..7024a054c0b5 100644
--- a/embedserv/source/embed/syswinwrapper.cxx
+++ b/embedserv/source/embed/syswinwrapper.cxx
@@ -117,7 +117,7 @@ BOOL winwrap::HatchWindowRegister(HINSTANCE hInst)
wc.lpszMenuName = nullptr;
wc.lpszClassName = SZCLASSHATCHWIN;
- return RegisterClassW(&wc);
+ return RegisterClassW(&wc) != 0;
}
More information about the Libreoffice-commits
mailing list