[Libreoffice-commits] core.git: sw/source

[Julien Nabet (via logerrit)]

 sw/source/core/text/portxt.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 8a82100c8274d3c0e6d8386116fe8c48543fc4c3
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Tue Nov 19 20:05:52 2019 +0100
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Wed Nov 20 09:13:54 2019 +0100

    Comment some code which resembles a wrong copypaste (sw/portxt)
    
    Thank you Miklos and Michael S!
    
    Change-Id: Ia24e2b9d39d919c26be3c7a5c38f9de875aad2e5
    Reviewed-on: https://gerrit.libreoffice.org/83228
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/sw/source/core/text/portxt.cxx b/sw/source/core/text/portxt.cxx
index 0460cb343dd3..3a0ddd46d068 100644
--- a/sw/source/core/text/portxt.cxx
+++ b/sw/source/core/text/portxt.cxx
@@ -814,6 +814,10 @@ bool SwFieldFormCheckboxPortion::Format( SwTextFormatInfo & rInf )
     OSL_ENSURE(pBM && pBM->GetFieldname( ) == ODF_FORMCHECKBOX, "Where is my form field bookmark???");
     if (pBM && pBM->GetFieldname( ) == ODF_FORMCHECKBOX)
     {
+        // the width of the checkbox portion is the same as its height since it's a square
+        // and that size depends on the font size.
+        // See:
+        // http://document-foundation-mail-archive.969070.n3.nabble.com/Wrong-copy-paste-in-SwFieldFormCheckboxPortion-Format-td4269112.html
         Width( rInf.GetTextHeight(  ) );
         Height( rInf.GetTextHeight(  ) );
         SetAscent( rInf.GetAscent(  ) );