[Libreoffice-commits] core.git: accessibility/source compilerplugins/clang include/sfx2 include/vcl libreofficekit/qa sfx2/source svtools/source vcl/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Thu Nov 21 17:29:27 UTC 2019


 accessibility/source/extended/accessibletablistboxtable.cxx         |    4 
 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   44 ++++----
 compilerplugins/clang/unusedfields.readonly.results                 |   28 ++---
 compilerplugins/clang/unusedfields.untouched.results                |   52 +++++-----
 compilerplugins/clang/unusedfields.writeonly.results                |   32 ++----
 include/sfx2/prnmon.hxx                                             |    2 
 include/vcl/svtabbx.hxx                                             |   10 -
 include/vcl/vclevent.hxx                                            |    1 
 libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx         |    1 
 sfx2/source/view/printer.cxx                                        |   12 --
 svtools/source/control/inettbc.cxx                                  |    7 -
 vcl/source/treelist/svtabbx.cxx                                     |    4 
 12 files changed, 81 insertions(+), 116 deletions(-)

New commits:
commit b07b192720702ff1f0385b6c6a521117f93b7038
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Wed Nov 20 19:10:49 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Nov 21 18:27:56 2019 +0100

    loplugin:unusedfields
    
    Change-Id: Ic4cb8444123864fdaee64960f00a05b3066ae5fc
    Reviewed-on: https://gerrit.libreoffice.org/83387
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/accessibility/source/extended/accessibletablistboxtable.cxx b/accessibility/source/extended/accessibletablistboxtable.cxx
index 0ae2fa008a92..e0e3ca23ebc4 100644
--- a/accessibility/source/extended/accessibletablistboxtable.cxx
+++ b/accessibility/source/extended/accessibletablistboxtable.cxx
@@ -192,10 +192,6 @@ namespace accessibility
                     break;
                 }
 
-                case VclEventId::TableCellNameChanged :
-                {
-                    break;
-                }
                 default: break;
             }
         }
diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index 3e98bea722c3..097ab09ea836 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -128,7 +128,7 @@ cppu/source/uno/check.cxx:134
     (anonymous namespace)::Char3 c3 char
 cppu/source/uno/check.cxx:138
     (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
-cui/source/dialogs/colorpicker.cxx:710
+cui/source/dialogs/colorpicker.cxx:723
     cui::ColorPickerDialog m_aColorPrevious class cui::ColorPreviewControl
 cui/source/factory/dlgfact.cxx:1392
     SvxMacroAssignDialog m_aItems class SfxItemSet
@@ -360,10 +360,16 @@ include/vcl/NotebookBarAddonsMerger.hxx:45
     AddonsParams sControlType class rtl::OUString
 include/vcl/NotebookBarAddonsMerger.hxx:46
     AddonsParams nWidth sal_uInt16
+include/vcl/svtabbx.hxx:40
+    TabListBoxEventData m_pEntry class SvTreeListEntry *const
+include/vcl/svtabbx.hxx:41
+    TabListBoxEventData m_nColumn const sal_uInt16
+include/vcl/svtabbx.hxx:42
+    TabListBoxEventData m_sOldText const class rtl::OUString
 include/xmloff/shapeimport.hxx:140
     SdXML3DLightContext mbSpecular _Bool
-libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:35
-    GtvApplicationWindowPrivate lokDialog GtkWidget *
+libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:37
+    (anonymous namespace)::GtvApplicationWindowPrivate lokDialog GtkWidget *
 libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:52
     GtvApplicationWindow parent_instance GtkApplicationWindow
 libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:56
@@ -446,23 +452,23 @@ sal/osl/unx/thread.cxx:95
     osl_thread_priority_st m_Lowest int
 sal/osl/unx/thread.cxx:113
     osl_thread_global_st m_priority struct osl_thread_priority_st
-sal/qa/osl/condition/osl_Condition.cxx:68
+sal/qa/osl/condition/osl_Condition.cxx:72
     osl_Condition::ctors bRes1 _Bool
-sal/qa/osl/condition/osl_Condition.cxx:198
+sal/qa/osl/condition/osl_Condition.cxx:202
     osl_Condition::wait bRes2 _Bool
-sal/qa/osl/condition/osl_Condition.cxx:269
+sal/qa/osl/condition/osl_Condition.cxx:273
     osl_Condition::check bRes2 _Bool
-sal/qa/osl/file/osl_File.cxx:1586
+sal/qa/osl/file/osl_File.cxx:1590
     osl_FileStatus::getFileType m_aVolumeItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1586
+sal/qa/osl/file/osl_File.cxx:1590
     osl_FileStatus::getFileType m_aFifoItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1587
+sal/qa/osl/file/osl_File.cxx:1591
     osl_FileStatus::getFileType m_aLinkItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1587
+sal/qa/osl/file/osl_File.cxx:1591
     osl_FileStatus::getFileType m_aSocketItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1587
+sal/qa/osl/file/osl_File.cxx:1591
     osl_FileStatus::getFileType m_aSpecialItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:3419
+sal/qa/osl/file/osl_File.cxx:3423
     osl_File::setAttributes rItem_hidden class osl::DirectoryItem
 sal/qa/osl/module/osl_Module.cxx:67
     osl_Module::ctors bRes1 _Bool
@@ -508,8 +514,6 @@ sc/inc/compiler.hxx:259
     ScCompiler::AddInMap pEnglish const char *
 sc/inc/compiler.hxx:261
     ScCompiler::AddInMap pUpper const char *
-sc/inc/markmulti.hxx:38
-    ScMultiSel mnMaxCol SCCOL
 sc/inc/token.hxx:400
     SingleDoubleRefModifier aDub struct ScComplexRefData
 sc/qa/unit/ucalc_column.cxx:104
@@ -738,8 +742,8 @@ sw/inc/unosett.hxx:145
     SwXNumberingRules m_pImpl ::sw::UnoImplPtr<Impl>
 sw/qa/core/test_ToxTextGenerator.cxx:139
     ToxTextGeneratorWithMockedChapterField mChapterFieldType class SwChapterFieldType
-sw/qa/extras/layout/layout.cxx:2592
-      class SvtSysLocaleOptions &
+sw/qa/extras/uiwriter/uiwriter2.cxx:68
+      class SwUiWriterTest2 *
 sw/qa/extras/uiwriter/uiwriter.cxx:4069
     IdleTask maIdle class Idle
 sw/source/core/crsr/crbm.cxx:64
@@ -848,12 +852,12 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:75
     AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
 vcl/unx/gtk3/a11y/gtk3atkhypertext.cxx:29
     HyperLink atk_hyper_link const AtkHyperlink
-vcl/unx/gtk3/gtk3gloactiongroup.cxx:26
-    GLOAction parent_instance GObject
+vcl/unx/gtk3/gtk3gloactiongroup.cxx:27
+    (anonymous namespace)::GLOAction parent_instance GObject
 vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
-vcl/unx/gtk3/gtk3gtkinst.cxx:4831
-    CrippledViewport viewport GtkViewport
+vcl/unx/gtk3/gtk3gtkinst.cxx:4850
+    (anonymous namespace)::CrippledViewport viewport GtkViewport
 vcl/unx/kf5/KF5FilePicker.hxx:32
     KF5FilePicker _layout class QGridLayout *
 writerfilter/source/dmapper/PropertyMap.hxx:204
diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results
index 67a0daed6c32..52b982044abd 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -236,11 +236,11 @@ framework/inc/dispatch/dispatchprovider.hxx:77
     framework::DispatchProvider m_aProtocolHandlerCache class framework::HandlerCache
 framework/inc/helper/uiconfigelementwrapperbase.hxx:128
     framework::UIConfigElementWrapperBase m_bConfigListening _Bool
-framework/inc/xml/menudocumenthandler.hxx:132
+framework/inc/xml/menudocumenthandler.hxx:131
     framework::OReadMenuBarHandler m_bMenuMode _Bool
-framework/inc/xml/menudocumenthandler.hxx:159
+framework/inc/xml/menudocumenthandler.hxx:158
     framework::OReadMenuHandler m_bMenuPopupMode _Bool
-framework/inc/xml/menudocumenthandler.hxx:189
+framework/inc/xml/menudocumenthandler.hxx:188
     framework::OReadMenuPopupHandler m_bMenuMode _Bool
 framework/source/fwe/classes/addonsoptions.cxx:343
     framework::AddonsOptions_Impl m_aEmptyAddonToolBar Sequence<Sequence<struct com::sun::star::beans::PropertyValue> >
@@ -322,12 +322,6 @@ include/svl/ondemand.hxx:55
     OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale
 include/svtools/editsyntaxhighlighter.hxx:32
     MultiLineEditSyntaxHighlight m_aColorConfig const svtools::ColorConfig
-include/svtools/inettbc.hxx:40
-    SvtURLBox aBaseURL class rtl::OUString
-include/svtools/inettbc.hxx:46
-    SvtURLBox bOnlyDirectories _Bool
-include/svtools/inettbc.hxx:48
-    SvtURLBox bNoSelection _Bool
 include/svx/dialcontrol.hxx:112
     svx::DialControl::DialControl_Impl mnLinkedFieldValueMultiplyer sal_Int32
 include/svx/graphctl.hxx:52
@@ -390,8 +384,8 @@ io/source/stm/odata.cxx:571
     io_stm::ODataOutputStream::writeDouble(double)::(anonymous union)::(anonymous) n1 sal_uInt32
 libreofficekit/qa/gtktiledviewer/gtv-lok-dialog.cxx:51
     GtvLokDialogPrivate m_nChildKeyModifier guint32
-libreofficekit/source/gtk/lokdocview.cxx:84
-    LOKDocViewPrivateImpl m_bIsLoading gboolean
+libreofficekit/source/gtk/lokdocview.cxx:86
+    (anonymous namespace)::LOKDocViewPrivateImpl m_bIsLoading _Bool
 lingucomponent/source/languageguessing/simpleguesser.cxx:76
     textcat_t fprint void **
 lingucomponent/source/languageguessing/simpleguesser.cxx:78
@@ -550,6 +544,8 @@ svl/source/misc/strmadpt.cxx:51
     SvDataPipe_Impl::Page m_aBuffer sal_Int8 [1]
 svl/source/uno/pathservice.cxx:35
     PathService m_aOptions const class SvtPathOptions
+svtools/source/control/inettbc.cxx:94
+    SvtMatchContext_Impl aBaseURL const class rtl::OUString
 svtools/source/control/tabbar.cxx:200
     ImplTabBarItem maHelpId const class rtl::OString
 svtools/source/dialogs/insdlg.cxx:45
@@ -910,11 +906,11 @@ vcl/source/filter/jpeg/transupp.h:148
     (anonymous) crop_xoffset_set JCROP_CODE
 vcl/source/filter/jpeg/transupp.h:150
     (anonymous) crop_yoffset_set JCROP_CODE
-vcl/source/fontsubset/sft.cxx:1038
+vcl/source/fontsubset/sft.cxx:1046
     vcl::subHeader2 firstCode const sal_uInt16
-vcl/source/fontsubset/sft.cxx:1039
+vcl/source/fontsubset/sft.cxx:1047
     vcl::subHeader2 entryCount const sal_uInt16
-vcl/source/fontsubset/sft.cxx:1040
+vcl/source/fontsubset/sft.cxx:1048
     vcl::subHeader2 idDelta const sal_uInt16
 vcl/source/gdi/dibtools.cxx:52
     (anonymous namespace)::CIEXYZ aXyzX FXPT2DOT30
@@ -962,11 +958,9 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:47
     AtkObjectWrapper aParent const AtkObject
 vcl/unx/gtk3/a11y/atkwrapper.hxx:75
     AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
-vcl/unx/gtk3/gtk3gloactiongroup.cxx:26
-    GLOAction parent_instance GObject
 vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
-vcl/unx/gtk3/gtk3gtkinst.cxx:1596
+vcl/unx/gtk3/gtk3gtkinst.cxx:1602
      out gpointer *
 writerfilter/inc/ooxml/QNameToString.hxx:41
     writerfilter::QNameToString mMap writerfilter::QNameToString::Map
diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index 8080abf394d7..69c47f4eac2c 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -24,7 +24,7 @@ canvas/workben/canvasdemo.cxx:83
     DemoRenderer maColorWhite uno::Sequence<double>
 chart2/source/controller/inc/RangeSelectionListener.hxx:63
     chart::RangeSelectionListener m_aControllerLockGuard class chart::ControllerLockGuardUNO
-comphelper/source/container/enumerablemap.cxx:290
+comphelper/source/container/enumerablemap.cxx:292
     comphelper::MapEnumeration m_xKeepMapAlive Reference<class com::sun::star::uno::XInterface>
 connectivity/source/drivers/evoab2/EApi.h:122
     (anonymous) address_format char *
@@ -50,7 +50,7 @@ include/basegfx/DrawCommands.hxx:142
     gfx::DrawPath mpFillGradient std::shared_ptr<GradientInfo>
 include/drawinglayer/primitive2d/textlayoutdevice.hxx:58
     drawinglayer::primitive2d::TextLayouterDevice maSolarGuard class SolarMutexGuard
-include/editeng/unotext.hxx:604
+include/editeng/unotext.hxx:605
     SvxUnoTextRangeEnumeration mxParentText css::uno::Reference<css::text::XText>
 include/LibreOfficeKit/LibreOfficeKitGtk.h:33
     _LOKDocView aDrawingArea GtkDrawingArea
@@ -83,11 +83,11 @@ include/sfx2/msg.hxx:133
 include/sfx2/msg.hxx:134
     SfxType3 pType const std::type_info *
 include/sfx2/msg.hxx:134
-    SfxType3 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
-include/sfx2/msg.hxx:134
     SfxType3 nAttribs sal_uInt16
 include/sfx2/msg.hxx:134
     SfxType3 aAttrib struct SfxTypeAttrib [3]
+include/sfx2/msg.hxx:134
+    SfxType3 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:135
     SfxType4 aAttrib struct SfxTypeAttrib [4]
 include/sfx2/msg.hxx:135
@@ -208,12 +208,18 @@ include/vcl/NotebookBarAddonsMerger.hxx:45
     AddonsParams sControlType class rtl::OUString
 include/vcl/NotebookBarAddonsMerger.hxx:46
     AddonsParams nWidth sal_uInt16
+include/vcl/svtabbx.hxx:40
+    TabListBoxEventData m_pEntry class SvTreeListEntry *const
+include/vcl/svtabbx.hxx:41
+    TabListBoxEventData m_nColumn const sal_uInt16
+include/vcl/svtabbx.hxx:42
+    TabListBoxEventData m_sOldText const class rtl::OUString
 include/vcl/uitest/uiobject.hxx:272
     TabPageUIObject mxTabPage VclPtr<class TabPage>
 include/xmloff/formlayerexport.hxx:172
     xmloff::OOfficeFormsExport m_pImpl std::unique_ptr<OFormsRootExport>
-libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:35
-    GtvApplicationWindowPrivate lokDialog GtkWidget *
+libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx:37
+    (anonymous namespace)::GtvApplicationWindowPrivate lokDialog GtkWidget *
 libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:52
     GtvApplicationWindow parent_instance GtkApplicationWindow
 libreofficekit/qa/gtktiledviewer/gtv-application-window.hxx:56
@@ -264,23 +270,23 @@ sal/osl/unx/thread.cxx:95
     osl_thread_priority_st m_Lowest int
 sal/osl/unx/thread.cxx:113
     osl_thread_global_st m_priority struct osl_thread_priority_st
-sal/qa/osl/condition/osl_Condition.cxx:68
+sal/qa/osl/condition/osl_Condition.cxx:72
     osl_Condition::ctors bRes1 _Bool
-sal/qa/osl/condition/osl_Condition.cxx:198
+sal/qa/osl/condition/osl_Condition.cxx:202
     osl_Condition::wait bRes2 _Bool
-sal/qa/osl/condition/osl_Condition.cxx:269
+sal/qa/osl/condition/osl_Condition.cxx:273
     osl_Condition::check bRes2 _Bool
-sal/qa/osl/file/osl_File.cxx:1586
-    osl_FileStatus::getFileType m_aFifoItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1586
+sal/qa/osl/file/osl_File.cxx:1590
     osl_FileStatus::getFileType m_aVolumeItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1587
+sal/qa/osl/file/osl_File.cxx:1590
+    osl_FileStatus::getFileType m_aFifoItem class osl::DirectoryItem
+sal/qa/osl/file/osl_File.cxx:1591
+    osl_FileStatus::getFileType m_aSpecialItem class osl::DirectoryItem
+sal/qa/osl/file/osl_File.cxx:1591
     osl_FileStatus::getFileType m_aLinkItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1587
+sal/qa/osl/file/osl_File.cxx:1591
     osl_FileStatus::getFileType m_aSocketItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:1587
-    osl_FileStatus::getFileType m_aSpecialItem class osl::DirectoryItem
-sal/qa/osl/file/osl_File.cxx:3419
+sal/qa/osl/file/osl_File.cxx:3423
     osl_File::setAttributes rItem_hidden class osl::DirectoryItem
 sal/qa/osl/module/osl_Module.cxx:67
     osl_Module::ctors bRes1 _Bool
@@ -314,8 +320,6 @@ sal/qa/osl/security/osl_Security.cxx:154
     osl_Security::getUserName bRes1 _Bool
 sal/qa/osl/security/osl_Security.cxx:188
     osl_Security::getConfigDir bRes1 _Bool
-sc/inc/markmulti.hxx:38
-    ScMultiSel mnMaxCol SCCOL
 sc/qa/unit/ucalc_column.cxx:104
     aInputs aName const char *
 sc/source/core/data/document.cxx:1237
@@ -388,8 +392,8 @@ svx/source/dialog/contimp.hxx:75
     SvxSuperContourDlg aContourItem class SvxContourDlgItem
 svx/source/dialog/weldeditview.cxx:306
     WeldEditSource m_rEditAcc class WeldEditAccessible &
-sw/qa/extras/layout/layout.cxx:2592
-      class SvtSysLocaleOptions &
+sw/qa/extras/uiwriter/uiwriter2.cxx:68
+      class SwUiWriterTest2 *
 sw/source/core/crsr/crbm.cxx:64
     (anonymous namespace)::CursorStateHelper m_aSaveState const class SwCursorSaveState
 sw/source/core/frmedt/fetab.cxx:73
@@ -454,7 +458,9 @@ vcl/source/uitest/uno/uitest_uno.cxx:35
     UITestUnoObj mpUITest std::unique_ptr<UITest>
 vcl/unx/gtk3/a11y/gtk3atkhypertext.cxx:29
     HyperLink atk_hyper_link const AtkHyperlink
-vcl/unx/gtk3/gtk3gtkinst.cxx:4831
-    CrippledViewport viewport GtkViewport
+vcl/unx/gtk3/gtk3gloactiongroup.cxx:27
+    (anonymous namespace)::GLOAction parent_instance GObject
+vcl/unx/gtk3/gtk3gtkinst.cxx:4850
+    (anonymous namespace)::CrippledViewport viewport GtkViewport
 writerfilter/source/ooxml/OOXMLStreamImpl.hxx:43
     writerfilter::ooxml::OOXMLStreamImpl mxFastParser css::uno::Reference<css::xml::sax::XFastParser>
diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results
index 6de51cf586c3..ba5c6c1049a6 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -236,9 +236,9 @@ dbaccess/source/ui/inc/RelationController.hxx:33
     dbaui::ORelationController m_pWaitObject std::unique_ptr<WaitObject>
 desktop/qa/desktop_lib/test_desktop_lib.cxx:223
     DesktopLOKTest m_bModified _Bool
-desktop/source/app/app.cxx:1211
+desktop/source/app/app.cxx:1215
     desktop::ExecuteGlobals pLanguageOptions std::unique_ptr<SvtLanguageOptions>
-desktop/source/app/app.cxx:1212
+desktop/source/app/app.cxx:1216
     desktop::ExecuteGlobals pPathOptions std::unique_ptr<SvtPathOptions>
 desktop/source/deployment/gui/dp_gui_extlistbox.hxx:136
     dp_gui::ExtensionBox_Impl m_vRemovedEntries std::vector<TEntry_Impl>
@@ -268,8 +268,6 @@ drawinglayer/source/attribute/sdrfillgraphicattribute.cxx:47
     drawinglayer::attribute::ImpSdrFillGraphicAttribute mbLogSize _Bool
 drawinglayer/source/attribute/sdrsceneattribute3d.cxx:32
     drawinglayer::attribute::ImpSdrSceneAttribute mfDistance double
-drawinglayer/source/tools/emfpcustomlinecap.hxx:34
-    emfplushelper::EMFPCustomLineCap mbIsFilled _Bool
 embeddedobj/source/inc/oleembobj.hxx:132
     OleEmbeddedObject m_nTargetState sal_Int32
 embeddedobj/source/inc/oleembobj.hxx:144
@@ -354,9 +352,9 @@ include/editeng/adjustitem.hxx:37
     SvxAdjustItem bLeft _Bool
 include/editeng/outlobj.hxx:43
     OutlinerParaObjData mbIsEditDoc _Bool
-include/editeng/unotext.hxx:415
+include/editeng/unotext.hxx:416
     SvxUnoTextBase xParentText css::uno::Reference<css::text::XText>
-include/editeng/unotext.hxx:584
+include/editeng/unotext.hxx:585
     SvxUnoTextContentEnumeration mxParentText css::uno::Reference<css::text::XText>
 include/framework/addonsoptions.hxx:74
     framework::MergeNotebookBarInstruction aMergePoint class rtl::OUString
@@ -486,11 +484,11 @@ registry/source/reflread.cxx:466
     ConstantPool::readDoubleConstant(sal_uInt16)::(anonymous union)::(anonymous) b2 sal_uInt32
 reportdesign/inc/RptObject.hxx:72
     rptui::OObjectBase m_xKeepShapeAlive css::uno::Reference<css::uno::XInterface>
-sal/qa/osl/file/osl_File.cxx:4156
-    osl_Directory::isOpen nError1 osl::class FileBase::RC
-sal/qa/osl/file/osl_File.cxx:4156
+sal/qa/osl/file/osl_File.cxx:4160
     osl_Directory::isOpen nError2 osl::class FileBase::RC
-sal/qa/osl/file/osl_File.cxx:4214
+sal/qa/osl/file/osl_File.cxx:4160
+    osl_Directory::isOpen nError1 osl::class FileBase::RC
+sal/qa/osl/file/osl_File.cxx:4218
     osl_Directory::close nError2 osl::class FileBase::RC
 sal/rtl/alloc_arena.hxx:35
     rtl_arena_stat_type m_mem_total sal_Size
@@ -538,7 +536,7 @@ sc/source/core/data/column.cxx:1398
     (anonymous namespace)::CopyByCloneHandler meListenType sc::StartListeningType
 sc/source/core/data/column.cxx:1399
     (anonymous namespace)::CopyByCloneHandler mnFormulaCellCloneFlags const enum ScCloneFlags
-sc/source/core/data/table2.cxx:3684
+sc/source/core/data/table2.cxx:3687
     (anonymous namespace)::OutlineArrayFinder mpArray class ScOutlineArray *
 sc/source/filter/excel/xltoolbar.hxx:25
     TBCCmd A _Bool
@@ -678,6 +676,8 @@ sfx2/source/inc/splitwin.hxx:51
     SfxSplitWindow pActive VclPtr<class SfxDockingWindow>
 sfx2/source/view/classificationcontroller.cxx:61
     sfx2::ClassificationCategoriesController m_aPropertyListener class sfx2::ClassificationPropertyListener
+sfx2/source/view/printer.cxx:40
+    SfxPrintOptDlg_Impl mbHelpDisabled _Bool
 slideshow/source/engine/opengl/TransitionImpl.hxx:296
     Vertex normal glm::vec3
 slideshow/source/engine/opengl/TransitionImpl.hxx:297
@@ -772,7 +772,7 @@ svx/source/sidebar/line/LinePropertyPanel.hxx:104
     svx::sidebar::LinePropertyPanel maEdgeStyle sfx2::sidebar::ControllerItem
 svx/source/sidebar/line/LinePropertyPanel.hxx:105
     svx::sidebar::LinePropertyPanel maCapStyle sfx2::sidebar::ControllerItem
-svx/source/svdraw/svdibrow.cxx:95
+svx/source/svdraw/svdibrow.cxx:98
     ImpItemListRow pType const std::type_info *
 svx/source/svdraw/svdpdf.hxx:196
     ImpSdrPdfImport mdPageWidthPts double
@@ -984,7 +984,7 @@ vcl/source/filter/jpeg/Exif.hxx:51
     Exif::ExifIFD tag sal_uInt8 [2]
 vcl/source/filter/wmf/wmfwr.hxx:95
     WMFWriter aDstClipRegion vcl::Region
-vcl/source/fontsubset/sft.cxx:88
+vcl/source/fontsubset/sft.cxx:92
     vcl::TTGlyphMetrics lsb sal_Int16
 vcl/source/fontsubset/ttcr.cxx:341
     vcl::tdata_post ptr void *
@@ -1014,17 +1014,15 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:75
     AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass
 vcl/unx/gtk3/a11y/gtk3atkutil.cxx:138
     DocumentFocusListener m_aRefList std::set<uno::Reference<uno::XInterface> >
-vcl/unx/gtk3/gtk3gloactiongroup.cxx:26
-    GLOAction parent_instance GObject
 vcl/unx/gtk3/gtk3glomenu.cxx:14
     GLOMenu parent_instance const GMenuModel
-vcl/unx/gtk3/gtk3gtkinst.cxx:1596
+vcl/unx/gtk3/gtk3gtkinst.cxx:1602
      in char *
 vcl/unx/gtk3/gtk3hudawareness.cxx:16
     HudAwarenessHandle connection GDBusConnection *
 vcl/unx/gtk3/gtk3hudawareness.cxx:19
     HudAwarenessHandle notify GDestroyNotify
-vcl/workben/vcldemo.cxx:1744
+vcl/workben/vcldemo.cxx:1748
     DemoWin mxThread rtl::Reference<RenderThread>
 writerfilter/source/dmapper/PropertyMap.hxx:204
     writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
diff --git a/include/sfx2/prnmon.hxx b/include/sfx2/prnmon.hxx
index ff9b2062e538..665d3ac07630 100644
--- a/include/sfx2/prnmon.hxx
+++ b/include/sfx2/prnmon.hxx
@@ -30,11 +30,9 @@ class SfxTabPage;
 class SfxItemSet;
 
 
-struct SfxPrintOptDlg_Impl;
 class SfxPrintOptionsDialog final : public weld::GenericDialogController
 {
 private:
-    std::unique_ptr<SfxPrintOptDlg_Impl>   pDlgImpl;
     std::unique_ptr<SfxItemSet>            pOptions;
     std::unique_ptr<weld::Widget>    m_xHelpBtn;
     std::unique_ptr<weld::Container> m_xContainer;
diff --git a/include/vcl/svtabbx.hxx b/include/vcl/svtabbx.hxx
index d97146806b6a..d59a4cfb9920 100644
--- a/include/vcl/svtabbx.hxx
+++ b/include/vcl/svtabbx.hxx
@@ -35,16 +35,6 @@ enum class SvTabJustify
     AdjustCenter = static_cast<int>(SvLBoxTabFlags::ADJUST_CENTER)
 };
 
-struct TabListBoxEventData
-{
-    SvTreeListEntry* const    m_pEntry;
-    sal_uInt16 const          m_nColumn;
-    OUString const            m_sOldText;
-
-    TabListBoxEventData( SvTreeListEntry* pEntry, sal_uInt16 nColumn, const OUString& rOldText ) :
-        m_pEntry( pEntry ), m_nColumn( nColumn ), m_sOldText( rOldText ) {}
-};
-
 class VCL_DLLPUBLIC SvTabListBox : public SvTreeListBox
 {
 private:
diff --git a/include/vcl/vclevent.hxx b/include/vcl/vclevent.hxx
index 24ee1f3d8297..22829b7bc4f2 100644
--- a/include/vcl/vclevent.hxx
+++ b/include/vcl/vclevent.hxx
@@ -114,7 +114,6 @@ enum class VclEventId
     TabbarPageRemoved,      // pData = pageid
     TabbarPageSelected,     // pData = pageid
     TabbarPageTextChanged,  // pData = pageid
-    TableCellNameChanged,   // pData = struct(Entry, Column, oldText)
     TableRowSelect,
     TabpageActivate,        // pData = pageid
     TabpageDeactivate,      // pData = pageid
diff --git a/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx b/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
index 9d448f467ff2..cac83565abe8 100644
--- a/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
+++ b/libreofficekit/qa/gtktiledviewer/gtv-application-window.cxx
@@ -34,7 +34,6 @@ struct GtvApplicationWindowPrivate
     GtkWidget* gridcontainer;
     GtkWidget* toolbarcontainer;
     GtkWidget* scrolledwindowcontainer;
-    GtkWidget* lokDialog;
 
     bool toolbarBroadcast;
     bool partSelectorBroadcast;
diff --git a/sfx2/source/view/printer.cxx b/sfx2/source/view/printer.cxx
index 244f2206bffa..1ec88004473d 100644
--- a/sfx2/source/view/printer.cxx
+++ b/sfx2/source/view/printer.cxx
@@ -33,16 +33,6 @@
 #include <sfx2/viewsh.hxx>
 #include <sfx2/tabdlg.hxx>
 
-// struct SfxPrinter_Impl ------------------------------------------------
-
-struct SfxPrintOptDlg_Impl
-{
-    bool        mbHelpDisabled;
-
-    SfxPrintOptDlg_Impl() :
-        mbHelpDisabled  ( false ) {}
-};
-
 // class SfxPrinter ------------------------------------------------------
 
 VclPtr<SfxPrinter> SfxPrinter::Create( SvStream& rStream, std::unique_ptr<SfxItemSet>&& pOptions )
@@ -167,7 +157,6 @@ SfxPrintOptionsDialog::SfxPrintOptionsDialog(weld::Window *pParent,
                                              SfxViewShell *pViewShell,
                                              const SfxItemSet *pSet)
     : GenericDialogController(pParent, "sfx/ui/printeroptionsdialog.ui", "PrinterOptionsDialog")
-    , pDlgImpl(new SfxPrintOptDlg_Impl)
     , pOptions(pSet->Clone())
     , m_xHelpBtn(m_xBuilder->weld_widget("help"))
     , m_xContainer(m_xDialog->weld_content_area())
@@ -201,7 +190,6 @@ short SfxPrintOptionsDialog::run()
 
 void SfxPrintOptionsDialog::DisableHelp()
 {
-    pDlgImpl->mbHelpDisabled = true;
     m_xHelpBtn->set_sensitive(false);
 }
 
diff --git a/svtools/source/control/inettbc.cxx b/svtools/source/control/inettbc.cxx
index 5ffd546dad6c..1bf5619b0199 100644
--- a/svtools/source/control/inettbc.cxx
+++ b/svtools/source/control/inettbc.cxx
@@ -91,7 +91,6 @@ class SvtMatchContext_Impl: public salhelper::Thread
     std::vector<OUString>           aCompletions;
     std::vector<OUString>           aURLs;
     svtools::AsynchronLink          aLink;
-    OUString const                  aBaseURL;
     OUString const                  aText;
     VclPtr<SvtURLBox>               pBox;
 
@@ -879,9 +878,7 @@ void SvtMatchContext_Impl::doExecute()
 
     OUString aMatch;
     INetProtocol eProt = INetURLObject::CompareProtocolScheme( aText );
-    INetProtocol eBaseProt = INetURLObject::CompareProtocolScheme( aBaseURL );
-    if ( aBaseURL.isEmpty() )
-        eBaseProt = INetURLObject::CompareProtocolScheme( SvtPathOptions().GetWorkPath() );
+    INetProtocol eBaseProt = INetURLObject::CompareProtocolScheme( SvtPathOptions().GetWorkPath() );
     INetProtocol eSmartProt = pBox->GetSmartProtocol();
 
     // if the user input is a valid URL, go on with it
@@ -893,7 +890,7 @@ void SvtMatchContext_Impl::doExecute()
         if( schedule() )
         {
             if ( eProt == INetProtocol::NotValid )
-                aMatch = SvtURLBox::ParseSmart( aText, aBaseURL );
+                aMatch = SvtURLBox::ParseSmart( aText, "" );
             else
                 aMatch = aText;
             if ( !aMatch.isEmpty() )
diff --git a/vcl/source/treelist/svtabbx.cxx b/vcl/source/treelist/svtabbx.cxx
index 19d404594436..ffea99cfca75 100644
--- a/vcl/source/treelist/svtabbx.cxx
+++ b/vcl/source/treelist/svtabbx.cxx
@@ -271,7 +271,6 @@ void SvTabListBox::SetEntryText(const OUString& rStr, SvTreeListEntry* pEntry, s
         return;
 
     sal_Int32 nIndex = 0;
-    const sal_uInt16 nTextColumn = nCol;
     const sal_uInt16 nCount = pEntry->ItemCount();
     for (sal_uInt16 nCur = 0; nCur < nCount; ++nCur)
     {
@@ -292,9 +291,6 @@ void SvTabListBox::SetEntryText(const OUString& rStr, SvTreeListEntry* pEntry, s
         }
     }
     GetModel()->InvalidateEntry( pEntry );
-
-    std::unique_ptr<TabListBoxEventData> pData( new TabListBoxEventData( pEntry, nTextColumn, sOldText ) );
-    CallEventListeners( VclEventId::TableCellNameChanged, pData.get() );
 }
 
 OUString SvTabListBox::GetCellText( sal_uLong nPos, sal_uInt16 nCol ) const


More information about the Libreoffice-commits mailing list