[Libreoffice-commits] core.git: hwpfilter/source i18npool/source io/source io/test lingucomponent/source linguistic/source linguistic/workben lotuswordpro/source

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Sun Nov 24 20:47:39 UTC 2019


 hwpfilter/source/attributes.cxx                      |    4 ---
 hwpfilter/source/hwpreader.cxx                       |    4 ---
 i18npool/source/calendar/calendar_jewish.cxx         |    2 -
 io/source/stm/streamhelper.cxx                       |    6 ----
 io/test/stm/pipetest.cxx                             |    3 --
 lingucomponent/source/thesaurus/libnth/nthesimp.cxx  |    6 +---
 linguistic/source/convdic.cxx                        |   20 ++++++---------
 linguistic/source/convdicxml.cxx                     |    9 ++-----
 linguistic/source/dlistimp.cxx                       |    5 +--
 linguistic/source/gciterator.cxx                     |    2 -
 linguistic/workben/sprophelp.cxx                     |    8 +++---
 linguistic/workben/sspellimp.cxx                     |    6 ++--
 lotuswordpro/source/filter/bento.hxx                 |    6 ++--
 lotuswordpro/source/filter/lwpbackgroundstuff.hxx    |    3 --
 lotuswordpro/source/filter/lwpborderstuff.cxx        |   24 +++++++------------
 lotuswordpro/source/filter/lwpframelayout.cxx        |    4 ---
 lotuswordpro/source/filter/lwpgrfobj.hxx             |   12 ++++-----
 lotuswordpro/source/filter/lwplaypiece.cxx           |   10 +++----
 lotuswordpro/source/filter/lwpnumberingoverride.cxx  |    3 --
 lotuswordpro/source/filter/lwpnumericfmt.hxx         |   12 ++-------
 lotuswordpro/source/filter/lwptabrack.cxx            |   15 ++++++-----
 lotuswordpro/source/filter/lwptblcell.hxx            |    3 --
 lotuswordpro/source/filter/lwptblformula.cxx         |   15 +++--------
 lotuswordpro/source/filter/lwptoc.cxx                |    5 +--
 lotuswordpro/source/filter/utbenvs.cxx               |    8 +++---
 lotuswordpro/source/filter/xfilter/xfsaxattrlist.cxx |    3 --
 26 files changed, 79 insertions(+), 119 deletions(-)

New commits:
commit d2c9e289733df395b911a46c1028014f42e75f99
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sun Nov 24 20:26:22 2019 +0100
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sun Nov 24 21:46:23 2019 +0100

    cppcheck: performing init in init list (hwpfilter, i., l.)
    
    Change-Id: Idf5b7be45d48076fbe191fbf1a2fa63c6da71902
    Reviewed-on: https://gerrit.libreoffice.org/83617
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/hwpfilter/source/attributes.cxx b/hwpfilter/source/attributes.cxx
index f9e33b1f40f7..1c0712b0f9ab 100644
--- a/hwpfilter/source/attributes.cxx
+++ b/hwpfilter/source/attributes.cxx
@@ -27,10 +27,8 @@ namespace {
 struct TagAttribute
 {
     TagAttribute( const OUString &rName, const OUString &rType , const OUString &rValue )
+       : sName(rName), sType(rType), sValue(rValue)
     {
-        sName     = rName;
-        sType     = rType;
-        sValue    = rValue;
     }
 
     OUString sName;
diff --git a/hwpfilter/source/hwpreader.cxx b/hwpfilter/source/hwpreader.cxx
index 51f072fed4ad..58eab6a8ed84 100644
--- a/hwpfilter/source/hwpreader.cxx
+++ b/hwpfilter/source/hwpreader.cxx
@@ -105,10 +105,8 @@ struct HwpReaderPrivate
     int nPnPos;
 };
 
-HwpReader::HwpReader()
+HwpReader::HwpReader() : mxList(new AttributeListImpl), d(new HwpReaderPrivate)
 {
-    mxList = new AttributeListImpl;
-    d.reset( new HwpReaderPrivate );
 }
 
 
diff --git a/i18npool/source/calendar/calendar_jewish.cxx b/i18npool/source/calendar/calendar_jewish.cxx
index 549bae3c12aa..ee35c5d90cf9 100644
--- a/i18npool/source/calendar/calendar_jewish.cxx
+++ b/i18npool/source/calendar/calendar_jewish.cxx
@@ -137,7 +137,7 @@ private:
     sal_Int32 day;    // 1..LastDayOfHebrewMonth(month, year)
 
 public:
-    HebrewDate(sal_Int32 m, sal_Int32 d, sal_Int32 y) { month = m; day = d; year = y; }
+    HebrewDate(sal_Int32 m, sal_Int32 d, sal_Int32 y) : year(y), month(m), day(d) { }
 
     explicit HebrewDate(sal_Int32 d) { // Computes the Hebrew date from the absolute date.
     year = (d + HebrewEpoch) / 366; // Approximation from below.
diff --git a/io/source/stm/streamhelper.cxx b/io/source/stm/streamhelper.cxx
index be0644d5e1b2..2eace1e70d4c 100644
--- a/io/source/stm/streamhelper.cxx
+++ b/io/source/stm/streamhelper.cxx
@@ -46,12 +46,8 @@ void MemFIFO::skip( sal_Int32 nBytesToSkip )
     forgetFromStart( nBytesToSkip );
 }
 
-MemRingBuffer::MemRingBuffer()
+MemRingBuffer::MemRingBuffer() : m_p(nullptr), m_nBufferLen(0), m_nStart(0), m_nOccupiedBuffer(0)
 {
-    m_nBufferLen            = 0;
-    m_p                     = nullptr;
-    m_nStart                = 0;
-    m_nOccupiedBuffer       = 0;
 }
 
 MemRingBuffer::~MemRingBuffer()
diff --git a/io/test/stm/pipetest.cxx b/io/test/stm/pipetest.cxx
index 6744ad1037a1..77c333b0dc80 100644
--- a/io/test/stm/pipetest.cxx
+++ b/io/test/stm/pipetest.cxx
@@ -55,9 +55,8 @@ class WriteToStreamThread :
 public:
 
     WriteToStreamThread( Reference< XOutputStream >  xOutput , int iMax )
+      : m_output(xOutput), m_iMax(iMax)
     {
-        m_output = xOutput;
-        m_iMax = iMax;
     }
 
     virtual ~WriteToStreamThread() {}
diff --git a/lingucomponent/source/thesaurus/libnth/nthesimp.cxx b/lingucomponent/source/thesaurus/libnth/nthesimp.cxx
index 260c51f83981..cb15183964e7 100644
--- a/lingucomponent/source/thesaurus/libnth/nthesimp.cxx
+++ b/lingucomponent/source/thesaurus/libnth/nthesimp.cxx
@@ -72,11 +72,9 @@ static uno::Reference< XLinguServiceManager2 > GetLngSvcMgr_Impl()
 }
 
 Thesaurus::Thesaurus() :
-    aEvtListeners   ( GetLinguMutex() )
+    aEvtListeners   ( GetLinguMutex() ), pPropHelper(nullptr), bDisposing(false),
+    prevLocale(LANGUAGE_DONTKNOW)
 {
-    bDisposing = false;
-    pPropHelper = nullptr;
-    prevLocale = LANGUAGE_DONTKNOW;
 }
 
 Thesaurus::~Thesaurus()
diff --git a/linguistic/source/convdic.cxx b/linguistic/source/convdic.cxx
index b07ea422a119..20ac65582078 100644
--- a/linguistic/source/convdic.cxx
+++ b/linguistic/source/convdic.cxx
@@ -149,24 +149,20 @@ ConvDic::ConvDic(
         sal_Int16 nConvType,
         bool bBiDirectional,
         const OUString &rMainURL) :
-    aFlushListeners( GetLinguMutex() )
-{
-    aName           = rName;
-    nLanguage       = nLang;
-    nConversionType = nConvType;
-    aMainURL        = rMainURL;
+    aFlushListeners( GetLinguMutex() ),
+    aMainURL(rMainURL), aName(rName), nLanguage(nLang),
+    nConversionType(nConvType),
+    nMaxLeftCharCount(0), nMaxRightCharCount(0),
+    bMaxCharCountIsValid(true),
+    bNeedEntries(true),
+    bIsModified(false), bIsActive(false)
 
+{
     if (bBiDirectional)
         pFromRight.reset( new ConvMap );
     if (nLang == LANGUAGE_CHINESE_SIMPLIFIED || nLang == LANGUAGE_CHINESE_TRADITIONAL)
         pConvPropType.reset( new PropTypeMap );
 
-    nMaxLeftCharCount = nMaxRightCharCount = 0;
-    bMaxCharCountIsValid = true;
-
-    bNeedEntries = true;
-    bIsModified  = bIsActive = false;
-
     if( !rMainURL.isEmpty() )
     {
         bool bExists = false;
diff --git a/linguistic/source/convdicxml.cxx b/linguistic/source/convdicxml.cxx
index ccd52688108e..c66ed32a9264 100644
--- a/linguistic/source/convdicxml.cxx
+++ b/linguistic/source/convdicxml.cxx
@@ -99,10 +99,9 @@ class ConvDicXMLDictionaryContext_Impl :
 
 public:
     ConvDicXMLDictionaryContext_Impl( ConvDicXMLImport &rImport ) :
-        ConvDicXMLImportContext( rImport )
+        ConvDicXMLImportContext( rImport ),
+        nLanguage(LANGUAGE_NONE), nConversionType(-1)
     {
-        nLanguage = LANGUAGE_NONE;
-        nConversionType = -1;
     }
 
     // SvXMLImportContext
@@ -347,10 +346,8 @@ void ConvDicXMLExport::ExportContent_()
     //!!  see comment for pDic member
 ConvDicXMLImport::ConvDicXMLImport( ConvDic *pConvDic ) :
     SvXMLImport ( comphelper::getProcessComponentContext(), "com.sun.star.lingu2.ConvDicXMLImport", SvXMLImportFlags::ALL ),
-    pDic        ( pConvDic )
+    pDic        ( pConvDic ), nLanguage(LANGUAGE_NONE), nConversionType(-1)
 {
-    nLanguage       = LANGUAGE_NONE;
-    nConversionType = -1;
     GetNamespaceMap().Add( GetXMLToken(XML_NP_TCD), GetXMLToken(XML_N_TCD), XML_NAMESPACE_TCD);
 }
 
diff --git a/linguistic/source/dlistimp.cxx b/linguistic/source/dlistimp.cxx
index d97957a304b9..abe2aa291efd 100644
--- a/linguistic/source/dlistimp.cxx
+++ b/linguistic/source/dlistimp.cxx
@@ -102,10 +102,9 @@ public:
 DicEvtListenerHelper::DicEvtListenerHelper(
         const uno::Reference< XDictionaryList > &rxDicList ) :
     aDicListEvtListeners    ( GetLinguMutex() ),
-    xMyDicList              ( rxDicList )
+    xMyDicList              ( rxDicList ),
+    nCondensedEvt(0), nNumCollectEvtListeners(0)
 {
-    nCondensedEvt   = 0;
-    nNumCollectEvtListeners = 0;
 }
 
 
diff --git a/linguistic/source/gciterator.cxx b/linguistic/source/gciterator.cxx
index 81c1ce99d9c4..95624a9ccd38 100644
--- a/linguistic/source/gciterator.cxx
+++ b/linguistic/source/gciterator.cxx
@@ -277,10 +277,10 @@ GrammarCheckingIterator::GrammarCheckingIterator() :
     m_aCurCheckedDocId(),
     m_bGCServicesChecked( false ),
     m_nDocIdCounter( 0 ),
+    m_thread(nullptr),
     m_aEventListeners( MyMutex::get() ),
     m_aNotifyListeners( MyMutex::get() )
 {
-    m_thread = nullptr;
 }
 
 
diff --git a/linguistic/workben/sprophelp.cxx b/linguistic/workben/sprophelp.cxx
index e957a06742fe..41542fec155f 100644
--- a/linguistic/workben/sprophelp.cxx
+++ b/linguistic/workben/sprophelp.cxx
@@ -57,13 +57,13 @@ PropertyChgHelper::PropertyChgHelper(
 
 
 PropertyChgHelper::PropertyChgHelper( const PropertyChgHelper &rHelper ) :
-    aLngSvcEvtListeners (GetLinguMutex())
+    aPropNames(rHelper.aPropNames),
+    xMyEvtObj(rHelper.xMyEvtObj),
+    aLngSvcEvtListeners (GetLinguMutex()),
+    xPropSet(rHelper.xPropSet)
 {
-    xPropSet    = rHelper.xPropSet;
-    aPropNames  = rHelper.aPropNames;
     AddAsPropListener();
 
-    xMyEvtObj   = rHelper.xMyEvtObj;
 }
 
 
diff --git a/linguistic/workben/sspellimp.cxx b/linguistic/workben/sspellimp.cxx
index 51d9c14abf0e..6cfc89cef298 100644
--- a/linguistic/workben/sspellimp.cxx
+++ b/linguistic/workben/sspellimp.cxx
@@ -50,10 +50,10 @@ sal_Bool operator == ( const Locale &rL1, const Locale &rL2 )
 
 
 SpellChecker::SpellChecker() :
-    aEvtListeners   ( GetLinguMutex() )
+    aEvtListeners   ( GetLinguMutex() ),
+    pPropHelper(NULL),
+    bDisposing(sal_False)
 {
-    bDisposing = sal_False;
-    pPropHelper = NULL;
 }
 
 
diff --git a/lotuswordpro/source/filter/bento.hxx b/lotuswordpro/source/filter/bento.hxx
index 9f9447f4d7c1..b15cb6bc371f 100644
--- a/lotuswordpro/source/filter/bento.hxx
+++ b/lotuswordpro/source/filter/bento.hxx
@@ -142,9 +142,9 @@ sal_uLong BenOpenContainer(LwpSvStream * pStream, std::unique_ptr<LtcBenContaine
 class CBenIDListElmt : public CUtListElmt
 {
 public: // Internal methods
-    CBenIDListElmt(BenObjectID ID, CUtListElmt * pPrev) : CUtListElmt(pPrev)
-      { cID = ID; }
-    explicit CBenIDListElmt(BenObjectID ID) { cID = ID; }
+    CBenIDListElmt(BenObjectID ID, CUtListElmt * pPrev) : CUtListElmt(pPrev), cID(ID)
+      { }
+    explicit CBenIDListElmt(BenObjectID ID) : cID(ID) { }
     BenObjectID GetID() const { return cID; }
 
 private: // Data
diff --git a/lotuswordpro/source/filter/lwpbackgroundstuff.hxx b/lotuswordpro/source/filter/lwpbackgroundstuff.hxx
index 6ace02784a52..424cc44950c1 100644
--- a/lotuswordpro/source/filter/lwpbackgroundstuff.hxx
+++ b/lotuswordpro/source/filter/lwpbackgroundstuff.hxx
@@ -139,9 +139,8 @@ class XFBGImage;
 class LwpBackgroundStuff
 {
 public:
-    LwpBackgroundStuff()
+    LwpBackgroundStuff() :  m_nID(0)
     {
-        m_nID = 0;
     }
 
 private:
diff --git a/lotuswordpro/source/filter/lwpborderstuff.cxx b/lotuswordpro/source/filter/lwpborderstuff.cxx
index 1e70e2e30e54..89cc11ac8f82 100644
--- a/lotuswordpro/source/filter/lwpborderstuff.cxx
+++ b/lotuswordpro/source/filter/lwpborderstuff.cxx
@@ -63,21 +63,17 @@
 #include <lwptools.hxx>
 
 LwpBorderStuff::LwpBorderStuff()
+  : m_nSides(0), m_nValid(0),
+    m_nBorderGroupIDLeft(0),
+    m_nBorderGroupIDRight(0),
+    m_nBorderGroupIDTop(0),
+    m_nBorderGroupIDBottom(0),
+    m_nGroupIndent(0),
+    m_nWidthLeft(0),
+    m_nWidthTop(0),
+    m_nWidthRight(0),
+    m_nWidthBottom(0)
 {
-    m_nSides = 0;
-    m_nValid = 0;
-
-    m_nBorderGroupIDLeft = 0;
-    m_nBorderGroupIDRight = 0;
-    m_nBorderGroupIDTop = 0;
-    m_nBorderGroupIDBottom = 0;
-
-    m_nGroupIndent = 0;
-
-    m_nWidthLeft = 0;
-    m_nWidthTop = 0;
-    m_nWidthRight = 0;
-    m_nWidthBottom = 0;
 }
 
 void    LwpBorderStuff::Read(LwpObjectStream *pStrm)
diff --git a/lotuswordpro/source/filter/lwpframelayout.cxx b/lotuswordpro/source/filter/lwpframelayout.cxx
index 3e6d9580f4e6..6f7a77e77b5f 100644
--- a/lotuswordpro/source/filter/lwpframelayout.cxx
+++ b/lotuswordpro/source/filter/lwpframelayout.cxx
@@ -1133,10 +1133,8 @@ void LwpGroupFrame::XFConvert(XFContentContainer* /*pCont*/)
 }
 
 LwpDropcapLayout::LwpDropcapLayout(LwpObjectHeader const &objHdr, LwpSvStream* pStrm)
-    : LwpFrameLayout(objHdr, pStrm)
+    : LwpFrameLayout(objHdr, pStrm), m_nLines(3), m_nChars(1)
 {
-    m_nChars = 1;
-    m_nLines = 3;
 }
 
 void LwpDropcapLayout::Read()
diff --git a/lotuswordpro/source/filter/lwpgrfobj.hxx b/lotuswordpro/source/filter/lwpgrfobj.hxx
index 0c26f1c6e062..988d338e9613 100644
--- a/lotuswordpro/source/filter/lwpgrfobj.hxx
+++ b/lotuswordpro/source/filter/lwpgrfobj.hxx
@@ -77,13 +77,13 @@ struct ImageProcessingData
     bool bInvertImage;
 
     ImageProcessingData()
+      : nBrightness(50),
+        nContrast(50),
+        nEdgeEnchancement(0),
+        nSmoothing(0),
+        bAutoContrast(false),
+        bInvertImage(false)
     {
-        nBrightness = 50;
-        nContrast = 50;
-        nEdgeEnchancement = 0;
-        nSmoothing = 0;
-        bAutoContrast = false;
-        bInvertImage= false;
     }
 };
 
diff --git a/lotuswordpro/source/filter/lwplaypiece.cxx b/lotuswordpro/source/filter/lwplaypiece.cxx
index c4519fc27592..1922e1543a6e 100644
--- a/lotuswordpro/source/filter/lwplaypiece.cxx
+++ b/lotuswordpro/source/filter/lwplaypiece.cxx
@@ -394,14 +394,14 @@ void LwpLayoutShadow::Parse(IXFStream* /*pOutputStream*/)
 {}
 
 LwpLayoutRelativityGuts::LwpLayoutRelativityGuts()
+  : m_nRelType(LAY_PARENT_RELATIVE),
+    m_nRelFromWhere(LAY_UPPERLEFT),
+    m_nTether(LAY_UPPERLEFT),
+    m_nTetherWhere(LAY_BORDER),
+    m_nFlags(0)
 {
-    m_nRelType = LAY_PARENT_RELATIVE;
-    m_nRelFromWhere = LAY_UPPERLEFT;
     m_RelDistance.SetX(0);
     m_RelDistance.SetY(0);
-    m_nTether = LAY_UPPERLEFT;
-    m_nTetherWhere = LAY_BORDER;
-    m_nFlags = 0;
 }
 /**************************************************************************
  * @descr: Read LayoutRelativityGuts' information.
diff --git a/lotuswordpro/source/filter/lwpnumberingoverride.cxx b/lotuswordpro/source/filter/lwpnumberingoverride.cxx
index ae8de9dc9833..e04851bfd7be 100644
--- a/lotuswordpro/source/filter/lwpnumberingoverride.cxx
+++ b/lotuswordpro/source/filter/lwpnumberingoverride.cxx
@@ -62,9 +62,8 @@
 #include <lwpobjstrm.hxx>
 
 LwpNumberingOverride::LwpNumberingOverride()
+  : m_nLevel(0), m_nPosition(0)
 {
-    m_nLevel = 0;
-    m_nPosition = 0;
 }
 
 LwpNumberingOverride::LwpNumberingOverride(LwpNumberingOverride const& rOther)
diff --git a/lotuswordpro/source/filter/lwpnumericfmt.hxx b/lotuswordpro/source/filter/lwpnumericfmt.hxx
index bd21accecfe8..783ac8a71d46 100644
--- a/lotuswordpro/source/filter/lwpnumericfmt.hxx
+++ b/lotuswordpro/source/filter/lwpnumericfmt.hxx
@@ -102,21 +102,15 @@ struct LwpCurrencyInfo
     bool bPost;
     bool bShowSpace;
     explicit LwpCurrencyInfo(const OUString& sSym)
+      : sSymbol(sSym), bPost(false), bShowSpace(false)
     {
-        sSymbol = sSym;
-        bPost = false;
-        bShowSpace = false;
     }
-    LwpCurrencyInfo()
+    LwpCurrencyInfo() : bPost(false), bShowSpace(false)
     {
-        bPost = false;
-        bShowSpace = false;
     }
     LwpCurrencyInfo(const OUString& sSym, bool bPost_, bool bShowSpace_)
+        : sSymbol(sSym), bPost(bPost_), bShowSpace(bShowSpace_)
     {
-        sSymbol = sSym;
-        bPost = bPost_;
-        bShowSpace = bShowSpace_;
     }
 };
 
diff --git a/lotuswordpro/source/filter/lwptabrack.cxx b/lotuswordpro/source/filter/lwptabrack.cxx
index 5f852707a91d..84a80decd93b 100644
--- a/lotuswordpro/source/filter/lwptabrack.cxx
+++ b/lotuswordpro/source/filter/lwptabrack.cxx
@@ -63,12 +63,12 @@
 #include <stdexcept>
 
 LwpTab::LwpTab()
+  : m_nX(0),
+    m_nType(0),
+    m_nLeader(0),
+    m_nRelativeType(0),
+    m_nAlignChar(0)      //be careful,not quite sure it's 8-bit,perhaps 16-bit.
 {
-    m_nX = 0;
-    m_nAlignChar = 0;       //be careful,not quite sure it's 8-bit,perhaps 16-bit.
-    m_nType = 0;
-    m_nLeader = 0;
-    m_nRelativeType = 0;
 }
 
 void    LwpTab::Read(LwpObjectStream *pStrm)
@@ -80,9 +80,10 @@ void    LwpTab::Read(LwpObjectStream *pStrm)
     m_nAlignChar = pStrm->QuickReaduInt16();
 }
 
-LwpTabRack::LwpTabRack(LwpObjectHeader objHdr, LwpSvStream* pStrm):LwpObject(objHdr,pStrm)
+LwpTabRack::LwpTabRack(LwpObjectHeader objHdr, LwpSvStream* pStrm)
+   : LwpObject(objHdr,pStrm),
+     m_nNumTabs(0)
 {
-    m_nNumTabs = 0;
 }
 
 void LwpTabRack::Read()
diff --git a/lotuswordpro/source/filter/lwptblcell.hxx b/lotuswordpro/source/filter/lwptblcell.hxx
index 4303cc9c05b6..7505b7cf549b 100644
--- a/lotuswordpro/source/filter/lwptblcell.hxx
+++ b/lotuswordpro/source/filter/lwptblcell.hxx
@@ -246,9 +246,8 @@ private:
 };
 
 inline
-LwpRowColumnQualifier::LwpRowColumnQualifier()
+LwpRowColumnQualifier::LwpRowColumnQualifier() : cFlags(0)
 {
-    cFlags = 0;
 }
 
 inline bool
diff --git a/lotuswordpro/source/filter/lwptblformula.cxx b/lotuswordpro/source/filter/lwptblformula.cxx
index f79bcaab6bcb..1a0b47822bbb 100644
--- a/lotuswordpro/source/filter/lwptblformula.cxx
+++ b/lotuswordpro/source/filter/lwptblformula.cxx
@@ -357,15 +357,13 @@ OUString LwpFormulaConst::ToString(LwpTableLayout* /*pCellsMap*/)
     return OUString::number(m_dVal);
 }
 
-LwpFormulaText::LwpFormulaText( const OUString& aText)
+LwpFormulaText::LwpFormulaText( const OUString& aText) : m_aText(aText)
 {
-    m_aText = aText;
 }
 
 LwpFormulaCellAddr::LwpFormulaCellAddr(sal_Int16 aCol, sal_Int16 aRow)
+  : m_aCol(aCol), m_aRow(aRow)
 {
-    m_aCol = aCol;
-    m_aRow = aRow;
 }
 
 OUString LwpFormulaCellAddr::ToString(LwpTableLayout* pCellsMap)
@@ -378,11 +376,9 @@ LwpFormulaCellRangeAddr::LwpFormulaCellRangeAddr(sal_Int16 aStartCol,
                                                  sal_Int16 aStartRow,
                                                  sal_Int16 aEndCol,
                                                  sal_Int16 aEndRow)
+  : m_aStartCol(aStartCol), m_aStartRow(aStartRow),
+    m_aEndCol(aEndCol), m_aEndRow(aEndRow)
 {
-    m_aStartCol = aStartCol;
-    m_aStartRow = aStartRow;
-    m_aEndCol = aEndCol;
-    m_aEndRow = aEndRow;
 }
 
 /**
@@ -397,9 +393,8 @@ OUString LwpFormulaCellRangeAddr::ToString(LwpTableLayout* pCellsMap)
     return aCellAddr;
 }
 
-LwpFormulaFunc::LwpFormulaFunc(sal_uInt16 nTokenType)
+LwpFormulaFunc::LwpFormulaFunc(sal_uInt16 nTokenType) : m_nTokenType(nTokenType)
 {
-    m_nTokenType = nTokenType;
 }
 
 LwpFormulaFunc::~LwpFormulaFunc()
diff --git a/lotuswordpro/source/filter/lwptoc.cxx b/lotuswordpro/source/filter/lwptoc.cxx
index 89ab770e4726..4d429ddb258c 100644
--- a/lotuswordpro/source/filter/lwptoc.cxx
+++ b/lotuswordpro/source/filter/lwptoc.cxx
@@ -434,10 +434,9 @@ LwpTocLevelData * LwpTocSuperLayout::GetNextSearchLevelPtr(sal_uInt16 index, Lwp
     return nullptr;
 }
 
-LwpTocLevelData::LwpTocLevelData(LwpObjectHeader const &objHdr, LwpSvStream* pStrm):LwpDLVList(objHdr, pStrm)
+LwpTocLevelData::LwpTocLevelData(LwpObjectHeader const &objHdr, LwpSvStream* pStrm)
+  : LwpDLVList(objHdr, pStrm), m_nFlags(0), m_nLevel(0)
 {
-    m_nFlags = 0;
-    m_nLevel = 0;
 }
 LwpTocLevelData::~LwpTocLevelData()
 {
diff --git a/lotuswordpro/source/filter/utbenvs.cxx b/lotuswordpro/source/filter/utbenvs.cxx
index dc508c168664..f597351aee85 100644
--- a/lotuswordpro/source/filter/utbenvs.cxx
+++ b/lotuswordpro/source/filter/utbenvs.cxx
@@ -124,11 +124,11 @@ void    LtcUtBenValueStream::FlushData()
 *   Construction
 */
 LtcUtBenValueStream::LtcUtBenValueStream(CBenValue * pValue)
-{
+  : cpValue(pValue),
     // Calculate the length of the whole value stream
-    cCurrentPosition = 0;
-    m_ulValueLength = pValue->GetValueSize();
-    cpValue = pValue;
+    cCurrentPosition(0),
+    m_ulValueLength(pValue->GetValueSize())
+{
 }
 
 LtcUtBenValueStream::~LtcUtBenValueStream()
diff --git a/lotuswordpro/source/filter/xfilter/xfsaxattrlist.cxx b/lotuswordpro/source/filter/xfilter/xfsaxattrlist.cxx
index ffd36284f8c4..5bd78fb82190 100644
--- a/lotuswordpro/source/filter/xfilter/xfsaxattrlist.cxx
+++ b/lotuswordpro/source/filter/xfilter/xfsaxattrlist.cxx
@@ -60,9 +60,8 @@
 #include "xfsaxattrlist.hxx"
 #include <xmloff/attrlist.hxx>
 
-XFSaxAttrList::XFSaxAttrList()
+XFSaxAttrList::XFSaxAttrList() : m_xSvAttrList(new SvXMLAttributeList())
 {
-    m_xSvAttrList = new SvXMLAttributeList();
 }
 
 XFSaxAttrList::~XFSaxAttrList()


More information about the Libreoffice-commits mailing list