[Libreoffice-commits] core.git: vcl/inc vcl/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Nov 28 21:16:01 UTC 2019


 vcl/inc/impglyphitem.hxx        |    1 -
 vcl/source/gdi/impglyphitem.cxx |    2 --
 2 files changed, 3 deletions(-)

New commits:
commit aec49ceb877f3f3d79a77e60022ab08655798020
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Nov 28 18:00:15 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Nov 28 22:15:11 2019 +0100

    Drop unnecessarily user-provided ~SalLayoutGlyphsImpl
    
    ...thereby avoiding -Wdeprecated-copy-dtor when the implicitly-declared copy
    assignment op is used, but whose non-deleted definition was deprecated because
    of the user-provided dtor
    
    Change-Id: I9c4adc4b9ad0634c0afe5a4a707cc3697dbfae32
    Reviewed-on: https://gerrit.libreoffice.org/84020
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/vcl/inc/impglyphitem.hxx b/vcl/inc/impglyphitem.hxx
index b379674548d5..da56b660d7b6 100644
--- a/vcl/inc/impglyphitem.hxx
+++ b/vcl/inc/impglyphitem.hxx
@@ -119,7 +119,6 @@ class SalLayoutGlyphsImpl : public std::vector<GlyphItem>
     friend class GenericSalLayout;
 
 public:
-    ~SalLayoutGlyphsImpl();
     SalLayoutGlyphsImpl* clone(SalLayoutGlyphs& rGlyphs) const;
     LogicalFontInstance& GetFont() const { return *m_rFontInstance; }
     bool IsValid() const;
diff --git a/vcl/source/gdi/impglyphitem.cxx b/vcl/source/gdi/impglyphitem.cxx
index 64096020f172..3b52144769d0 100644
--- a/vcl/source/gdi/impglyphitem.cxx
+++ b/vcl/source/gdi/impglyphitem.cxx
@@ -53,8 +53,6 @@ void SalLayoutGlyphs::Invalidate()
         m_pImpl->Invalidate();
 }
 
-SalLayoutGlyphsImpl::~SalLayoutGlyphsImpl() {}
-
 SalLayoutGlyphsImpl* SalLayoutGlyphsImpl::clone(SalLayoutGlyphs& rGlyphs) const
 {
     SalLayoutGlyphsImpl* pNew = new SalLayoutGlyphsImpl(rGlyphs, *m_rFontInstance);


More information about the Libreoffice-commits mailing list