[Libreoffice-commits] core.git: include/editeng include/i18nlangtag

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Fri Nov 29 16:08:17 UTC 2019


 include/editeng/frmdiritem.hxx      |    5 +++++
 include/i18nlangtag/languagetag.hxx |    5 +++++
 2 files changed, 10 insertions(+)

New commits:
commit e9e4eb0736d5582fa37dcad20bf5826c50029249
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Nov 29 11:58:10 2019 +0100
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Nov 29 17:07:09 2019 +0100

    Fix some -Werror=deprecated-copy-dtor
    
    ...which would be found by GCC 10 trunk when explicitly enabling
    -Wdeprecated-copy-dtor (warning about cases where the non-deleted definition of
    an implicit copy ctor or assignment op is deprecated because of a user-provided
    dtor; looks like breaking it out into its own option, which, unlike
    -Wdeprecated-copy, isn't enabled by -Wextra, isn't all too helpful going
    forward, see discussion at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88136>
    "-Wdeprecated-copy is draconian and shouldn't be in -Wall").
    
    Using =delete instead of =default in cases that would otherwise cause Clang
    -Wdefaulted-function-deleted, cf. 3db830d354de80b319fb818a0373365a1e647264
    "Silence new Clang trunk -Wdefaulted-function-deleted".
    
    Change-Id: If50214ad8ac4e9ff12127eb3e07f610deabeca8a
    Reviewed-on: https://gerrit.libreoffice.org/84056
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/include/editeng/frmdiritem.hxx b/include/editeng/frmdiritem.hxx
index 6a0327dd051e..89524b743a4f 100644
--- a/include/editeng/frmdiritem.hxx
+++ b/include/editeng/frmdiritem.hxx
@@ -34,6 +34,11 @@ public:
     SvxFrameDirectionItem( SvxFrameDirection nValue, sal_uInt16 nWhich  );
     virtual ~SvxFrameDirectionItem() override;
 
+    SvxFrameDirectionItem(SvxFrameDirectionItem const &) = default;
+    SvxFrameDirectionItem(SvxFrameDirectionItem &&) = default;
+    SvxFrameDirectionItem & operator =(SvxFrameDirectionItem const &) = delete;
+    SvxFrameDirectionItem & operator =(SvxFrameDirectionItem &&) = delete;
+
     virtual SfxPoolItem*    Clone( SfxItemPool *pPool = nullptr ) const override;
 
     virtual bool            GetPresentation( SfxItemPresentation ePres,
diff --git a/include/i18nlangtag/languagetag.hxx b/include/i18nlangtag/languagetag.hxx
index 2d102a500c27..66b18d3faec7 100644
--- a/include/i18nlangtag/languagetag.hxx
+++ b/include/i18nlangtag/languagetag.hxx
@@ -109,6 +109,11 @@ public:
 
     ~LanguageTag();
 
+    LanguageTag(LanguageTag const &) = default;
+    LanguageTag(LanguageTag &&) = default;
+    LanguageTag & operator =(LanguageTag const &) = default;
+    LanguageTag & operator =(LanguageTag &&) = default;
+
     /** Obtain BCP 47 language tag.
 
         @param bResolveSystem


More information about the Libreoffice-commits mailing list