[Libreoffice-commits] core.git: instsetoo_native/inc_ooohelppack instsetoo_native/inc_openoffice instsetoo_native/inc_sdkoo

Mike Kaganski (via logerrit) logerrit at kemper.freedesktop.org
Sat Nov 30 13:25:29 UTC 2019


 instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt |    1 +
 instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt  |    1 +
 instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt       |    1 +
 3 files changed, 3 insertions(+)

New commits:
commit b17d6452667d9be8fcbb9c84d042da66713230ea
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sat Nov 30 12:45:56 2019 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sat Nov 30 14:24:14 2019 +0100

    MSI: Disable creation of system restore points during installation
    
    We don't install low-level system components that have potential of
    ruining the system, which would be the reason to create the restore
    points. Some systems suffer from very long creation of the restore
    points, like in tdf#129087:
    
    ...
    MSI (s) (60:00) [09:18:54:201]: Calling SRSetRestorePoint API. dwRestorePtType: 1, dwEventType: 102, llSequenceNumber: 0, szDescription: "Removed LibreOffice 6.3 Help Pack (English (United Kingdom))".
    MSI (s) (60:00) [09:26:57:699]: The call to SRSetRestorePoint API succeeded. Returned status: 0, llSequenceNumber: 73.
    ...
    
    So let's just disable the generation of restore points, as per [1].
    
    [1] https://docs.microsoft.com/en-us/windows/win32/msi/msifastinstall
    
    Change-Id: I452859d72284e0b2ea9a407e30a5e256a8c0a0f6
    Reviewed-on: https://gerrit.libreoffice.org/84113
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
index 9a9721b0dbb2..ca9abc8110e1 100644
--- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Property.idt
@@ -27,6 +27,7 @@ ISSCRIPT_VERSION_MISSING	IDS_ISSCRIPT_VERSION_MISSING
 ISSCRIPT_VERSION_OLD	IDS_ISSCRIPT_VERSION_OLD
 ISVROOT_PORT_NO	0
 Manufacturer	MANUFACTURERTEMPLATE
+MSIFASTINSTALL	1
 PIDTemplate	12345<###-%%%%%%%>@@@@@
 ProductCode	PRODUCTCODETEMPLATE
 ProductID	none
diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
index 03fab1ce9347..e528cac384ec 100644
--- a/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_openoffice/windows/msi_templates/Property.idt
@@ -28,6 +28,7 @@ ISSCRIPT_VERSION_MISSING	IDS_ISSCRIPT_VERSION_MISSING
 ISSCRIPT_VERSION_OLD	IDS_ISSCRIPT_VERSION_OLD
 ISVROOT_PORT_NO	0
 Manufacturer	MANUFACTURERTEMPLATE
+MSIFASTINSTALL	1
 MSIRESTARTMANAGERCONTROL	0
 MsiUIRMOption	DontUseRM
 PIDTemplate	12345<###-%%%%%%%>@@@@@
diff --git a/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt b/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt
index bea6abe6af03..bd9065fd92b5 100644
--- a/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt
+++ b/instsetoo_native/inc_sdkoo/windows/msi_templates/Property.idt
@@ -28,6 +28,7 @@ ISSCRIPT_VERSION_MISSING	IDS_ISSCRIPT_VERSION_MISSING
 ISSCRIPT_VERSION_OLD	IDS_ISSCRIPT_VERSION_OLD
 ISVROOT_PORT_NO	0
 Manufacturer	MANUFACTURERTEMPLATE
+MSIFASTINSTALL	1
 PIDTemplate	12345<###-%%%%%%%>@@@@@
 ProductCode	PRODUCTCODETEMPLATE
 ProductID	none


More information about the Libreoffice-commits mailing list