[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Tue Oct 1 15:37:37 UTC 2019


 compilerplugins/clang/badstatics.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 1028841feb815dfcfee97422f3de1e06e48db580
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Tue Oct 1 10:35:29 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Tue Oct 1 17:36:39 2019 +0200

    Silence a supposedly unproblematic loplugin:badstatics (clang-cl)
    
    Change-Id: I9c76fb4aca21757a0bf033103bd6dc2bea740eb5
    Reviewed-on: https://gerrit.libreoffice.org/79932
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/compilerplugins/clang/badstatics.cxx b/compilerplugins/clang/badstatics.cxx
index 5f1edea78476..737330dd10c0 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -210,6 +210,10 @@ public:
                 || name == "aNonThreadedInterpreterPool" // ScInterpreterContext(Pool), not owning
                 || name == "lcl_parserContext" // getParserContext(), the chain from this to a VclPtr is not owning
                 || name == "aReaderWriter" // /home/noel/libo/sw/source/filter/basflt/fltini.cxx, non-owning
+                || name == "aTwain"
+                   // Windows-only extensions/source/scanner/scanwin.cxx, problematic
+                   // Twain::mpThread -> ShimListenerThread::mxTopWindow released via Twain::Reset
+                   // clearing mpThread
                ) // these variables appear unproblematic
             {
                 return true;


More information about the Libreoffice-commits mailing list