[Libreoffice-commits] core.git: 2 commits - editeng/source sw/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Sat Oct 5 06:00:45 UTC 2019


 editeng/source/items/numitem.cxx |    1 -
 sw/source/core/doc/number.cxx    |    2 --
 2 files changed, 3 deletions(-)

New commits:
commit 594923028b45d55ef7cac3b28ded0d132dca2831
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Oct 4 21:58:59 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Sat Oct 5 07:59:50 2019 +0200

    Drop bogus memset
    
    ...that is both bad and unnecessary since
    57871f98d30c0283969de1a41e72f5838d6c0eb0 "loplugin:useuniqueptr in SwNumRule"
    changed SwNumRule::maFormats from an array of raw pointers to an array of
    std::unique_ptr.
    
    Change-Id: I0cb05f022b2f067c0b62ecd42878377b139ec4fe
    Reviewed-on: https://gerrit.libreoffice.org/80281
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sw/source/core/doc/number.cxx b/sw/source/core/doc/number.cxx
index dc438629e487..17bcd6ab9519 100644
--- a/sw/source/core/doc/number.cxx
+++ b/sw/source/core/doc/number.cxx
@@ -20,7 +20,6 @@
 #include <memory>
 #include <hintids.hxx>
 
-#include <string.h>
 #include <vcl/font.hxx>
 #include <editeng/brushitem.hxx>
 #include <editeng/lrspitem.hxx>
@@ -442,7 +441,6 @@ SwNumRule::SwNumRule( const OUString& rNm,
             SwNumRule::maLabelAlignmentBaseFormats[ OUTLINE_RULE ][ n ] = pFormat;
         }
     }
-    memset( maFormats, 0, sizeof( maFormats ));
     OSL_ENSURE( !msName.isEmpty(), "NumRule without a name!" );
 }
 
commit 52c3aae9b0ee9a3fb7cd38b6c4bb0b95916a1812
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Oct 4 21:01:10 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Sat Oct 5 07:59:31 2019 +0200

    Drop bogus memset
    
    ...that is both bad and unnecessary since
    76643b208c7f0c43b0603e08a3b37f29878c42ea "loplugin:useuniqueptr in SvxNumRule"
    changed SvxNumRule::aFmts from an array or raw pointers to an array of
    std::unique_ptr.
    
    Change-Id: I889da7973958d5546ded67be4f51f6312b240ea9
    Reviewed-on: https://gerrit.libreoffice.org/80275
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/editeng/source/items/numitem.cxx b/editeng/source/items/numitem.cxx
index 4d4215b51f7d..e35682e04fbe 100644
--- a/editeng/source/items/numitem.cxx
+++ b/editeng/source/items/numitem.cxx
@@ -626,7 +626,6 @@ SvxNumRule::SvxNumRule(const SvxNumRule& rCopy)
     nFeatureFlags        = rCopy.nFeatureFlags       ;
     bContinuousNumbering = rCopy.bContinuousNumbering;
     eNumberingType       = rCopy.eNumberingType;
-    memset( aFmts, 0, sizeof( aFmts ));
     for(sal_uInt16 i = 0; i < SVX_MAX_NUM; i++)
     {
         if(rCopy.aFmts[i])


More information about the Libreoffice-commits mailing list