[Libreoffice-commits] core.git: sc/source

[Caolán McNamara (via logerrit)]

 sc/source/filter/excel/xepivotxml.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit e933ffe1b863128471353c5d5e439bddccea4975
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Oct 9 09:29:36 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Oct 9 12:42:34 2019 +0200

    cid#1448346 Improper use of negative value
    
    Change-Id: I30b1bf8fd1dcbbdf0804f33b04133bf450eced55
    Reviewed-on: https://gerrit.libreoffice.org/80526
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/filter/excel/xepivotxml.cxx b/sc/source/filter/excel/xepivotxml.cxx
index dcf18e6e2b0a..d2dedf012c46 100644
--- a/sc/source/filter/excel/xepivotxml.cxx
+++ b/sc/source/filter/excel/xepivotxml.cxx
@@ -523,9 +523,12 @@ void XclExpXmlPivotCaches::SavePivotCacheXml( XclExpXmlStream& rStrm, const Entr
 
         ScDPSaveData* pSaveData = pDPObject->GetSaveData();
         assert(pSaveData);
+
         const ScDPSaveGroupDimension* pDim = pSaveData->GetDimensionData()->GetNamedGroupDim(aName);
         assert(pDim);
-        const size_t nBase = rCache.GetDimensionIndex(pDim->GetSourceDimName());
+
+        const SCCOL nBase = rCache.GetDimensionIndex(pDim->GetSourceDimName());
+        assert(nBase >= 0);
 
         pDefStrm->startElement(XML_cacheField, XML_name, aName.toUtf8(), XML_numFmtId,
                                OString::number(0), XML_databaseField, ToPsz10(false));