[Libreoffice-commits] core.git: include/basegfx svx/source
Miklos Vajna (via logerrit)
logerrit at kemper.freedesktop.org
Thu Oct 10 07:03:49 UTC 2019
include/basegfx/vector/b2dvector.hxx | 2 +-
svx/source/svdraw/svdmrkv.cxx | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 2256b477edf1bb8631f68fa90db074dc798d106e
Author: Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Wed Oct 9 21:58:23 2019 +0200
Commit: Miklos Vajna <vmiklos at collabora.com>
CommitDate: Thu Oct 10 09:03:11 2019 +0200
basegfx: warn on unused B2DVector
This is similar to tools::Rectangle, doesn't do anything useful in its
destructor.
Change-Id: I761801a0cf6979e6611f4341b41445cb05d8925b
Reviewed-on: https://gerrit.libreoffice.org/80566
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos at collabora.com>
diff --git a/include/basegfx/vector/b2dvector.hxx b/include/basegfx/vector/b2dvector.hxx
index 6c452f89bd47..d091ec2cda27 100644
--- a/include/basegfx/vector/b2dvector.hxx
+++ b/include/basegfx/vector/b2dvector.hxx
@@ -37,7 +37,7 @@ namespace basegfx
@see B2DTuple
*/
- class BASEGFX_DLLPUBLIC B2DVector : public ::basegfx::B2DTuple
+ class SAL_WARN_UNUSED BASEGFX_DLLPUBLIC B2DVector : public ::basegfx::B2DTuple
{
public:
/** Create a 2D Vector
diff --git a/svx/source/svdraw/svdmrkv.cxx b/svx/source/svdraw/svdmrkv.cxx
index ec1c96bdd65a..3d8d1be7b6c2 100644
--- a/svx/source/svdraw/svdmrkv.cxx
+++ b/svx/source/svdraw/svdmrkv.cxx
@@ -1987,7 +1987,6 @@ bool SdrMarkView::getPossibleGridOffsetForSdrObject(
return false;
}
- basegfx::B2DVector aOffset(0.0, 0.0);
const sdr::contact::ViewObjectContact& rVOC(pObj->GetViewContact().GetViewObjectContact(
const_cast<sdr::contact::ObjectContact&>(rObjectContact)));
@@ -2027,7 +2026,6 @@ bool SdrMarkView::getPossibleGridOffsetForPosition(
return false;
}
- basegfx::B2DVector aOffset(0.0, 0.0);
rObjectContact.calculateGridOffsetForB2DRange(rOffset, basegfx::B2DRange(rPoint));
return !rOffset.equalZero();
More information about the Libreoffice-commits
mailing list