[Libreoffice-commits] core.git: comphelper/source

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Sat Oct 12 14:30:51 UTC 2019


 comphelper/source/misc/configuration.cxx              |    6 +-----
 comphelper/source/property/propertystatecontainer.cxx |    6 +-----
 2 files changed, 2 insertions(+), 10 deletions(-)

New commits:
commit d6ea967e040d01ec69649ac689472018e477db34
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sat Oct 12 13:38:52 2019 +0200
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sat Oct 12 16:29:33 2019 +0200

    Get rid of 2 OUStringBuffer in comphelper
    
    Change-Id: Ib348288c729cab76ef39f6a33d173f7a20534f2f
    Reviewed-on: https://gerrit.libreoffice.org/80714
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/comphelper/source/misc/configuration.cxx b/comphelper/source/misc/configuration.cxx
index 89ce0e3be024..9c26e1a08307 100644
--- a/comphelper/source/misc/configuration.cxx
+++ b/comphelper/source/misc/configuration.cxx
@@ -55,17 +55,13 @@ OUString getDefaultLocale(
 }
 
 OUString extendLocalizedPath(OUString const & path, OUString const & locale) {
-    OUStringBuffer buf(path);
-    buf.append("/['*");
     SAL_WARN_IF(
         locale.match("*"), "comphelper",
         "Locale \"" << locale << "\" starts with \"*\"");
     assert(locale.indexOf('&') == -1);
     assert(locale.indexOf('"') == -1);
     assert(locale.indexOf('\'') == -1);
-    buf.append(locale);
-    buf.append("']");
-    return buf.makeStringAndClear();
+    return path + "/['*" + locale + "']";
 }
 
 }
diff --git a/comphelper/source/property/propertystatecontainer.cxx b/comphelper/source/property/propertystatecontainer.cxx
index 6d2071f90dfb..e83d4752a57e 100644
--- a/comphelper/source/property/propertystatecontainer.cxx
+++ b/comphelper/source/property/propertystatecontainer.cxx
@@ -37,11 +37,7 @@ namespace comphelper
             // Would be nice to have localized exception strings (a simply resource file containing
             // strings only would suffice, and could be realized with a UNO service, so we do not
             // need the dependency to the Tools project)
-            OUStringBuffer sMessage;
-            sMessage.append( "The property \"" );
-            sMessage.append( _rPropertyName );
-            sMessage.append( "\" is unknown." );
-            return sMessage.makeStringAndClear();
+            return "The property \"" + _rPropertyName + "\" is unknown.";
         }
     }
 


More information about the Libreoffice-commits mailing list