[Libreoffice-commits] core.git: compilerplugins/clang sw/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Fri Oct 18 07:16:54 UTC 2019


 compilerplugins/clang/virtualdead.unusedparams.results |    3 ---
 sw/source/filter/xml/xmlimpit.cxx                      |    6 ++----
 sw/source/filter/xml/xmlimpit.hxx                      |    3 +--
 sw/source/filter/xml/xmlitemi.cxx                      |    6 ++----
 4 files changed, 5 insertions(+), 13 deletions(-)

New commits:
commit 933592b2010e544440f17d6fd2489a019b1be9cd
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Oct 17 13:12:25 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Oct 18 09:15:42 2019 +0200

    loplugin:virtualdead unused param in SvXMLImportItemMapper::handleSpecialItem
    
    Change-Id: Ie1a8fdafb64f6374ae9108dbb47592b044703cc9
    Reviewed-on: https://gerrit.libreoffice.org/81008
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 6f7c786361d9..73274db75fc5 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -343,9 +343,6 @@ sw/source/filter/ww8/wrtww8.hxx:863
 sw/source/filter/xml/xmlexpit.hxx:84
     void SvXMLExportItemMapper::handleElementItem(class SvXMLExport &,const struct SvXMLItemMapEntry &,const class SfxPoolItem &,const class SvXMLUnitConverter &,const class SfxItemSet &,enum SvXmlExportFlags,)const
     011000
-sw/source/filter/xml/xmlimpit.hxx:48
-    _Bool SvXMLImportItemMapper::handleSpecialItem(const struct SvXMLItemMapEntry &,class SfxPoolItem &,class SfxItemSet &,const class rtl::OUString &,const class SvXMLUnitConverter &,const class SvXMLNamespaceMap &,)
-    111110
 vcl/inc/outdev.h:122
     _Bool ImplGlyphFallbackFontSubstitution::FindFontSubstitute(class FontSelectPattern &,class LogicalFontInstance *,class rtl::OUString &,)const
     101
diff --git a/sw/source/filter/xml/xmlimpit.cxx b/sw/source/filter/xml/xmlimpit.cxx
index 0ba10f9cfd25..2436e2e4f1c8 100644
--- a/sw/source/filter/xml/xmlimpit.cxx
+++ b/sw/source/filter/xml/xmlimpit.cxx
@@ -133,8 +133,7 @@ void SvXMLImportItemMapper::importXML( SfxItemSet& rSet,
                     else
                     {
                         bPut = handleSpecialItem( *pEntry, *pNewItem, rSet,
-                                                  rValue, rUnitConverter,
-                                                  rNamespaceMap );
+                                                  rValue, rUnitConverter );
                     }
 
                     if( bPut )
@@ -192,8 +191,7 @@ SvXMLImportItemMapper::handleSpecialItem(  const SvXMLItemMapEntry& /*rEntry*/,
                                             SfxPoolItem& /*rItem*/,
                                             SfxItemSet& /*rSet*/,
                                             const OUString& /*rValue*/,
-                                            const SvXMLUnitConverter& /*rUnitConverter*/,
-                                            const SvXMLNamespaceMap& /*rNamespaceMap*/ )
+                                            const SvXMLUnitConverter& /*rUnitConverter*/ )
 {
     OSL_FAIL( "unsupported special item in xml import" );
     return false;
diff --git a/sw/source/filter/xml/xmlimpit.hxx b/sw/source/filter/xml/xmlimpit.hxx
index d6c19b20bea3..ff6920faac17 100644
--- a/sw/source/filter/xml/xmlimpit.hxx
+++ b/sw/source/filter/xml/xmlimpit.hxx
@@ -49,8 +49,7 @@ public:
                                     SfxPoolItem& rItem,
                                     SfxItemSet& rSet,
                                     const OUString& rValue,
-                                    const SvXMLUnitConverter& rUnitConverter,
-                                    const SvXMLNamespaceMap& rNamespaceMap );
+                                    const SvXMLUnitConverter& rUnitConverter );
 
     /** this method is called for every item that has the
         MID_SW_FLAG_NO_ITEM_IMPORT flag set */
diff --git a/sw/source/filter/xml/xmlitemi.cxx b/sw/source/filter/xml/xmlitemi.cxx
index b14f28bc7534..e6542b33157d 100644
--- a/sw/source/filter/xml/xmlitemi.cxx
+++ b/sw/source/filter/xml/xmlitemi.cxx
@@ -63,8 +63,7 @@ public:
                                 SfxPoolItem& rItem,
                                 SfxItemSet& rSet,
                                 const OUString& rValue,
-                                const SvXMLUnitConverter& rUnitConverter,
-                                const SvXMLNamespaceMap& rNamespaceMap ) override;
+                                const SvXMLUnitConverter& rUnitConverter ) override;
 
     virtual bool
     handleNoItem(SvXMLItemMapEntry const& rEntry,
@@ -114,8 +113,7 @@ bool SwXMLImportTableItemMapper_Impl::handleSpecialItem(
                                         SfxPoolItem& rItem,
                                         SfxItemSet& rItemSet,
                                         const OUString& rValue,
-                                        const SvXMLUnitConverter& rUnitConv,
-                                        const SvXMLNamespaceMap& )
+                                        const SvXMLUnitConverter& rUnitConv )
 {
     bool bRet = false;
     sal_uInt16 nMemberId = static_cast< sal_Int16 >(rEntry.nMemberId & MID_SW_FLAG_MASK);


More information about the Libreoffice-commits mailing list