[Libreoffice-commits] core.git: compilerplugins/clang sd/source

[Noel Grandin (via logerrit)]

 compilerplugins/clang/virtualdead.unusedparams.results   |    3 ---
 sd/source/ui/inc/ViewClipboard.hxx                       |    3 +--
 sd/source/ui/slidesorter/controller/SlsClipboard.cxx     |    2 +-
 sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx |    3 +--
 sd/source/ui/view/ViewClipboard.cxx                      |    5 ++---
 5 files changed, 5 insertions(+), 11 deletions(-)

New commits:
commit 0093834e334d87c21e61f66952222368d742bde3
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Oct 17 15:17:40 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sat Oct 19 07:58:56 2019 +0200

    loplugin:virtualdead unused param in ViewClipboard::DetermineInsertPosition
    
    Change-Id: Iad1a4dbd603e9258e8835e7ab534cd74f4882968
    Reviewed-on: https://gerrit.libreoffice.org/81074
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 62eeae5aac7b..d8d9c708c7d9 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -244,9 +244,6 @@ sc/source/ui/vba/vbarange.hxx:68
 sd/source/ui/inc/View.hxx:92
     signed char sd::View::AcceptDrop(const struct AcceptDropEvent &,class DropTargetHelper &,class sd::Window *,unsigned short,struct o3tl::strong_int<unsigned char, struct SdrLayerIDTag>,)
     11001
-sd/source/ui/inc/ViewClipboard.hxx:64
-    unsigned short sd::ViewClipboard::DetermineInsertPosition(const class SdTransferable &,)
-    0
 sdext/source/pdfimport/inc/contentsink.hxx:150
     void pdfi::ContentSink::drawMask(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> &,_Bool,)
     10
diff --git a/sd/source/ui/inc/ViewClipboard.hxx b/sd/source/ui/inc/ViewClipboard.hxx
index 3c8516e893b0..1ed178307166 100644
--- a/sd/source/ui/inc/ViewClipboard.hxx
+++ b/sd/source/ui/inc/ViewClipboard.hxx
@@ -61,8 +61,7 @@ protected:
     /** Return an index of a page after which the pages of the transferable
         are to be inserted into the target document.
     */
-    virtual sal_uInt16 DetermineInsertPosition (
-        const SdTransferable& rTransferable);
+    virtual sal_uInt16 DetermineInsertPosition ();
 
     /** Insert the slides in the given transferable behind the last selected
         slide or, when the selection is empty, behind the last slide.
diff --git a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
index 1658b228977c..95a38e0ee03f 100644
--- a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx
@@ -801,7 +801,7 @@ void Clipboard::Abort()
     }
 }
 
-sal_uInt16 Clipboard::DetermineInsertPosition (const SdTransferable& )
+sal_uInt16 Clipboard::DetermineInsertPosition ()
 {
     // Tell the model to move the dragged pages behind the one with the
     // index nInsertionIndex which first has to be transformed into an index
diff --git a/sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx b/sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx
index b32e25b81383..d09c5297ed8f 100644
--- a/sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx
+++ b/sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx
@@ -98,8 +98,7 @@ public:
     void Abort();
 
 protected:
-    virtual sal_uInt16 DetermineInsertPosition (
-        const SdTransferable& rTransferable) override;
+    virtual sal_uInt16 DetermineInsertPosition () override;
 
 private:
     SlideSorter& mrSlideSorter;
diff --git a/sd/source/ui/view/ViewClipboard.cxx b/sd/source/ui/view/ViewClipboard.cxx
index 1256a4b677ff..9817cafdf454 100644
--- a/sd/source/ui/view/ViewClipboard.cxx
+++ b/sd/source/ui/view/ViewClipboard.cxx
@@ -56,7 +56,7 @@ void ViewClipboard::HandlePageDrop (const SdTransferable& rTransferable)
     if (pMasterPage)
         AssignMasterPage (rTransferable, pMasterPage);
     else
-        InsertSlides (rTransferable, DetermineInsertPosition (rTransferable));
+        InsertSlides (rTransferable, DetermineInsertPosition ());
 }
 
 SdPage* ViewClipboard::GetFirstMasterPage (const SdTransferable& rTransferable)
@@ -157,8 +157,7 @@ void ViewClipboard::AssignMasterPage (
         );
 }
 
-sal_uInt16 ViewClipboard::DetermineInsertPosition  (
-    const SdTransferable& )
+sal_uInt16 ViewClipboard::DetermineInsertPosition  ()
 {
     SdDrawDocument& rDoc = mrView.GetDoc();
     sal_uInt16 nPgCnt = rDoc.GetSdPageCount( PageKind::Standard );