[Libreoffice-commits] core.git: vcl/unx

Julien Nabet (via logerrit) logerrit at kemper.freedesktop.org
Sat Oct 19 16:29:21 UTC 2019


 vcl/unx/gtk3/gtk3gtkinst.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 5ed218d4ec26042f87b64a59c60373f35de962a7
Author:     Julien Nabet <serval2412 at yahoo.fr>
AuthorDate: Sat Oct 19 11:54:09 2019 +0200
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sat Oct 19 18:28:38 2019 +0200

    tdf#128241: fix crash when opening print dialog (gtk3 only)
    
    See bt here:
    https://bugs.documentfoundation.org/attachment.cgi?id=155131
    
    Change-Id: Ibd220f6f41b6cee6217465c534fac1af4bb2b51b
    Reviewed-on: https://gerrit.libreoffice.org/81123
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 5837e008af38..0d8f4d30b7c1 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -5349,7 +5349,7 @@ private:
         {
             const GtkWidget* pTabWidget = gtk_notebook_get_tab_label(pNotebook, gtk_notebook_get_nth_page(pNotebook, i));
             const gchar* pStr = gtk_buildable_get_name(GTK_BUILDABLE(pTabWidget));
-            if (strcmp(pStr, rIdent.getStr()) == 0)
+            if (pStr && strcmp(pStr, rIdent.getStr()) == 0)
                 return i;
         }
         return -1;


More information about the Libreoffice-commits mailing list