[Libreoffice-commits] core.git: compilerplugins/clang include/xmloff xmloff/inc xmloff/source

Noel Grandin (via logerrit) logerrit at kemper.freedesktop.org
Sun Oct 20 18:10:30 UTC 2019


 compilerplugins/clang/virtualdead.unusedparams.results |    3 ---
 include/xmloff/xmlevent.hxx                            |    4 +---
 xmloff/inc/XMLScriptContextFactory.hxx                 |    4 +---
 xmloff/inc/XMLStarBasicContextFactory.hxx              |    4 +---
 xmloff/source/script/XMLEventImportHelper.cxx          |    2 +-
 xmloff/source/script/XMLScriptContextFactory.cxx       |    3 +--
 xmloff/source/script/XMLStarBasicContextFactory.cxx    |    3 +--
 7 files changed, 6 insertions(+), 17 deletions(-)

New commits:
commit 1db6a4c78f688e8f9af5505e691bcae079c2348f
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Thu Oct 17 15:54:33 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sun Oct 20 20:09:23 2019 +0200

    loplugin:virtualdead unused param in XMLEventContextFactory::CreateContext
    
    Change-Id: I6fda2e04724d69fd218ffc85f9881b429714e63b
    Reviewed-on: https://gerrit.libreoffice.org/81154
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 3ac03d4acaa3..6a2cf9cc55f4 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -220,9 +220,6 @@ include/vcl/treelist.hxx:304
 include/xmloff/txtimp.hxx:677
     void XMLTextImportHelper::RedlineAdjustStartNodeCursor(_Bool,)
     0
-include/xmloff/xmlevent.hxx:129
-    class SvXMLImportContext * XMLEventContextFactory::CreateContext(class SvXMLImport &,unsigned short,const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::xml::sax::XAttributeList> &,class XMLEventsImportContext *,const class rtl::OUString &,const class rtl::OUString &,)
-    1111110
 include/xmloff/xmlimp.hxx:244
     class SvXMLImportContext * SvXMLImport::CreateDocumentContext(const unsigned short,const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::xml::sax::XAttributeList> &,)
     110
diff --git a/include/xmloff/xmlevent.hxx b/include/xmloff/xmlevent.hxx
index b0fa87403f62..5907d7acb4e6 100644
--- a/include/xmloff/xmlevent.hxx
+++ b/include/xmloff/xmlevent.hxx
@@ -134,9 +134,7 @@ public:
         /// the context for the enclosing <script:events> element
         XMLEventsImportContext* rEvents,
         /// the event name (as understood by the API)
-        const OUString& rApiEventName,
-        /// the event type name (as registered)
-        const OUString& rApiLanguage) = 0;
+        const OUString& rApiEventName) = 0;
 };
 
 
diff --git a/xmloff/inc/XMLScriptContextFactory.hxx b/xmloff/inc/XMLScriptContextFactory.hxx
index 07027dcf16cd..029c404f00b8 100644
--- a/xmloff/inc/XMLScriptContextFactory.hxx
+++ b/xmloff/inc/XMLScriptContextFactory.hxx
@@ -45,9 +45,7 @@ public:
                   /// the context for the enclosing <script:events> element
                   XMLEventsImportContext * rEvents,
                   /// the event name (as understood by the API)
-                  const OUString & rApiEventName,
-                  /// the event type name (as registered)
-                  const OUString & rLanguage) override;
+                  const OUString & rApiEventName) override;
 };
 
 #endif // INCLUDED_XMLOFF_INC_XMLSCRIPTCONTEXTFACTORY_HXX
diff --git a/xmloff/inc/XMLStarBasicContextFactory.hxx b/xmloff/inc/XMLStarBasicContextFactory.hxx
index 5ac877eacb69..8bce42b86bad 100644
--- a/xmloff/inc/XMLStarBasicContextFactory.hxx
+++ b/xmloff/inc/XMLStarBasicContextFactory.hxx
@@ -45,9 +45,7 @@ public:
         /// the context for the enclosing <script:events> element
         XMLEventsImportContext* rEvents,
         /// the event name (as understood by the API)
-        const OUString& rApiEventName,
-        /// the event type name (as registered)
-        const OUString& rLanguage) override;
+        const OUString& rApiEventName) override;
 };
 
 #endif
diff --git a/xmloff/source/script/XMLEventImportHelper.cxx b/xmloff/source/script/XMLEventImportHelper.cxx
index 42788bb1e0b2..1e2c39e144ae 100644
--- a/xmloff/source/script/XMLEventImportHelper.cxx
+++ b/xmloff/source/script/XMLEventImportHelper.cxx
@@ -133,7 +133,7 @@ SvXMLImportContext* XMLEventImportHelper::CreateContext(
             // delegate to factory
             pContext = aFactoryIterator->second->CreateContext(
                 rImport, nPrefix, rLocalName, xAttrList,
-                rEvents, aNameIter->second, aScriptLanguage);
+                rEvents, aNameIter->second);
         }
     }
 
diff --git a/xmloff/source/script/XMLScriptContextFactory.cxx b/xmloff/source/script/XMLScriptContextFactory.cxx
index 6fbbf53a7ebf..35b13d0ed95a 100644
--- a/xmloff/source/script/XMLScriptContextFactory.cxx
+++ b/xmloff/source/script/XMLScriptContextFactory.cxx
@@ -50,8 +50,7 @@ SvXMLImportContext * XMLScriptContextFactory::CreateContext
  const OUString & rLocalName,
  const Reference<XAttributeList> & xAttrList,
  XMLEventsImportContext * rEvents,
- const OUString & rApiEventName,
- const OUString & /*rApiLanguage*/)
+ const OUString & rApiEventName)
 {
     OUString sURLVal;
 
diff --git a/xmloff/source/script/XMLStarBasicContextFactory.cxx b/xmloff/source/script/XMLStarBasicContextFactory.cxx
index 7dd340b00301..15c7464bea80 100644
--- a/xmloff/source/script/XMLStarBasicContextFactory.cxx
+++ b/xmloff/source/script/XMLStarBasicContextFactory.cxx
@@ -52,8 +52,7 @@ SvXMLImportContext* XMLStarBasicContextFactory::CreateContext(
     const OUString& rLocalName,
     const Reference<XAttributeList> & xAttrList,
     XMLEventsImportContext* rEvents,
-    const OUString& rApiEventName,
-    const OUString& /*rApiLanguage*/)
+    const OUString& rApiEventName)
 {
     OUString sLibraryVal;
     OUString sMacroNameVal;


More information about the Libreoffice-commits mailing list