[Libreoffice-commits] core.git: compilerplugins/clang include/sfx2 sfx2/source

[Noel Grandin (via logerrit)]

 compilerplugins/clang/virtualdead.unusedparams.results |    3 ---
 include/sfx2/sidebar/DeckTitleBar.hxx                  |    2 +-
 include/sfx2/sidebar/PanelTitleBar.hxx                 |    2 +-
 include/sfx2/sidebar/TitleBar.hxx                      |    2 +-
 sfx2/source/sidebar/DeckTitleBar.cxx                   |    2 +-
 sfx2/source/sidebar/PanelTitleBar.cxx                  |    2 +-
 sfx2/source/sidebar/TitleBar.cxx                       |    2 +-
 7 files changed, 6 insertions(+), 9 deletions(-)

New commits:
commit 729989d485b0932bfac6997aa73e66364dc80cee
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Fri Oct 18 10:59:06 2019 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Oct 21 10:00:23 2019 +0200

    loplugin:virtualdead unused param in TitleBar::PaintDecoration
    
    Change-Id: I3dd8ee6492be1a4b3d1032c4d50cc01111d748cb
    Reviewed-on: https://gerrit.libreoffice.org/81185
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/virtualdead.unusedparams.results b/compilerplugins/clang/virtualdead.unusedparams.results
index 0bf53a2da0ce..2a25ea9b9981 100644
--- a/compilerplugins/clang/virtualdead.unusedparams.results
+++ b/compilerplugins/clang/virtualdead.unusedparams.results
@@ -142,9 +142,6 @@ include/sfx2/sfxstatuslistener.hxx:49
 include/sfx2/sidebar/ControllerItem.hxx:44
     void sfx2::sidebar::ControllerItem::ItemUpdateReceiverInterface::NotifyItemUpdate(const unsigned short,const enum SfxItemState,const class SfxPoolItem *,const _Bool,)
     1110
-include/sfx2/sidebar/TitleBar.hxx:61
-    void sfx2::sidebar::TitleBar::PaintDecoration(class OutputDevice &,const class tools::Rectangle &,)
-    10
 include/sfx2/stbitem.hxx:100
     _Bool SfxStatusBarControl::MouseButtonUp(const class MouseEvent &,)
     0
diff --git a/include/sfx2/sidebar/DeckTitleBar.hxx b/include/sfx2/sidebar/DeckTitleBar.hxx
index 26e1a29b4216..555ff0abd641 100644
--- a/include/sfx2/sidebar/DeckTitleBar.hxx
+++ b/include/sfx2/sidebar/DeckTitleBar.hxx
@@ -38,7 +38,7 @@ public:
 
 protected:
     virtual tools::Rectangle GetTitleArea(const tools::Rectangle& rTitleBarBox) override;
-    virtual void PaintDecoration(vcl::RenderContext& rRenderContext, const tools::Rectangle& rTitleBarBox) override;
+    virtual void PaintDecoration(vcl::RenderContext& rRenderContext) override;
     virtual sidebar::Paint GetBackgroundPaint() override;
     virtual void HandleToolBoxItemClick(const sal_uInt16 nItemIndex) override;
     virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override;
diff --git a/include/sfx2/sidebar/PanelTitleBar.hxx b/include/sfx2/sidebar/PanelTitleBar.hxx
index 1965caac687d..6c3216303e3c 100644
--- a/include/sfx2/sidebar/PanelTitleBar.hxx
+++ b/include/sfx2/sidebar/PanelTitleBar.hxx
@@ -46,7 +46,7 @@ public:
 
 protected:
     virtual tools::Rectangle GetTitleArea(const tools::Rectangle& rTitleBarBox) override;
-    virtual void PaintDecoration(vcl::RenderContext& rRenderContext, const tools::Rectangle& rTitleBarBox) override;
+    virtual void PaintDecoration(vcl::RenderContext& rRenderContext) override;
     virtual sidebar::Paint GetBackgroundPaint() override;
     virtual void HandleToolBoxItemClick (const sal_uInt16 nItemIndex) override;
     virtual css::uno::Reference<css::accessibility::XAccessible> CreateAccessible() override;
diff --git a/include/sfx2/sidebar/TitleBar.hxx b/include/sfx2/sidebar/TitleBar.hxx
index f69a7ef4e047..f06f6aa83fa8 100644
--- a/include/sfx2/sidebar/TitleBar.hxx
+++ b/include/sfx2/sidebar/TitleBar.hxx
@@ -58,7 +58,7 @@ protected:
     OUString msTitle;
 
     virtual tools::Rectangle GetTitleArea (const tools::Rectangle& rTitleBarBox) = 0;
-    virtual void PaintDecoration (vcl::RenderContext& rRenderContext, const tools::Rectangle& rTitleBarBox) = 0;
+    virtual void PaintDecoration (vcl::RenderContext& rRenderContext) = 0;
     void PaintFocus(vcl::RenderContext& rRenderContext, const tools::Rectangle& rFocusBox);
     virtual sidebar::Paint GetBackgroundPaint() = 0;
     virtual void HandleToolBoxItemClick (const sal_uInt16 nItemIndex);
diff --git a/sfx2/source/sidebar/DeckTitleBar.cxx b/sfx2/source/sidebar/DeckTitleBar.cxx
index 68301704972a..95e11dded6e3 100644
--- a/sfx2/source/sidebar/DeckTitleBar.cxx
+++ b/sfx2/source/sidebar/DeckTitleBar.cxx
@@ -93,7 +93,7 @@ tools::Rectangle DeckTitleBar::GetDragArea()
     );
 }
 
-void DeckTitleBar::PaintDecoration(vcl::RenderContext& rRenderContext, const tools::Rectangle& /*rTitleBarBox*/)
+void DeckTitleBar::PaintDecoration(vcl::RenderContext& rRenderContext)
 {
    Image aImage (Theme::GetImage(Theme::Image_Grip));
    const Point aTopLeft(gaLeftGripPadding,
diff --git a/sfx2/source/sidebar/PanelTitleBar.cxx b/sfx2/source/sidebar/PanelTitleBar.cxx
index 6071da7da9dd..4c3eca532164 100644
--- a/sfx2/source/sidebar/PanelTitleBar.cxx
+++ b/sfx2/source/sidebar/PanelTitleBar.cxx
@@ -120,7 +120,7 @@ tools::Rectangle PanelTitleBar::GetTitleArea (const tools::Rectangle& rTitleBarB
         return rTitleBarBox;
 }
 
-void PanelTitleBar::PaintDecoration (vcl::RenderContext& rRenderContext, const tools::Rectangle& /*rTitleBarBox*/)
+void PanelTitleBar::PaintDecoration (vcl::RenderContext& rRenderContext)
 {
     if (mpPanel != nullptr)
     {
diff --git a/sfx2/source/sidebar/TitleBar.cxx b/sfx2/source/sidebar/TitleBar.cxx
index 3d6f7ad5a5d1..8f45bb751c0c 100644
--- a/sfx2/source/sidebar/TitleBar.cxx
+++ b/sfx2/source/sidebar/TitleBar.cxx
@@ -82,7 +82,7 @@ void TitleBar::Paint(vcl::RenderContext& rRenderContext, const tools::Rectangle&
     Size aWindowSize (GetSizePixel());
     tools::Rectangle aTitleBarBox(0,0, aWindowSize.Width(), aWindowSize.Height());
 
-    PaintDecoration(rRenderContext, aTitleBarBox);
+    PaintDecoration(rRenderContext);
     const tools::Rectangle aTitleBox(GetTitleArea(aTitleBarBox));
     PaintTitle(rRenderContext, aTitleBox);
     PaintFocus(rRenderContext, aTitleBox);