[Libreoffice-commits] core.git: vcl/unx

Justin Luth (via logerrit) logerrit at kemper.freedesktop.org
Mon Oct 21 08:05:25 UTC 2019


 vcl/unx/gtk3/gtk3gtkinst.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 1baab81b8112f45a300d061ff1e3e6f3025d21bd
Author:     Justin Luth <justin.luth at collabora.com>
AuthorDate: Mon Oct 21 05:57:57 2019 +0300
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Mon Oct 21 10:04:10 2019 +0200

    fix unused function: SwapForRTL(widget) only if GTK3.22
    
    Compiling on Ubuntu 16.04 produced this error:
    vcl/unx/gtk3/gtk3gtkinst.cxx:1683:10: error:
    ‘bool {anonymous}::SwapForRTL(GtkWidget*)’
    defined but not used [-Werror=unused-function]
         bool SwapForRTL(GtkWidget* pWidget)
    
    Change-Id: I5f6c52a263d560208898d8fa136643d1bc037717
    Reviewed-on: https://gerrit.libreoffice.org/81193
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/unx/gtk3/gtk3gtkinst.cxx b/vcl/unx/gtk3/gtk3gtkinst.cxx
index 0b93a5a3f270..e59e1391e368 100644
--- a/vcl/unx/gtk3/gtk3gtkinst.cxx
+++ b/vcl/unx/gtk3/gtk3gtkinst.cxx
@@ -1680,6 +1680,7 @@ static MouseEventModifiers ImplGetMouseMoveMode(sal_uInt16 nCode)
 
 namespace
 {
+#if GTK_CHECK_VERSION(3,22,0)
     bool SwapForRTL(GtkWidget* pWidget)
     {
         GtkTextDirection eDir = gtk_widget_get_direction(pWidget);
@@ -1689,6 +1690,7 @@ namespace
             return false;
         return AllSettings::GetLayoutRTL();
     }
+#endif
 }
 
 class GtkInstanceWidget : public virtual weld::Widget


More information about the Libreoffice-commits mailing list